mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 04:31:56 +08:00
90efdd7f9d
This commit starts from a simple observation: cooking messages on the hot path can be slow. Especially with a lot of mentions. To move cooking from the hot path, this commit has made the following changes: - updating cooked, inserting mentions and notifying user of new mentions has been moved inside the `process_message` job. It happens right after the `Chat::MessageProcessor` run, which is where the cooking happens. - the similar existing code in `rebake!` has also been moved to rely on the `process_message`job only - refactored `create_mentions` and `update_mentions` into one single `upsert_mentions` which can be called invariably - allows services to decide if their job is ran inline or later. It avoids to need to know you have to use `Jobs.run_immediately!` in this case, in tests it will be inline per default - made various frontend changes to make the chat-channel component lifecycle clearer. we had to handle `did-update @channel` which was super awkward and creating bugs with listeners which the changes of the PR made clear in failing specs - adds a new `-processed` (and `-not-processed`) class on the chat message, this is made to have a good lifecyle hook in system specs
27 lines
826 B
Ruby
27 lines
826 B
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Message errors", type: :system do
|
|
fab!(:current_user) { Fabricate(:admin) }
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
|
let(:max_length) { SiteSetting.chat_maximum_message_length }
|
|
|
|
before { chat_system_bootstrap }
|
|
|
|
context "when message is too long" do
|
|
fab!(:channel) { Fabricate(:chat_channel) }
|
|
|
|
before { channel.add(current_user) }
|
|
|
|
it "only shows the error, not the message" do
|
|
sign_in(current_user)
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.send_message("atoolongmessage" + "a" * max_length)
|
|
|
|
expect(page).to have_no_content("atoolongmessage")
|
|
expect(page).to have_content(I18n.t("chat.errors.message_too_long", count: max_length))
|
|
end
|
|
end
|
|
end
|