mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 11:18:33 +08:00
ea5c3a3bdc
In AdminDashboardData we have a bunch of problem checks implemented as methods on that class. This PR absolves it of the responsibility by promoting each of those checks to a first class ProblemCheck. This way each of them can have their own priority and arbitrary functionality can be isolated in its own class. Think "extract class" refactoring over and over. Since they were all moved we can also get rid of the @@problem_syms class variable which was basically the old version of the registry now replaced by ProblemCheck.realtime. In addition AdminDashboardData::Problem value object has been entirely replaced with the new ProblemCheck::Problem (with compatible API). Lastly, I added some RSpec matchers to simplify testing of problem checks and provide helpful error messages when assertions fail.
57 lines
2.1 KiB
Ruby
57 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe ProblemCheck::TwitterConfig do
|
|
subject(:check) { described_class.new }
|
|
|
|
describe ".call" do
|
|
before { SiteSetting.stubs(enable_twitter_logins: enabled) }
|
|
|
|
context "when Twitter authentication is disabled" do
|
|
let(:enabled) { false }
|
|
|
|
it { expect(check).to be_chill_about_it }
|
|
end
|
|
|
|
context "when Twitter authentication is enabled and configured" do
|
|
let(:enabled) { true }
|
|
|
|
before do
|
|
SiteSetting.stubs(twitter_consumer_key: "foo")
|
|
SiteSetting.stubs(twitter_consumer_secret: "bar")
|
|
end
|
|
|
|
it { expect(check).to be_chill_about_it }
|
|
end
|
|
|
|
context "when Twitter authentication is enabled but missing client ID" do
|
|
let(:enabled) { true }
|
|
|
|
before do
|
|
SiteSetting.stubs(twitter_consumer_key: nil)
|
|
SiteSetting.stubs(twitter_consumer_secret: "bar")
|
|
end
|
|
|
|
it do
|
|
expect(check).to have_a_problem.with_priority("low").with_message(
|
|
'The server is configured to allow signup and login with Twitter (enable_twitter_logins), but the key and secret values are not set. Go to <a href="/admin/site_settings">the Site Settings</a> and update the settings. <a href="https://meta.discourse.org/t/configuring-twitter-login-for-discourse/13395" target="_blank">See this guide to learn more</a>.',
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when Twitter authentication is enabled but missing client secret" do
|
|
let(:enabled) { true }
|
|
|
|
before do
|
|
SiteSetting.stubs(twitter_consumer_key: "foo")
|
|
SiteSetting.stubs(twitter_consumer_secret: nil)
|
|
end
|
|
|
|
it do
|
|
expect(check).to have_a_problem.with_priority("low").with_message(
|
|
'The server is configured to allow signup and login with Twitter (enable_twitter_logins), but the key and secret values are not set. Go to <a href="/admin/site_settings">the Site Settings</a> and update the settings. <a href="https://meta.discourse.org/t/configuring-twitter-login-for-discourse/13395" target="_blank">See this guide to learn more</a>.',
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|