mirror of
https://github.com/discourse/discourse.git
synced 2024-12-14 22:44:10 +08:00
893b50031d
When both a cdn URL and an s3 cdn URL defined, subfolder paths were leaking through to the s3 cdn URL. If we are replacing the cdn url with the s3_cdn url, we also need to make sure that the subpath is removed as well, as it appears in the original cdn url. The test should give a fairly good gist of the situations - in subfolder situations where s3_cdn and a cdn is defined: `asset_path` returns the asset with a subfolder, in the form `{cdn_url}/{subfolder}/{asset_path}` Currently this is being replaced to `{s3_cdn_url}/{subfolder}/{asset_path}` I am proposing we change this to: `{s3_cdn_url}/{asset_path}` as it seems like for s3_cdn urls we should not be carrying around app subfolder pathing anywhere we are looking up s3 paths. |
||
---|---|---|
.. | ||
application_helper.rb | ||
common_helper.rb | ||
email_helper.rb | ||
embed_helper.rb | ||
list_helper.rb | ||
topics_helper.rb | ||
user_notifications_helper.rb |