mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 08:45:26 +08:00
bf886662df
This pull request is a full overhaul of the chat-composer and contains various improvements to the thread panel. They have been grouped in the same PR as lots of improvements/fixes to the thread panel needed an improved composer. This is meant as a first step. ### New features included in this PR - A resizable side panel - A clear dropzone area for uploads - A simplified design for image uploads, this is only a first step towards more redesign of this area in the future ### Notable fixes in this PR - Correct placeholder in thread panel - Allows to edit the last message of a thread with arrow up - Correctly focus composer when replying to a message - The reply indicator is added instantly in the channel when starting a thread - Prevents a large variety of bug where the composer could bug and prevent sending message or would clear your input while it has content ### Technical notes To achieve this PR, three important changes have been made: - `<ChatComposer>` has been fully rewritten and is now a glimmer component - The chat composer now takes a `ChatMessage` as input which can directly be used in other operations, it simplifies a lot of logic as we are always working a with a `ChatMessage` - `TextareaInteractor` has been created to wrap the existing `TextareaTextManipulation` mixin, it will make future migrations easier and allow us to have a less polluted `<ChatComposer>` Note ".chat-live-pane" has been renamed ".chat-channel" Design for upload dropzone is from @chapoi
131 lines
3.7 KiB
JavaScript
131 lines
3.7 KiB
JavaScript
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
|
import { exists, query } from "discourse/tests/helpers/qunit-helpers";
|
|
import hbs from "htmlbars-inline-precompile";
|
|
import I18n from "I18n";
|
|
import { click, render } from "@ember/test-helpers";
|
|
import { module, test } from "qunit";
|
|
|
|
module("Discourse Chat | Component | chat-composer-upload", function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
test("file - uploading in progress", async function (assert) {
|
|
this.set("upload", {
|
|
progress: 50,
|
|
extension: ".pdf",
|
|
fileName: "test.pdf",
|
|
});
|
|
|
|
await render(hbs`<ChatComposerUpload @upload={{this.upload}} />`);
|
|
|
|
assert.true(exists(".upload-progress[value=50]"));
|
|
assert.strictEqual(
|
|
query(".uploading").innerText.trim(),
|
|
I18n.t("uploading")
|
|
);
|
|
});
|
|
|
|
test("image - uploading in progress", async function (assert) {
|
|
this.set("upload", {
|
|
extension: ".png",
|
|
progress: 78,
|
|
fileName: "test.png",
|
|
});
|
|
|
|
await render(hbs`<ChatComposerUpload @upload={{this.upload}} />`);
|
|
|
|
assert.true(exists(".d-icon-far-image"));
|
|
assert.true(exists(".upload-progress[value=78]"));
|
|
assert.strictEqual(
|
|
query(".uploading").innerText.trim(),
|
|
I18n.t("uploading")
|
|
);
|
|
});
|
|
|
|
test("image - preprocessing upload in progress", async function (assert) {
|
|
this.set("upload", {
|
|
extension: ".png",
|
|
progress: 78,
|
|
fileName: "test.png",
|
|
processing: true,
|
|
});
|
|
|
|
await render(hbs`<ChatComposerUpload @upload={{this.upload}} />`);
|
|
|
|
assert.strictEqual(
|
|
query(".processing").innerText.trim(),
|
|
I18n.t("processing")
|
|
);
|
|
});
|
|
|
|
test("file - upload complete", async function (assert) {
|
|
this.set("upload", {
|
|
type: ".pdf",
|
|
original_filename: "some file.pdf",
|
|
extension: "pdf",
|
|
});
|
|
|
|
await render(
|
|
hbs`<ChatComposerUpload @isDone={{true}} @upload={{this.upload}} />`
|
|
);
|
|
|
|
assert.true(exists(".d-icon-file-alt"));
|
|
assert.strictEqual(query(".file-name").innerText.trim(), "some file.pdf");
|
|
assert.strictEqual(query(".extension-pill").innerText.trim(), "pdf");
|
|
});
|
|
|
|
test("image - upload complete", async function (assert) {
|
|
this.set("upload", {
|
|
type: ".png",
|
|
original_filename: "bar_image.png",
|
|
extension: "png",
|
|
short_path: "/images/avatar.png",
|
|
});
|
|
|
|
await render(
|
|
hbs`<ChatComposerUpload @isDone={{true}} @upload={{this.upload}} />`
|
|
);
|
|
|
|
assert.true(exists("img.preview-img[src='/images/avatar.png']"));
|
|
});
|
|
|
|
test("removing completed upload", async function (assert) {
|
|
this.set("uploadRemoved", false);
|
|
this.set("removeUpload", () => {
|
|
this.set("uploadRemoved", true);
|
|
});
|
|
this.set("upload", {
|
|
type: ".png",
|
|
original_filename: "bar_image.png",
|
|
extension: "png",
|
|
short_path: "/images/avatar.png",
|
|
});
|
|
|
|
await render(
|
|
hbs`<ChatComposerUpload @isDone={{true}} @upload={{this.upload}} @onCancel={{fn this.removeUpload this.upload}} />`
|
|
);
|
|
|
|
await click(".chat-composer-upload__remove-btn");
|
|
assert.strictEqual(this.uploadRemoved, true);
|
|
});
|
|
|
|
test("cancelling in progress upload", async function (assert) {
|
|
this.set("uploadRemoved", false);
|
|
this.set("removeUpload", () => {
|
|
this.set("uploadRemoved", true);
|
|
});
|
|
this.set("upload", {
|
|
type: ".png",
|
|
original_filename: "bar_image.png",
|
|
extension: "png",
|
|
short_path: "/images/avatar.png",
|
|
});
|
|
|
|
await render(
|
|
hbs`<ChatComposerUpload @upload={{this.upload}} @onCancel={{fn this.removeUpload this.upload}} />`
|
|
);
|
|
|
|
await click(".chat-composer-upload__remove-btn");
|
|
assert.strictEqual(this.uploadRemoved, true);
|
|
});
|
|
});
|