mirror of
https://github.com/discourse/discourse.git
synced 2024-12-09 16:53:46 +08:00
79a260a6bb
This commit fixes the selection of message in threads and also applies various refactorings - improves specs and especially page objects/components - makes the channel/thread panes responsible of the state - adds an animationend modifier - continues to follow the logic of "state" should be displayed as data attributes on component by having a new `data-selected` attribute on chat messages
53 lines
1.6 KiB
Ruby
53 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Chat | Select message | channel", type: :system do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
fab!(:message_2) { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
fab!(:message_3) { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
before do
|
|
chat_system_bootstrap
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "can select multiple messages" do
|
|
chat_page.visit_channel(channel_1)
|
|
|
|
channel_page.messages.select(message_1)
|
|
channel_page.messages.select(message_2)
|
|
|
|
expect(channel_page).to have_selected_messages(message_1, message_2)
|
|
end
|
|
|
|
it "can shift + click to select messages between the first and last" do
|
|
chat_page.visit_channel(channel_1)
|
|
channel_page.messages.select(message_1)
|
|
channel_page.messages.shift_select(message_3)
|
|
|
|
expect(channel_page).to have_selected_messages(message_1, message_2, message_3)
|
|
end
|
|
|
|
context "when visiting another channel" do
|
|
fab!(:channel_2) { Fabricate(:chat_channel) }
|
|
|
|
before { channel_2.add(current_user) }
|
|
|
|
it "resets message selection" do
|
|
chat_page.visit_channel(channel_1)
|
|
channel_page.messages.select(message_1)
|
|
|
|
expect(channel_page.selection_management).to be_visible
|
|
|
|
chat_page.visit_channel(channel_2)
|
|
|
|
expect(channel_page.selection_management).to be_not_visible
|
|
end
|
|
end
|
|
end
|