github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-11 23:06:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
b456320880
discourse/plugins/chat
History
Alan Guo Xiang Tan bf3e121323
DEV: Set config.eager_load = true on CI (#25032) 
Why this change?

When running system tests on our CI, we have been occasionally seeing
server errors like:

```
Error encountered while proccessing /stylesheets/desktop_e58cf7f686aab173f9b778797f241913c2833c39.css
  NoMethodError: undefined method `+' for nil:NilClass
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/path/pattern.rb:139:in `[]'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:127:in `block (2 levels) in find_routes'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:126:in `each'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:126:in `each_with_index'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:126:in `block in find_routes'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:123:in `map!'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:123:in `find_routes'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:32:in `serve'
    /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/routing/route_set.rb:852:in `call'
```

While looking through various Rails issues related to the error above, I
came across https://github.com/rails/rails/pull/27647 which is a fix to
fully initialize routes before the first request is handled. However,
the routes are only fully initialize only if `config.eager_load` is set
to `true`. There is no reason why `config.eager_load` shouldn't be `true` in the
CI environment and this is what a new Rails 7.1 app is generated with.

What does this change do?

Enable `config.eager_load` when `env["CI"]` is present
2023-12-26 13:05:55 +08:00
..
app DEV: Allow chat mentions to have several notifications (#24874) 2023-12-19 18:53:00 +04:00
assets FIX: prevents audio container to overflow container (#25012) 2023-12-22 09:38:21 +01:00
config Update translations (#24968) 2023-12-19 22:45:27 +01:00
db DEV: Allow chat mentions to have several notifications (#24874) 2023-12-19 18:53:00 +04:00
lib FIX: whitelist uploads before creating thumbnail variants (#25013) 2023-12-22 17:59:53 +08:00
public
spec DEV: Set config.eager_load = true on CI (#25032) 2023-12-26 13:05:55 +08:00
test/javascripts DEV: implements <Chat::Navbar /> (#24917) 2023-12-18 17:49:58 +01:00
plugin.rb FEATURE: Add thumbnails for chat image uploads (#24328) 2023-12-06 14:59:18 +08:00
README.md DEV: Chat service object initial implementation (#19814) 2023-02-13 13:09:57 +01:00

README.md

This plugin is still in active development and may change frequently

Documentation

The Discourse Chat plugin adds chat functionality to your Discourse so it can natively support both long-form and short-form communication needs of your online community.

For user documentation, see Discourse Chat.

For developer documentation, see Discourse Documentation.