discourse/app/assets/javascripts
Krzysztof Kotlarek b47b1d8af8 FIX: label helpers on sign up form are not hidden (#8603)
This commit fe9293b8b5 created a regression.

The problem is that dom changed a little bit.
Before it was
```
<tr class="instructions create-account-email">
  <td></td>
  <div id="account-email-validation" class="tip bad ember-view"></div>
  <td><label>Never shown to the public.</label></td>
</tr>
```

And after we got
```
<tr class="instructions create-account-email">
  <td></td>
  <div id="account-email-validation" class="tip bad ember-view"> </div>
  <td><label>Never shown to the public.</label></td>
</tr>
```
That small space may look like not important change.

However, now helpers are hitting that CSS rule:

```
.login-form {
  .tip {
    &:not(:empty) + td {
      display: none;
    }
}
```

To fix it, we should render template only if there is a reason - like it was before

```
if (reason) {
  buffer.push(iconHTML(this.good ? "check" : "times") + " " + reason);
}
```

* FIX: remove rerenderTriggers
2019-12-20 12:17:51 +01:00
..
admin FEATURE: Hash API keys in the database (#8438) 2019-12-12 11:45:00 +00:00
admin-login REFACTOR: use const rather than var 2019-10-03 11:45:03 -07:00
discourse FIX: label helpers on sign up form are not hidden (#8603) 2019-12-20 12:17:51 +01:00
discourse-common FIX: Limit requests and include data when reporting deprecated icons 2019-12-19 22:11:45 +00:00
docs
ember-addons DEV: Move computed to discourseComputed (#8312) 2019-11-07 15:38:28 -06:00
locales DEV: Import ember ENV instead of Ember.testing (#8305) 2019-11-07 11:20:35 -06:00
pretty-text DEV: Extend plugin API for uploads (#8440) 2019-12-09 16:20:03 +02:00
select-kit Revert "FIX: prevents focus of input on mobile (#6251)" 2019-12-12 11:17:40 -05:00
wizard DEV: Remove all instances of Ember.computed (#8324) 2019-11-08 12:28:11 -06:00
activate-account.js.no-module.es6
admin.js.erb
application.js REFACTOR: Remove InputValidation which was simply an Ember.Object 2019-11-11 15:48:56 -05:00
auto-redirect.js.no-module.es6
deprecated.js
discourse-loader.js FIX: Remove uneeded from discourse loader (#8390) 2019-11-21 11:46:27 -06:00
discourse-objects.js
discourse.js.es6 FIX: Failing tests 2019-11-13 15:34:30 -05:00
embed-application.js.no-module.es6 FEATURE: Embed topics list on remote sites via Javascript API. (#8008) 2019-08-15 13:41:06 -04:00
ember_include.js.erb
ember_jquery.js
ember-shim.js
env.js
google-tag-manager.js.no-module.es6
google-universal-analytics.js.no-module.es6
main_include_admin.js
markdown-it-bundle.js REFACTOR: Attach resize controls to images from the markdown pipeline (#8314) 2019-11-12 17:32:37 -03:00
onpopstate-handler.js.no-module.es6
polyfills.js FEATURE: Create IE Support Plugin (#8520) 2019-12-11 09:07:22 -05:00
preload-application-data.js.no-module.es6 REFACTOR: Remove Discourse.Session constants 2019-11-08 13:46:50 -05:00
preload-store.js.es6 FIX: More Promise uses that were not imported 2019-11-19 15:58:40 -05:00
pretty-text-bundle.js DEV: Remove pretty_text import hack & still work server-side (#8266) 2019-10-31 11:54:46 -05:00
print-page.js
service-worker.js.erb DEV: Bump uglifyjs (#7834) 2019-10-09 10:02:49 -03:00
set-prototype-polyfill.js
template_include.js.erb
vendor.js DEV: Remove HTML parser from Tautologistics. (#7344) 2019-04-10 11:21:22 +02:00
wizard-application.js DEV: Move computed to discourseComputed (#8312) 2019-11-07 15:38:28 -06:00
wizard-start.js.no-module.es6
wizard-vendor.js