mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 13:37:37 +08:00
2d567cee26
Prior to this commit we were loading a large number of thread messages without any pagination. This commit attempts to fix this and also improves the following points: - code sharing between channels and threads: Attempts to reuse/share the code use in channels for threads. To make it possible part of this code has been extracted in dedicated helpers or has been improved to reduce the duplication needed. Examples of extracted helpers: - `stackingContextFix`: the ios hack for rendering bug when momentum scrolling is interrupted - `scrollListToMessage`, `scrollListToTop`, `scrollListToBottom`: a series of helper to correctly scroll to a specific position in the list of messages - better general performance of listing messages: One of the main changes which has been made is to remove the computation of visible message during scroll, it will only happen when needed (update last read for example). This constant recomputation of `message.visible` on intersection observer event while scrolling was consuming a lot of CPU time.
48 lines
1.4 KiB
Ruby
48 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Chat message - thread", type: :system do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:chat_channel, threading_enabled: true) }
|
|
fab!(:thread_message_1) do
|
|
message_1 = Fabricate(:chat_message, chat_channel: channel_1)
|
|
Fabricate(:chat_message, chat_channel: channel_1, in_reply_to: message_1)
|
|
end
|
|
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:thread_page) { PageObjects::Pages::ChatThread.new }
|
|
|
|
before do
|
|
chat_system_bootstrap
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when hovering a message" do
|
|
it "adds an active class" do
|
|
chat_page.visit_thread(thread_message_1.thread)
|
|
|
|
thread_page.hover_message(thread_message_1)
|
|
|
|
expect(page).to have_css(
|
|
".chat-thread[data-id='#{thread_message_1.thread.id}'] [data-id='#{thread_message_1.id}'].chat-message-container.-active",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when copying link to a message" do
|
|
let(:cdp) { PageObjects::CDP.new }
|
|
|
|
before { cdp.allow_clipboard }
|
|
|
|
it "copies the link to the thread" do
|
|
chat_page.visit_thread(thread_message_1.thread)
|
|
|
|
thread_page.copy_link(thread_message_1)
|
|
|
|
expect(cdp.read_clipboard).to include(
|
|
"/chat/c/-/#{channel_1.id}/t/#{thread_message_1.thread.id}/#{thread_message_1.id}",
|
|
)
|
|
end
|
|
end
|
|
end
|