mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 02:23:40 +08:00
ba27ee1637
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression |
||
|---|---|---|
| .. | ||
| admin-badges | ||
| modals | ||
| admin-api-keys-index.js | ||
| admin-api-keys-new.js | ||
| admin-api-keys-show.js | ||
| admin-api-keys.js | ||
| admin-backups-index.js | ||
| admin-backups-logs.js | ||
| admin-backups.js | ||
| admin-badges.js | ||
| admin-customize-colors-show.js | ||
| admin-customize-colors.js | ||
| admin-customize-email-style-edit.js | ||
| admin-customize-email-templates-edit.js | ||
| admin-customize-email-templates.js | ||
| admin-customize-robots-txt.js | ||
| admin-customize-themes-edit.js | ||
| admin-customize-themes-show.js | ||
| admin-customize-themes.js | ||
| admin-dashboard-general.js | ||
| admin-dashboard-moderation.js | ||
| admin-dashboard-reports.js | ||
| admin-dashboard.js | ||
| admin-email-advanced-test.js | ||
| admin-email-bounced.js | ||
| admin-email-index.js | ||
| admin-email-logs.js | ||
| admin-email-preview-digest.js | ||
| admin-email-received.js | ||
| admin-email-rejected.js | ||
| admin-email-sent.js | ||
| admin-email-skipped.js | ||
| admin-embedding.js | ||
| admin-emojis.js | ||
| admin-logs-screened-emails.js | ||
| admin-logs-screened-ip-addresses.js | ||
| admin-logs-screened-urls.js | ||
| admin-logs-staff-action-logs.js | ||
| admin-permalinks.js | ||
| admin-plugins.js | ||
| admin-reports-show.js | ||
| admin-search-logs-index.js | ||
| admin-search-logs-term.js | ||
| admin-site-settings-category.js | ||
| admin-site-settings.js | ||
| admin-site-text-edit.js | ||
| admin-site-text-index.js | ||
| admin-user-badges.js | ||
| admin-user-fields.js | ||
| admin-user-index.js | ||
| admin-user.js | ||
| admin-users-list-show.js | ||
| admin-watched-words-action.js | ||
| admin-watched-words.js | ||
| admin-web-hooks-show-events.js | ||
| admin-web-hooks-show.js | ||
| admin-web-hooks.js | ||
| admin.js | ||