discourse/plugins/chat/spec/system/visit_channel_spec.rb
Roman Rizzi 5c699e4384
DEV: Pass messageId as a dynamic segment instead of a query param (#20013)
* DEV: Rnemae channel path to just c

Also swap the channel id and channel slug params to be consistent with core.

* linting

* channel_path

* Drop slugify helper and channel route without slug

* Request slug and route models through the channel model if possible

* DEV: Pass messageId as a dynamic segment instead of a query param

* Ensure change is backwards-compatible

* drop query param from oneboxes

* Correctly extract channelId from routes

* Better route organization using siblings for regular and near-message

* Ensures sessions are unique even when using parallelism

* prevents didReceiveAttrs to clear input mid test

* we disable animations in capybara so sometimes the message was barely showing

* adds wait

* ensures finished loading

* is it causing more harm than good?

* this check is slowing things for no reason

* actually target the button

* more resilient select chat message

* apply similar fix to bookmark

* fix

---------

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2023-02-01 12:39:23 -03:00

194 lines
5.8 KiB
Ruby
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# frozen_string_literal: true
RSpec.describe "Visit channel", type: :system, js: true do
fab!(:category) { Fabricate(:category) }
fab!(:topic) { Fabricate(:topic) }
fab!(:post) { Fabricate(:post, topic: topic) }
fab!(:current_user) { Fabricate(:user) }
fab!(:category_channel_1) { Fabricate(:category_channel) }
fab!(:private_category_channel_1) { Fabricate(:private_category_channel) }
fab!(:dm_channel_1) { Fabricate(:direct_message_channel, users: [current_user]) }
fab!(:inaccessible_dm_channel_1) { Fabricate(:direct_message_channel) }
let(:chat) { PageObjects::Pages::Chat.new }
before { chat_system_bootstrap }
context "when chat disabled" do
before do
SiteSetting.chat_enabled = false
sign_in(current_user)
end
it "shows a not found page" do
chat.visit_channel(category_channel_1)
expect(page).to have_content(I18n.t("page_not_found.title"))
end
end
context "when chat enabled" do
context "when anonymous" do
it "redirects to homepage" do
chat.visit_channel(category_channel_1)
expect(page).to have_current_path("/latest")
end
end
context "when regular user" do
before { sign_in(current_user) }
context "when chat is disabled" do
before { current_user.user_option.update!(chat_enabled: false) }
it "redirects to homepage" do
chat.visit_channel(category_channel_1)
expect(page).to have_current_path("/latest")
end
end
context "when current user is not allowed to chat" do
before { SiteSetting.chat_allowed_groups = Group::AUTO_GROUPS[:staff] }
it "redirects homepage" do
chat.visit_channel(category_channel_1)
expect(page).to have_current_path("/latest")
end
end
context "when channel is not found" do
it "shows an error" do
visit("/chat/c/-/999")
expect(page).to have_content("Not Found") # this is not a translated key
end
end
context "when loading a non existing message of a channel" do
it "shows an error" do
visit("/chat/c/-/#{category_channel_1.id}/-999")
expect(page).to have_content(I18n.t("not_found"))
end
end
context "when channel is not accessible" do
context "when category channel" do
it "shows an error" do
chat.visit_channel(private_category_channel_1)
expect(page).to have_content(I18n.t("invalid_access"))
end
end
context "when direct message channel" do
it "shows an error" do
chat.visit_channel(inaccessible_dm_channel_1)
expect(page).to have_content(I18n.t("invalid_access"))
end
end
end
context "when current user is not member of the channel" do
context "when category channel" do
fab!(:message_1) { Fabricate(:chat_message, chat_channel: category_channel_1) }
it "allows to join it" do
chat.visit_channel(category_channel_1)
expect(page).to have_content(I18n.t("js.chat.channel_settings.join_channel"))
end
it "shows a preview of the channel" do
chat.visit_channel(category_channel_1)
expect(page).to have_content(category_channel_1.name)
expect(chat).to have_message(message_1)
end
end
context "when direct message channel" do
fab!(:message_1) { Fabricate(:chat_message, chat_channel: dm_channel_1) }
before { dm_channel_1.membership_for(current_user).destroy! }
it "allows to join it" do
chat.visit_channel(dm_channel_1)
expect(page).to have_content(I18n.t("js.chat.channel_settings.join_channel"))
end
it "shows a preview of the channel" do
chat.visit_channel(dm_channel_1)
expect(chat).to have_message(message_1)
end
end
end
context "when current user is member of the channel" do
context "when category channel" do
fab!(:message_1) { Fabricate(:chat_message, chat_channel: category_channel_1) }
before { category_channel_1.add(current_user) }
it "doesnt ask to join it" do
chat.visit_channel(category_channel_1)
expect(page).to have_no_content(I18n.t("js.chat.channel_settings.join_channel"))
end
it "shows a preview of the channel" do
chat.visit_channel(category_channel_1)
expect(page).to have_content(category_channel_1.name)
expect(chat).to have_message(message_1)
end
context "when URL doesnt contain slug" do
it "redirects to correct URL" do
visit("/chat/c/-/#{category_channel_1.id}")
expect(page).to have_current_path(
"/chat/c/#{category_channel_1.slug}/#{category_channel_1.id}",
)
end
end
end
context "when direct message channel" do
fab!(:message_1) do
Fabricate(:chat_message, chat_channel: dm_channel_1, user: current_user)
end
it "doesnt ask to join it" do
chat.visit_channel(dm_channel_1)
expect(page).to have_no_content(I18n.t("js.chat.channel_settings.join_channel"))
end
it "shows a preview of the channel" do
chat.visit_channel(dm_channel_1)
expect(chat).to have_message(message_1)
end
context "when URL doesnt contain slug" do
it "redirects to correct URL" do
visit("/chat/c/-/#{dm_channel_1.id}")
expect(page).to have_current_path(
"/chat/c/#{Slug.for(dm_channel_1.title(current_user))}/#{dm_channel_1.id}",
)
end
end
end
end
end
end
end