discourse/app
Jeff Wong beaeb0c4b2
FIX: correctly remove authentication_data cookie on oauth login flow (#9238) (#9251)
Attempt 2, with more test.

Additionally correctly handle cookie path for authentication_data

There were two bugs that exposed an interesting case where two discourse
instances hosted across two subfolder installs in the same domain
with oauth may clash and cause strange redirection on first login:

Log in to example.com/forum1. authentication_data cookie is set with path /
On the first redirection, the current authentication_data cookie is not unset.
Log in to example.com/forum2. In this case, the authentication_data cookie
is already set from forum1 - the initial page load will incorrectly redirect
the user to the redirect URL from the already-stored cookie, to /forum1.

This removes this issue by:

Setting the cookie for the correct path, and not having it on root
Correctly removing the cookie on first login
2020-03-20 14:03:38 -07:00
..
assets Convert select-kit from es6 to js (#9246) 2020-03-20 12:40:32 -04:00
controllers FIX: correctly remove authentication_data cookie on oauth login flow (#9238) (#9251) 2020-03-20 14:03:38 -07:00
helpers FIX: blank popular posts in summary emails due to lightbox images 2020-02-21 16:18:38 -05:00
jobs FEATURE: automatically delete replies on a topic after N days. (#9209) 2020-03-19 21:06:31 +05:30
mailers FIX: Replace deprecated URI.encode, URI.escape, URI.unescape and URI.unencode (#8528) 2019-12-12 12:49:21 +10:00
models FIX: Moderators should be able to review flagged PMs since this has always been like this 2020-03-20 12:28:36 -03:00
serializers FIX: Remote themes Github link should go to custom branch #9184 2020-03-18 03:57:54 +05:30
services FIX: check for existence of post before creating notification 2020-03-16 14:11:36 +05:30
views FIX: correctly remove authentication_data cookie on oauth login flow (#9238) (#9251) 2020-03-20 14:03:38 -07:00