mirror of
https://github.com/discourse/discourse.git
synced 2025-02-24 21:17:40 +08:00
8f72a57363
Previously, were always forcing the page to reload for the wizard after pressing Next for the styling step, with the logic that if style changes are being made, the admin needs to see them straight away. However this doesn't make sense if nothing changes on that step. This commit makes the change to only refresh the page if any of the settings on the step changed, bringing it in line with other steps.
66 lines
1.4 KiB
Ruby
66 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Wizard
|
|
class StepUpdater
|
|
include ActiveModel::Model
|
|
|
|
attr_accessor :refresh_required, :fields
|
|
|
|
def initialize(current_user, step, fields)
|
|
@current_user = current_user
|
|
@step = step
|
|
@refresh_required = false
|
|
@fields = fields
|
|
@settings_changed = Set.new
|
|
end
|
|
|
|
def update
|
|
@step.updater.call(self) if @step.present? && @step.updater.present?
|
|
|
|
if success?
|
|
logger = StaffActionLogger.new(@current_user)
|
|
logger.log_wizard_step(@step)
|
|
end
|
|
end
|
|
|
|
def success?
|
|
@errors.blank?
|
|
end
|
|
|
|
def refresh_required?
|
|
@refresh_required
|
|
end
|
|
|
|
def setting_changed?(id)
|
|
@settings_changed.include?(id)
|
|
end
|
|
|
|
def update_setting(id, value)
|
|
value = value.strip if value.is_a?(String)
|
|
|
|
if !value.is_a?(Upload) && SiteSetting.type_supervisor.get_type(id) == :upload
|
|
value = Upload.get_from_url(value) || ""
|
|
end
|
|
|
|
if SiteSetting.get(id) != value
|
|
SiteSetting.set_and_log(id, value, @current_user)
|
|
@settings_changed << id
|
|
end
|
|
end
|
|
|
|
def apply_setting(id)
|
|
update_setting(id, @fields[id])
|
|
rescue Discourse::InvalidParameters => e
|
|
errors.add(id, e.message)
|
|
end
|
|
|
|
def ensure_changed(id)
|
|
errors.add(id, "") if @fields[id] == SiteSetting.defaults[id]
|
|
end
|
|
|
|
def apply_settings(*ids)
|
|
ids.each { |id| apply_setting(id) }
|
|
end
|
|
end
|
|
end
|