mirror of
https://github.com/discourse/discourse.git
synced 2024-12-12 06:13:44 +08:00
187b59d376
This commit implements all the necessary logic to create thread seamlessly. For this it relies on the same logic used for messages and generates a `staged-id`(using the format: `staged-thread-CHANNEL_ID-MESSAGE_ID` which is used to re-conciliate state client sides once the thread has been persisted on the backend. Part of this change the client side is now always using real thread and channel objects instead of sometimes relying on a flat `threadId` or `channelId`. This PR also brings three UX changes: - thread starts from top - number of buttons on message actions is dependent of the width of the enclosing container - <kbd>shift + ArrowUp</kbd> will reply to the last message
451 lines
15 KiB
Ruby
451 lines
15 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Chat
|
|
class ChatController < ::Chat::BaseController
|
|
PAST_MESSAGE_LIMIT = 40
|
|
FUTURE_MESSAGE_LIMIT = 40
|
|
PAST = "past"
|
|
FUTURE = "future"
|
|
CHAT_DIRECTIONS = [PAST, FUTURE]
|
|
|
|
# Other endpoints use set_channel_and_chatable_with_access_check, but
|
|
# these endpoints require a standalone find because they need to be
|
|
# able to get deleted channels and recover them.
|
|
before_action :find_chatable, only: %i[enable_chat disable_chat]
|
|
before_action :find_chat_message, only: %i[lookup_message edit_message rebake message_link]
|
|
before_action :set_channel_and_chatable_with_access_check,
|
|
except: %i[
|
|
respond
|
|
enable_chat
|
|
disable_chat
|
|
message_link
|
|
lookup_message
|
|
set_user_chat_status
|
|
dismiss_retention_reminder
|
|
flag
|
|
]
|
|
|
|
def respond
|
|
render
|
|
end
|
|
|
|
def enable_chat
|
|
chat_channel = Chat::Channel.with_deleted.find_by(chatable_id: @chatable)
|
|
|
|
guardian.ensure_can_join_chat_channel!(chat_channel) if chat_channel
|
|
|
|
if chat_channel && chat_channel.trashed?
|
|
chat_channel.recover!
|
|
elsif chat_channel
|
|
return render_json_error I18n.t("chat.already_enabled")
|
|
else
|
|
chat_channel = @chatable.chat_channel
|
|
guardian.ensure_can_join_chat_channel!(chat_channel)
|
|
end
|
|
|
|
success = chat_channel.save
|
|
if success && chat_channel.chatable_has_custom_fields?
|
|
@chatable.custom_fields[Chat::HAS_CHAT_ENABLED] = true
|
|
@chatable.save!
|
|
end
|
|
|
|
if success
|
|
membership = Chat::ChannelMembershipManager.new(channel).follow(user)
|
|
render_serialized(chat_channel, Chat::ChannelSerializer, membership: membership)
|
|
else
|
|
render_json_error(chat_channel)
|
|
end
|
|
|
|
Chat::ChannelMembershipManager.new(channel).follow(user)
|
|
end
|
|
|
|
def disable_chat
|
|
chat_channel = Chat::Channel.with_deleted.find_by(chatable_id: @chatable)
|
|
guardian.ensure_can_join_chat_channel!(chat_channel)
|
|
return render json: success_json if chat_channel.trashed?
|
|
chat_channel.trash!(current_user)
|
|
|
|
success = chat_channel.save
|
|
if success
|
|
if chat_channel.chatable_has_custom_fields?
|
|
@chatable.custom_fields.delete(Chat::HAS_CHAT_ENABLED)
|
|
@chatable.save!
|
|
end
|
|
|
|
render json: success_json
|
|
else
|
|
render_json_error(chat_channel)
|
|
end
|
|
end
|
|
|
|
def create_message
|
|
raise Discourse::InvalidAccess if current_user.silenced?
|
|
|
|
Chat::MessageRateLimiter.run!(current_user)
|
|
|
|
@user_chat_channel_membership =
|
|
Chat::ChannelMembershipManager.new(@chat_channel).find_for_user(
|
|
current_user,
|
|
following: true,
|
|
)
|
|
raise Discourse::InvalidAccess unless @user_chat_channel_membership
|
|
|
|
reply_to_msg_id = params[:in_reply_to_id]
|
|
if reply_to_msg_id
|
|
rm = Chat::Message.find(reply_to_msg_id)
|
|
raise Discourse::NotFound if rm.chat_channel_id != @chat_channel.id
|
|
end
|
|
|
|
content = params[:message]
|
|
|
|
chat_message_creator =
|
|
Chat::MessageCreator.create(
|
|
chat_channel: @chat_channel,
|
|
user: current_user,
|
|
in_reply_to_id: reply_to_msg_id,
|
|
content: content,
|
|
staged_id: params[:staged_id],
|
|
upload_ids: params[:upload_ids],
|
|
thread_id: params[:thread_id],
|
|
staged_thread_id: params[:staged_thread_id],
|
|
)
|
|
|
|
return render_json_error(chat_message_creator.error) if chat_message_creator.failed?
|
|
|
|
if !chat_message_creator.chat_message.thread_id.present?
|
|
@user_chat_channel_membership.update!(
|
|
last_read_message_id: chat_message_creator.chat_message.id,
|
|
)
|
|
end
|
|
|
|
if @chat_channel.direct_message_channel?
|
|
# If any of the channel users is ignoring, muting, or preventing DMs from
|
|
# the current user then we shold not auto-follow the channel once again or
|
|
# publish the new channel.
|
|
user_ids_allowing_communication =
|
|
UserCommScreener.new(
|
|
acting_user: current_user,
|
|
target_user_ids: @chat_channel.user_chat_channel_memberships.pluck(:user_id),
|
|
).allowing_actor_communication
|
|
|
|
if user_ids_allowing_communication.any?
|
|
Chat::Publisher.publish_new_channel(
|
|
@chat_channel,
|
|
@chat_channel.chatable.users.where(id: user_ids_allowing_communication),
|
|
)
|
|
|
|
@chat_channel
|
|
.user_chat_channel_memberships
|
|
.where(user_id: user_ids_allowing_communication)
|
|
.update_all(following: true)
|
|
end
|
|
end
|
|
|
|
Chat::Publisher.publish_user_tracking_state(
|
|
current_user,
|
|
@chat_channel.id,
|
|
(
|
|
if chat_message_creator.chat_message.thread_id.present?
|
|
@user_chat_channel_membership.last_read_message_id
|
|
else
|
|
chat_message_creator.chat_message.id
|
|
end
|
|
),
|
|
)
|
|
render json: success_json
|
|
end
|
|
|
|
def edit_message
|
|
chat_message_updater =
|
|
Chat::MessageUpdater.update(
|
|
guardian: guardian,
|
|
chat_message: @message,
|
|
new_content: params[:new_message],
|
|
upload_ids: params[:upload_ids] || [],
|
|
)
|
|
|
|
return render_json_error(chat_message_updater.error) if chat_message_updater.failed?
|
|
|
|
render json: success_json
|
|
end
|
|
|
|
def messages
|
|
page_size = params[:page_size]&.to_i || 1000
|
|
direction = params[:direction].to_s
|
|
message_id = params[:message_id]
|
|
if page_size > 50 ||
|
|
(
|
|
message_id.blank? ^ direction.blank? &&
|
|
(direction.present? && !CHAT_DIRECTIONS.include?(direction))
|
|
)
|
|
raise Discourse::InvalidParameters
|
|
end
|
|
|
|
messages = preloaded_chat_message_query.where(chat_channel: @chat_channel)
|
|
messages = messages.with_deleted if guardian.can_moderate_chat?(@chatable)
|
|
messages = messages.where(thread_id: params[:thread_id]) if params[:thread_id]
|
|
messages = exclude_thread_messages(messages) if !include_thread_messages?
|
|
|
|
if message_id.present?
|
|
condition = direction == PAST ? "<" : ">"
|
|
messages = messages.where("id #{condition} ?", message_id.to_i)
|
|
end
|
|
|
|
# NOTE: This order is reversed when we return the Chat::View below if the direction
|
|
# is not FUTURE.
|
|
order = direction == FUTURE ? "ASC" : "DESC"
|
|
messages = messages.order("created_at #{order}, id #{order}").limit(page_size).to_a
|
|
|
|
can_load_more_past = nil
|
|
can_load_more_future = nil
|
|
|
|
if direction == FUTURE
|
|
can_load_more_future = messages.size == page_size
|
|
elsif direction == PAST
|
|
can_load_more_past = messages.size == page_size
|
|
else
|
|
# When direction is blank, we'll return the latest messages.
|
|
can_load_more_future = false
|
|
can_load_more_past = messages.size == page_size
|
|
end
|
|
|
|
chat_view =
|
|
Chat::View.new(
|
|
chat_channel: @chat_channel,
|
|
chat_messages: direction == FUTURE ? messages : messages.reverse,
|
|
user: current_user,
|
|
can_load_more_past: can_load_more_past,
|
|
can_load_more_future: can_load_more_future,
|
|
)
|
|
render_serialized(chat_view, Chat::ViewSerializer, root: false)
|
|
end
|
|
|
|
def react
|
|
params.require(%i[message_id emoji react_action])
|
|
guardian.ensure_can_react!
|
|
|
|
Chat::MessageReactor.new(current_user, @chat_channel).react!(
|
|
message_id: params[:message_id],
|
|
react_action: params[:react_action].to_sym,
|
|
emoji: params[:emoji],
|
|
)
|
|
|
|
render json: success_json
|
|
end
|
|
|
|
def rebake
|
|
guardian.ensure_can_rebake_chat_message!(@message)
|
|
@message.rebake!(invalidate_oneboxes: true)
|
|
render json: success_json
|
|
end
|
|
|
|
def message_link
|
|
raise Discourse::NotFound if @message.blank? || @message.deleted_at.present?
|
|
raise Discourse::NotFound if @message.chat_channel.blank?
|
|
set_channel_and_chatable_with_access_check(chat_channel_id: @message.chat_channel_id)
|
|
render json:
|
|
success_json.merge(
|
|
chat_channel_id: @chat_channel.id,
|
|
chat_channel_title: @chat_channel.title(current_user),
|
|
)
|
|
end
|
|
|
|
def lookup_message
|
|
set_channel_and_chatable_with_access_check(chat_channel_id: @message.chat_channel_id)
|
|
|
|
messages = preloaded_chat_message_query.where(chat_channel: @chat_channel)
|
|
messages = messages.with_deleted if guardian.can_moderate_chat?(@chatable)
|
|
messages = messages.where(thread_id: params[:thread_id]) if params[:thread_id]
|
|
messages = exclude_thread_messages(messages) if !include_thread_messages?
|
|
|
|
past_messages =
|
|
messages
|
|
.where("created_at < ?", @message.created_at)
|
|
.order(created_at: :desc)
|
|
.limit(PAST_MESSAGE_LIMIT)
|
|
|
|
future_messages =
|
|
messages
|
|
.where("created_at > ?", @message.created_at)
|
|
.order(created_at: :asc)
|
|
.limit(FUTURE_MESSAGE_LIMIT)
|
|
|
|
can_load_more_past = past_messages.count == PAST_MESSAGE_LIMIT
|
|
can_load_more_future = future_messages.count == FUTURE_MESSAGE_LIMIT
|
|
looked_up_message = !include_thread_messages? && @message.thread_reply? ? [] : [@message]
|
|
messages = [past_messages.reverse, looked_up_message, future_messages].reduce([], :concat)
|
|
chat_view =
|
|
Chat::View.new(
|
|
chat_channel: @chat_channel,
|
|
chat_messages: messages,
|
|
user: current_user,
|
|
can_load_more_past: can_load_more_past,
|
|
can_load_more_future: can_load_more_future,
|
|
)
|
|
render_serialized(chat_view, Chat::ViewSerializer, root: false)
|
|
end
|
|
|
|
def set_user_chat_status
|
|
params.require(:chat_enabled)
|
|
|
|
current_user.user_option.update(chat_enabled: params[:chat_enabled])
|
|
render json: { chat_enabled: current_user.user_option.chat_enabled }
|
|
end
|
|
|
|
def invite_users
|
|
params.require(:user_ids)
|
|
|
|
users =
|
|
User
|
|
.includes(:groups)
|
|
.joins(:user_option)
|
|
.where(user_options: { chat_enabled: true })
|
|
.not_suspended
|
|
.where(id: params[:user_ids])
|
|
users.each do |user|
|
|
guardian = Guardian.new(user)
|
|
if guardian.can_chat? && guardian.can_join_chat_channel?(@chat_channel)
|
|
data = {
|
|
message: "chat.invitation_notification",
|
|
chat_channel_id: @chat_channel.id,
|
|
chat_channel_title: @chat_channel.title(user),
|
|
chat_channel_slug: @chat_channel.slug,
|
|
invited_by_username: current_user.username,
|
|
}
|
|
data[:chat_message_id] = params[:chat_message_id] if params[:chat_message_id]
|
|
user.notifications.create(
|
|
notification_type: Notification.types[:chat_invitation],
|
|
high_priority: true,
|
|
data: data.to_json,
|
|
)
|
|
end
|
|
end
|
|
|
|
render json: success_json
|
|
end
|
|
|
|
def dismiss_retention_reminder
|
|
params.require(:chatable_type)
|
|
guardian.ensure_can_chat!
|
|
unless Chat::Channel.chatable_types.include?(params[:chatable_type])
|
|
raise Discourse::InvalidParameters
|
|
end
|
|
|
|
field =
|
|
(
|
|
if Chat::Channel.public_channel_chatable_types.include?(params[:chatable_type])
|
|
:dismissed_channel_retention_reminder
|
|
else
|
|
:dismissed_dm_retention_reminder
|
|
end
|
|
)
|
|
current_user.user_option.update(field => true)
|
|
render json: success_json
|
|
end
|
|
|
|
def quote_messages
|
|
params.require(:message_ids)
|
|
|
|
message_ids = params[:message_ids].map(&:to_i)
|
|
markdown =
|
|
Chat::TranscriptService.new(
|
|
@chat_channel,
|
|
current_user,
|
|
messages_or_ids: message_ids,
|
|
).generate_markdown
|
|
render json: success_json.merge(markdown: markdown)
|
|
end
|
|
|
|
def flag
|
|
RateLimiter.new(current_user, "flag_chat_message", 4, 1.minutes).performed!
|
|
|
|
permitted_params =
|
|
params.permit(
|
|
%i[chat_message_id flag_type_id message is_warning take_action queue_for_review],
|
|
)
|
|
|
|
chat_message =
|
|
Chat::Message.includes(:chat_channel, :revisions).find(permitted_params[:chat_message_id])
|
|
|
|
flag_type_id = permitted_params[:flag_type_id].to_i
|
|
|
|
if !ReviewableScore.types.values.include?(flag_type_id)
|
|
raise Discourse::InvalidParameters.new(:flag_type_id)
|
|
end
|
|
|
|
set_channel_and_chatable_with_access_check(chat_channel_id: chat_message.chat_channel_id)
|
|
|
|
result =
|
|
Chat::ReviewQueue.new.flag_message(chat_message, guardian, flag_type_id, permitted_params)
|
|
|
|
if result[:success]
|
|
render json: success_json
|
|
else
|
|
render_json_error(result[:errors])
|
|
end
|
|
end
|
|
|
|
def set_draft
|
|
if params[:data].present?
|
|
Chat::Draft.find_or_initialize_by(
|
|
user: current_user,
|
|
chat_channel_id: @chat_channel.id,
|
|
).update!(data: params[:data])
|
|
else
|
|
Chat::Draft.where(user: current_user, chat_channel_id: @chat_channel.id).destroy_all
|
|
end
|
|
|
|
render json: success_json
|
|
end
|
|
|
|
private
|
|
|
|
def preloaded_chat_message_query
|
|
query =
|
|
Chat::Message
|
|
.includes(in_reply_to: [:user, chat_webhook_event: [:incoming_chat_webhook]])
|
|
.includes(:revisions)
|
|
.includes(user: :primary_group)
|
|
.includes(chat_webhook_event: :incoming_chat_webhook)
|
|
.includes(reactions: :user)
|
|
.includes(:bookmarks)
|
|
.includes(:uploads)
|
|
.includes(chat_channel: :chatable)
|
|
.includes(:thread)
|
|
|
|
query = query.includes(user: :user_status) if SiteSetting.enable_user_status
|
|
|
|
query
|
|
end
|
|
|
|
def include_thread_messages?
|
|
params[:thread_id].present? || !SiteSetting.enable_experimental_chat_threaded_discussions ||
|
|
!@chat_channel.threading_enabled
|
|
end
|
|
|
|
def find_chatable
|
|
@chatable = Category.find_by(id: params[:chatable_id])
|
|
guardian.ensure_can_moderate_chat!(@chatable)
|
|
end
|
|
|
|
def find_chat_message
|
|
@message = preloaded_chat_message_query.with_deleted
|
|
@message = @message.where(chat_channel_id: params[:chat_channel_id]) if params[
|
|
:chat_channel_id
|
|
]
|
|
@message = @message.find_by(id: params[:message_id])
|
|
raise Discourse::NotFound unless @message
|
|
end
|
|
|
|
def exclude_thread_messages(messages)
|
|
messages.where(<<~SQL, channel_id: @chat_channel.id)
|
|
chat_messages.thread_id IS NULL OR chat_messages.id IN (
|
|
SELECT original_message_id
|
|
FROM chat_threads
|
|
WHERE chat_threads.channel_id = :channel_id
|
|
)
|
|
SQL
|
|
end
|
|
end
|
|
end
|