mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 06:43:45 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
66 lines
1.5 KiB
Ruby
66 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Admin::ReportsController do
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::ReportsController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
context 'while logged in as an admin' do
|
|
let!(:admin) { log_in(:admin) }
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
|
|
context '.show' do
|
|
|
|
context "invalid id form" do
|
|
let(:invalid_id) { "!!&asdfasdf" }
|
|
|
|
it "never calls Report.find" do
|
|
Report.expects(:find).never
|
|
xhr :get, :show, type: invalid_id
|
|
end
|
|
|
|
it "returns 404" do
|
|
xhr :get, :show, type: invalid_id
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
|
|
context "valid type form" do
|
|
|
|
context 'missing report' do
|
|
before do
|
|
Report.expects(:find).with('active', instance_of(Hash)).returns(nil)
|
|
xhr :get, :show, type: 'active'
|
|
end
|
|
|
|
it "renders the report as JSON" do
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
|
|
context 'a report is found' do
|
|
before do
|
|
Report.expects(:find).with('active', instance_of(Hash)).returns(Report.new('active'))
|
|
xhr :get, :show, type: 'active'
|
|
end
|
|
|
|
it "renders the report as JSON" do
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it "renders the report as JSON" do
|
|
expect(::JSON.parse(response.body)).to be_present
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|