mirror of
https://github.com/discourse/discourse.git
synced 2024-12-11 22:34:04 +08:00
14b436923c
### UI changes
All of the UI changes described are gated behind the `use_legacy_pageviews`
site setting.
This commit changes the admin dashboard pageviews report to
use the "Consolidated Pageviews with Browser Detection" report
introduced in 2f2da72747 with
the following changes:
* The report name is changed to "Site traffic"
* The pageview count on the dashboard is counting only using the new method
* The old "Consolidated Pageviews" report is renamed as "Consolidated Legacy Pageviews"
* By default "known crawlers" and "other" sources of pageviews are hidden on the report
When `use_legacy_pageviews` is `true`, we do not show or allow running
the "Site traffic" report for admins. When `use_legacy_pageviews` is `false`,
we do not show or allow running the following legacy reports:
* consolidated_page_views
* consolidated_page_views_browser_detection
* page_view_anon_reqs
* page_view_logged_in_reqs
### Historical data changes
Also part of this change is that, since we introduced our new "Consolidated
Pageviews with Browser Detection" report, some admins are confused at either:
* The lack of data before a certain date , which didn’t exist before
we started collecting it
* Comparing this and the current "Consolidated Pageviews" report data,
which rolls up "Other Pageviews" into "Anonymous Browser" and so it
appears inaccurate
All pageview data in the new report before the date where the _first_
anon or logged in browser pageview was recorded is now hidden.
34 lines
921 B
Ruby
34 lines
921 B
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Admin Dashboard Community Health", type: :system do
|
|
fab!(:current_user) { Fabricate(:admin) }
|
|
|
|
before { sign_in(current_user) }
|
|
|
|
describe "Pageview Report" do
|
|
context "when use_legacy_pageviews is true" do
|
|
before { SiteSetting.use_legacy_pageviews = true }
|
|
|
|
it "shows the 'Consolidated Pageviews' report" do
|
|
visit("/admin")
|
|
expect(page).to have_css(
|
|
".admin-report.consolidated-page-views",
|
|
text: I18n.t("reports.consolidated_page_views.title"),
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when use_legacy_pageviews is false" do
|
|
before { SiteSetting.use_legacy_pageviews = false }
|
|
|
|
it "shows the 'Site Traffic' report" do
|
|
visit("/admin")
|
|
expect(page).to have_css(
|
|
".admin-report.site-traffic",
|
|
text: I18n.t("reports.site_traffic.title"),
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|