mirror of
https://github.com/discourse/discourse.git
synced 2024-12-18 09:54:17 +08:00
c07f1e442f
This commit fixes the UpdateUserLastRead spec which was checking for a message ID that did not exist -- this could fail at times since message ID 2 could exist. Better to create + destroy a message since then it's guaranteed we have a unique ID. This also attempts to clarify a step that we expect to fail which succeeds instead by adding another emoji next to the success tick and an explanation text. Also removes some uses of unless in Services::Base, we generally prefer to use alternatives, since unless can be hard to parse in a lot of cases. Co-authored-by: Loïc Guitaut <loic@discourse.org> |
||
|---|---|---|
| .. | ||
| chat_channel_archive_service_spec.rb | ||
| chat_channel_fetcher_spec.rb | ||
| chat_channel_hashtag_data_source_spec.rb | ||
| chat_channel_membership_manager_spec.rb | ||
| chat_message_bookmarkable_spec.rb | ||
| chat_message_processor_spec.rb | ||
| chat_message_reactor_spec.rb | ||
| chat_notifier_spec.rb | ||
| chat_review_queue_spec.rb | ||
| chat_statistics_spec.rb | ||
| chat_transcript_service_spec.rb | ||
| direct_message_channel_creator_spec.rb | ||
| duplicate_message_validator_spec.rb | ||
| endpoint_spec.rb | ||
| guardian_extensions_spec.rb | ||
| message_mover_spec.rb | ||
| post_notification_handler_spec.rb | ||
| slack_compatibility_spec.rb | ||
| steps_inspector_spec.rb | ||