discourse/plugins/chat/app/services
Martin Brennan c07f1e442f
DEV: Fix failing chat spec and add unexpected failure indicator (#20299)
This commit fixes the UpdateUserLastRead spec which was checking
for a message ID that did not exist -- this could fail at times
since message ID 2 could exist. Better to create + destroy a message
since then it's guaranteed we have a unique ID.

This also attempts to clarify a step that we expect to fail which
succeeds instead by adding another emoji next to the success tick and
an explanation text.

Also removes some uses of unless in Services::Base, we generally prefer
to use alternatives, since unless can be hard to parse in a lot of
cases.

Co-authored-by: Loïc Guitaut <loic@discourse.org>
2023-02-15 19:16:13 +01:00
..
base.rb DEV: Fix failing chat spec and add unexpected failure indicator (#20299) 2023-02-15 19:16:13 +01:00
chat_message_destroyer.rb DEV: Add 'chat_message_trashed' Discourse event (#20170) 2023-02-06 21:52:43 +01:00
chat_publisher.rb FEATURE: Chat side panel with threads initial skeleton (#20209) 2023-02-14 11:38:41 +10:00
trash_channel.rb DEV: Chat service object initial implementation (#19814) 2023-02-13 13:09:57 +01:00
update_channel_status.rb DEV: Chat service object initial implementation (#19814) 2023-02-13 13:09:57 +01:00
update_channel.rb DEV: Chat service object initial implementation (#19814) 2023-02-13 13:09:57 +01:00
update_user_last_read.rb DEV: Refactor UpdateUserLastRead a little 2023-02-13 17:03:41 +01:00