mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 15:04:59 +08:00
03818e642a
This introduces new APIs for obtaining optimized thumbnails for topics. There are a few building blocks required for this:
- Introduces new `image_upload_id` columns on the `posts` and `topics` table. This replaces the old `image_url` column, which means that thumbnails are now restricted to uploads. Hotlinked thumbnails are no longer possible. In normal use (with pull_hotlinked_images enabled), this has no noticeable impact
- A migration attempts to match existing urls to upload records. If a match cannot be found then the posts will be queued for rebake
- Optimized thumbnails are generated during post_process_cooked. If thumbnails are missing when serializing a topic list, then a sidekiq job is queued
- Topic lists and topics now include a `thumbnails` key, which includes all the available images:
```
"thumbnails": [
{
"max_width": null,
"max_height": null,
"url": "//example.com/original-image.png",
"width": 1380,
"height": 1840
},
{
"max_width": 1024,
"max_height": 1024,
"url": "//example.com/optimized-image.png",
"width": 768,
"height": 1024
}
]
```
- Themes can request additional thumbnail sizes by using a modifier in their `about.json` file:
```
"modifiers": {
"topic_thumbnail_sizes": [
[200, 200],
[800, 800]
],
...
```
Remember that these are generated asynchronously, so your theme should include logic to fallback to other available thumbnails if your requested size has not yet been generated
- Two new raw plugin outlets are introduced, to improve the customisability of the topic list. `topic-list-before-columns` and `topic-list-before-link`
61 lines
1.1 KiB
Ruby
61 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe WebHookTopicViewSerializer do
|
|
fab!(:admin) { Fabricate(:admin) }
|
|
fab!(:topic) { Fabricate(:topic) }
|
|
|
|
let(:serializer) do
|
|
WebHookTopicViewSerializer.new(TopicView.new(topic),
|
|
scope: Guardian.new(admin),
|
|
root: false
|
|
)
|
|
end
|
|
|
|
before do
|
|
SiteSetting.tagging_enabled = true
|
|
end
|
|
|
|
it 'should only include the keys that are sent out in the webhook' do
|
|
expected_keys = %i{
|
|
id
|
|
title
|
|
fancy_title
|
|
posts_count
|
|
created_at
|
|
views
|
|
reply_count
|
|
like_count
|
|
last_posted_at
|
|
visible
|
|
closed
|
|
archived
|
|
archetype
|
|
slug
|
|
category_id
|
|
word_count
|
|
deleted_at
|
|
user_id
|
|
featured_link
|
|
pinned_globally
|
|
pinned_at
|
|
pinned_until
|
|
unpinned
|
|
pinned
|
|
highest_post_number
|
|
deleted_by
|
|
bookmarked
|
|
participant_count
|
|
created_by
|
|
last_poster
|
|
tags
|
|
thumbnails
|
|
}
|
|
|
|
keys = serializer.as_json.keys
|
|
|
|
expect(serializer.as_json.keys).to contain_exactly(*expected_keys)
|
|
end
|
|
end
|