mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 06:13:45 +08:00
c1f74cd92a
This commit should be a no-op for all existing core outlets. Outlets which are introduced by themes/plugins may see a change in behavior, and should follow the steps below if they want to maintain their previous behavior.
`tagName="" connectorTagName=""` is almost always the correct choice for plugin outlets. 40eba8cd introduced a `noTags=true` shortcut which achieved this, and left a comment saying it should be the future default. This commit does exactly that. To avoid any breaking changes for plugins, all existing plugin outlets have been reviewed and adjusted by following this logic:
1) If `noTags=true`, remove the `noTags` parameter, and do not complete any further steps
2) If `tagName` is not specified, set `tagName="span"` (the previous default)
3) If `connectorTagName` is not specified, set `selectorTagName="div"` (the previous default)
4) If `tagName=""`, remove it
5) If `connectorTagName=""`, remove it
The updates were accomplished with the help of a ruby script:
```ruby
def removeAttr(tag, attribute)
tag = tag.sub /\s#{attribute}="?\w*"? /, " "
tag = tag.sub /\s#{attribute}="?\w*"?}}/, "}}"
tag = tag.sub /^\s*#{attribute}="?\w*"?\n/, ""
tag
end
files = Dir.glob("app/assets/javascripts/**/*.hbs")
puts "Checking #{files.count} files..."
files.each do |f|
content = File.read(f)
count = 0
edits = 0
content.gsub!(/{{\s*plugin-outlet.*?}}/m) do |match|
count += 1
result = match
noTags = result.include?("noTags=true")
tagName = result[/tagName="(\w*)"/, 1]
connectorTagName = result[/connectorTagName="(\w*)"/, 1]
if noTags
result = removeAttr(result, "noTags")
else
if connectorTagName == ""
result = removeAttr(result, "connectorTagName")
elsif connectorTagName.nil?
result = result.sub(/name="[\w-]+"/) { |m| "#{m} connectorTagName=\"div\"" }
end
if tagName == ""
result = removeAttr(result, "tagName")
elsif tagName.nil?
result = result.sub(/name="[\w-]+"/) { |m| "#{m} tagName=\"span\"" }
end
end
edits += 1 if match != result
result
end
puts "#{count} outlets, #{edits} edited -> #{f}"
File.write(f, content)
end
```
57 lines
1.5 KiB
Handlebars
57 lines
1.5 KiB
Handlebars
{{plugin-outlet name="admin-dashboard-top" tagName="span" connectorTagName="div"}}
|
|
|
|
{{#if showVersionChecks}}
|
|
<div class="section-top">
|
|
<div class="version-checks">
|
|
{{version-checks versionCheck=versionCheck tagName=""}}
|
|
</div>
|
|
</div>
|
|
{{/if}}
|
|
|
|
{{dashboard-problems
|
|
loadingProblems=loadingProblems
|
|
foundProblems=foundProblems
|
|
lowPriorityProblems=lowPriorityProblems
|
|
highPriorityProblems=highPriorityProblems
|
|
problemsTimestamp=problemsTimestamp
|
|
refreshProblems=(action "refreshProblems")
|
|
}}
|
|
|
|
<ul class="navigation">
|
|
<li class="navigation-item general">
|
|
{{#link-to "admin.dashboard.general" class="navigation-link"}}
|
|
{{i18n "admin.dashboard.general_tab"}}
|
|
{{/link-to}}
|
|
</li>
|
|
|
|
{{#if isModerationTabVisible}}
|
|
<li class="navigation-item moderation">
|
|
{{#link-to "admin.dashboardModeration" class="navigation-link"}}
|
|
{{i18n "admin.dashboard.moderation_tab"}}
|
|
{{/link-to}}
|
|
</li>
|
|
{{/if}}
|
|
|
|
{{#if isSecurityTabVisible}}
|
|
<li class="navigation-item security">
|
|
{{#link-to "admin.dashboardSecurity" class="navigation-link"}}
|
|
{{i18n "admin.dashboard.security_tab"}}
|
|
{{/link-to}}
|
|
</li>
|
|
{{/if}}
|
|
|
|
{{#if isReportsTabVisible}}
|
|
<li class="navigation-item reports">
|
|
{{#link-to "admin.dashboardReports" class="navigation-link"}}
|
|
{{i18n "admin.dashboard.reports_tab"}}
|
|
{{/link-to}}
|
|
</li>
|
|
{{/if}}
|
|
</ul>
|
|
|
|
{{outlet}}
|
|
|
|
{{dashboard-new-features tagName="div"}}
|
|
|
|
{{plugin-outlet name="admin-dashboard-bottom" tagName="span" connectorTagName="div"}}
|