Sam Saffron c5e67726fd FIX: under some conditions draft would say it was saving when not ...

This is a major change to draft internals. Previously there were quite a
few cases where the draft system would say "draft saved", when in fact
we just skipped saving.

This commit ensures the draft system deals with draft ownership handover in
a predictable way.

For example:

- Window 1 editing draft
- Window 2 editing same draft at the same time

Previously we would allow window 1 and 2 to just fight on the same draft
each window overwriting the same draft over an over.

This commit introduces an ownership concept where either window 1 or 2 win
and user is prompted on the loser window to reload screen to correct the issue

This also corrects edge cases where a user could have multiple browser windows
open and posts in 1 window, later to post in the second window. Previously
drafts would break in the second window, this corrects it.

2019-10-31 17:15:58 +11:00

..

about_spec.rb

PERF: speed up about page render time and limit category mods (#8112)

2019-10-03 21:48:56 +03:00

admin_dashboard_problem_spec.rb

DEV: introduce new API to look up dynamic site setting

2019-05-07 11:00:30 +10:00

api_key_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

application_request_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

badge_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

badge_type_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

category_featured_topic_spec.rb

DEV: Fix heisentest.

2019-07-16 14:41:03 +03:00

category_group_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

category_list_spec.rb

DEV: Default to skipping creating a topic when fabricating categories (#7976)

2019-08-06 11:26:54 +01:00

category_spec.rb

DEV: update the comments re the encoded slug changes

2019-10-21 13:39:45 -04:00

category_user_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

child_theme_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

color_scheme_color_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

color_scheme_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

developer_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

digest_email_site_setting_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

directory_item_spec.rb

DEV: improve flaky spec

2019-10-04 11:11:03 +10:00

discourse_single_sign_on_spec.rb

FEATURE: ban any SSO attempts with invalid external id

2019-06-11 10:04:26 +10:00

draft_sequence_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

draft_spec.rb

FIX: under some conditions draft would say it was saving when not

2019-10-31 17:15:58 +11:00

email_change_request_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

email_log_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

email_token_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

embeddable_host_spec.rb

SECURITY: Don't allow base_uri as embeddable host if none exist

2019-09-29 20:51:59 -04:00

emoji_spec.rb

FIX: allows replacement of digits and symbols emojis (#7978)

2019-08-07 11:38:58 +02:00

given_daily_like_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

global_setting_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

group_history_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

group_spec.rb

DEV: adds event hook when add/remove user to group (#8038)

2019-09-10 11:58:08 -05:00

group_user_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

incoming_link_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

incoming_links_report_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

invite_redeemer_spec.rb

FEATURE: send max 200 emails every minute for bulk invites (#7875)

2019-07-19 11:29:12 +05:30

invite_spec.rb

FEATURE: send max 200 emails every minute for bulk invites (#7875)

2019-07-19 11:29:12 +05:30

javascript_cache_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

locale_site_setting_spec.rb

DEV: clean up potential locale leak

2019-06-03 12:42:29 +10:00

mailing_list_mode_site_setting_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

notification_spec.rb

DEV: Add test.

2019-10-21 21:33:58 +03:00

optimized_image_spec.rb

DEV: Remove use of fake external store in optimized images spec.

2019-05-29 20:13:23 +08:00

permalink_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

plugin_store_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

post_action_spec.rb

DEV: pluck_first

2019-10-21 12:08:20 +01:00

post_action_type_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

post_analyzer_spec.rb

FIX: Improve Onebox detection (#8019)

2019-09-10 13:59:48 +03:00

post_detail_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

post_mover_spec.rb

FIX: Move notification level only when user posted

2019-10-14 15:06:09 +02:00

post_reply_key_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

post_reply_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

post_spec.rb

fix the incorrect specs

2019-10-14 12:49:11 +05:30

post_timing_spec.rb

FIX: Decrement posts read count when destroying post timings (#8172)

2019-10-08 15:39:23 -03:00

post_upload_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

quoted_post_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

remote_theme_spec.rb

FEATURE: Allow themes to override color transformation variables (#7987)

2019-08-12 11:02:38 +01:00

report_spec.rb

DEV: Default to skipping creating a topic when fabricating categories (#7976)

2019-08-06 11:26:54 +01:00

reviewable_claimed_topic_spec.rb

Make rubocop happy.

2019-05-13 09:55:44 +08:00

reviewable_flagged_post_spec.rb

Spec should not depend on aliases

2019-10-01 18:33:53 -03:00

reviewable_history_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

reviewable_queued_post_spec.rb

DEV: Allow specifying button class in reviewable action definitions (#8093)

2019-09-18 11:28:59 +01:00

reviewable_score_spec.rb

FIX: Accurate sub_total calculation for reviewable_scores (#8184)

2019-10-11 11:07:19 -05:00

reviewable_spec.rb

FIX: Sensitivity did not work by default

2019-09-19 13:26:17 -04:00

reviewable_user_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

s3_region_site_setting_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

screened_email_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

screened_ip_address_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

screened_url_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

search_log_spec.rb

Time variable used to be created with users timezone, it has to be UTC in order to pass the test

2019-05-07 08:43:38 -04:00

site_setting_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

site_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

skipped_email_log_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

stylesheet_cache_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

tag_group_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

tag_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

tag_user_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

theme_field_spec.rb

FIX: Load raw hbs templates correctly from theme javascripts folder

2019-09-13 18:01:16 +01:00

theme_spec.rb

FIX: Ensure live-reloading of theme CSS works first time (#8052)

2019-08-29 15:47:08 +01:00

top_menu_item_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

top_topic_spec.rb

DEV: pluck_first

2019-10-21 12:08:20 +01:00

topic_allowed_user_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

topic_converter_spec.rb

FIX: Prevent from creation of duplicated TopicAllowedUsers (#8169)

2019-10-11 17:44:29 +11:00

topic_embed_spec.rb

FIX: embedding topics would fail with some HTML

2019-08-07 12:45:55 +10:00

topic_featured_users_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

topic_group_spec.rb

FEATURE: Publish read state on group messages. (Originally introduced in #7989) (#8025)

2019-08-27 09:09:00 -03:00

topic_invite_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

topic_link_click_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_link_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_list_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_participants_summary_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_posters_summary_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_spec.rb

FIX: Properly encoded slugs when configured to (#8158)

2019-10-11 12:38:16 -03:00

topic_tag_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_timer_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topic_tracking_state_spec.rb

DEV: correct flaky test testing message content

2019-10-04 09:56:28 +10:00

topic_user_spec.rb

FIX: properly set notification levels on group invite

2019-08-16 18:23:51 +10:00

topic_view_item_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

translation_override_spec.rb

FIX: Display site text overrides for non '_MF' keys (#8189)

2019-10-17 18:34:07 +02:00

trust_level3_requirements_spec.rb

FEATURE: Permit users who had no penalties in last 6 months to be TL3. (#7892)

2019-07-19 12:46:10 +03:00

unsubscribe_key_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

upload_spec.rb

FIX: Regularly reset unknown extension of uploads

2019-08-21 10:23:20 +02:00

user_action_spec.rb

Fix broken spec in 405ba00c08a86778a7baf28e93388201162a5347.

2019-05-08 15:45:25 +08:00

user_api_key_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_archived_message_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_auth_token_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

user_avatar_spec.rb

FIX: Gravatar uploads being dependent on authorized_extensions.

2019-08-01 16:24:09 +08:00

user_badge_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

user_email_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

user_export_spec.rb

REVERT: DEV: should ignore missing post uploads when a user export destroyed

2019-07-25 19:41:25 +05:30

user_field_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_history_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

user_open_id_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_option_spec.rb

DEV: Upgrading Discourse to Zeitwerk (#8098)

2019-10-02 14:01:53 +10:00

user_profile_spec.rb

Revert "FIX: Add missing unique index on user_id for user_profiles."

2019-05-24 12:58:36 +08:00

user_profile_view_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

user_search_spec.rb

SECURITY: Check permissions when autocompleting mentions

2019-10-28 11:01:47 +00:00

user_second_factor_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_spec.rb

FIX: Reload only notifications when refreshing notification count (#8221)

2019-10-21 20:25:46 +03:00

user_stat_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

user_summary_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_visit_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

username_validator_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

watched_word_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

web_crawler_request_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

web_hook_event_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

web_hook_spec.rb

DEV: Remove code deprecated by the new Reviewable API (#8023)

2019-08-26 10:33:26 -03:00