Martin Brennan 35507d4090

FIX: Process tag synonyms when approving reviewable queued post (#30810) ...

Followup 72c4709a5ab26f00e32b65d874b3a206d679181e

Previously we made a fix to allow skip validations when tagging
a topic via TopicCreator. However, this flow also skips a lot of
the more in-depth work on tags we do when creating a topic, like
processing tag synonyms. When approving reviewable queued posts,
we skip validations, so this would cause an issue where a topic
was approved and the tag synonyms weren't applied.

This commit changes the logic so we attempt the more complete
`DiscourseTagging.tag_topic_by_names` call first and if this fails
and skip validations is on, then we do
`DiscourseTagging.add_or_create_tags_by_name`.
This at least gives a chance for the full workflow to work first.

2025-01-16 11:01:45 +10:00

..

about_spec.rb

FEATURE: Enable the new /about page for everyone (#29390)

2024-10-29 18:40:11 +03:00

admin_dashboard_data_spec.rb

DEV: Remove old problem check system - Part 1 (#28772)

2024-09-06 17:00:25 +08:00

admin_notice_spec.rb

DEV: Database backed admin notices (#26192)

2024-05-23 09:29:08 +08:00

api_key_scope_spec.rb

FIX: Logs api scope not working (#25215)

2024-01-10 19:30:10 -07:00

api_key_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

application_request_spec.rb

…

associated_group_spec.rb

…

badge_grouping_spec.rb

DEV: Remove unnecessary rails_helper requiring (#26364)

2024-03-26 11:32:01 +01:00

badge_spec.rb

FIX: Don't error out when loading a badge with a deleted image (#27688)

2024-07-04 10:03:09 +08:00

badge_type_spec.rb

…

bookmark_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

category_featured_topic_spec.rb

DEV: Convert min_trust_to_create_topic to groups (#24740)

2023-12-13 14:50:13 +11:00

category_group_spec.rb

…

category_list_spec.rb

DEV: Enable Rails 7.1 defaults

2024-08-12 10:41:13 +02:00

category_setting_spec.rb

…

category_spec.rb

FIX: Permalink.create didn't work as expected anymore (#29895)

2024-11-22 21:11:26 +01:00

category_tag_stat_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

category_user_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

child_theme_spec.rb

…

color_scheme_color_spec.rb

…

color_scheme_spec.rb

FEATURE: Improve wizard quality and rearrange steps (#30055)

2025-01-02 09:28:23 +10:00

developer_spec.rb

…

digest_email_site_setting_spec.rb

…

directory_item_spec.rb

FIX: Remove anonymous users from users directory (#28892)

2024-09-13 15:12:57 +03:00

discourse_connect_spec.rb

DEV: Enable the normalize_emails site setting by default (#29952)

2024-11-28 10:23:00 +08:00

do_not_disturb_timing_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

draft_sequence_spec.rb

FIX: Destroy Drafts when increasing sequences (#27739)

2024-07-10 10:43:11 +03:00

draft_spec.rb

DEV: Delete upload references on draft cleanup (#26877)

2024-05-06 14:08:10 +08:00

email_change_request_spec.rb

…

email_log_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

email_token_spec.rb

…

embeddable_host_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

embeddable_host_tag_spec.rb

FEATURE: Extend embeddable hosts with Individual tags and author assignments (#26868)

2024-05-16 15:47:01 -04:00

emoji_spec.rb

DEV: Fix various spec linting issues (#24672)

2023-12-04 13:45:19 +01:00

flag_spec.rb

FIX: use a custom prefix for custom flags (#28839)

2024-09-11 15:30:20 +10:00

form_template_spec.rb

FIX: Form template limit validation (#28791)

2024-09-10 08:11:44 -07:00

given_daily_like_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

global_setting_spec.rb

DEV: Call Discourse.redis.flushdb after the end of each test (#29117)

2024-10-09 07:19:31 +08:00

group_archived_message_spec.rb

DEV: Remove full group refreshes from tests (#25414)

2024-01-25 14:28:26 +08:00

group_associated_group_spec.rb

…

group_history_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

group_request_spec.rb

DEV: Bump the limits on group request text fields

2023-05-24 09:57:46 +02:00

group_spec.rb

FIX: Error when moving the group default notification state (#28910)

2024-09-13 16:01:20 -03:00

group_user_spec.rb

FIX: down downgrade trust level if all requirements are met. (#25953)

2024-03-04 09:30:30 +11:00

incoming_link_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

incoming_links_report_spec.rb

DEV: Catch missing translations during test runs (#26258)

2024-05-24 22:15:53 +08:00

invite_redeemer_spec.rb

DEV: Migrate user passwords data to UserPassword table (#28746)

2024-10-10 09:23:06 +08:00

invite_spec.rb

DEV: Change hide_email_address_taken default to true (#30293)

2024-12-17 10:46:04 +08:00

javascript_cache_spec.rb

…

locale_site_setting_spec.rb

DEV: Add missing Chinese simplified to names.yml (#27847)

2024-07-11 07:54:45 -07:00

mailing_list_mode_site_setting_spec.rb

…

moved_post_spec.rb

DEV: Create permanent version of moved_posts table from PostMover class (#29664)

2024-11-12 14:35:20 -06:00

notification_spec.rb

DEV: return full name in /notifications.json (#30335)

2024-12-20 11:43:13 -05:00

onebox_locale_site_setting_spec.rb

FEATURE: Add a onebox_locale site setting. (#30655)

2025-01-09 14:11:37 +11:00

optimized_image_spec.rb

FIX: Use dualstack S3 endpoint for direct uploads (#29611)

2024-11-07 11:06:39 +10:00

permalink_spec.rb

FIX: Permalink.create didn't work as expected anymore (#29895)

2024-11-22 21:11:26 +01:00

plugin_store_spec.rb

…

post_action_spec.rb

DEV: Remove extraneous spec code (#29386)

2024-10-24 14:15:32 +02:00

post_action_type_spec.rb

FIX: serialize Flags instead of PostActionType (#28362)

2024-08-14 12:13:46 +10:00

post_analyzer_spec.rb

…

post_detail_spec.rb

…

post_mover_spec.rb

DEV: Plugin modifier to skip enqueue PostCreator jobs on PostMove (#30344)

2024-12-18 12:37:52 -06:00

post_reply_key_spec.rb

…

post_reply_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

post_revision_spec.rb

…

post_spec.rb

FIX: update flag reason message with default value (#30026)

2024-12-04 14:46:52 +11:00

post_stripper_spec.rb

FIX: user got notified about a mention inside a chat message quote (#24229)

2023-11-08 23:13:25 +04:00

post_timing_spec.rb

FIX: disable storing invalid post and topic timing when sent from client (#26683)

2024-04-19 18:10:50 +10:00

private_message_topic_tracking_state_spec.rb

PERF: avoid publishing user actions to the user who did the action (#26225)

2024-03-18 18:05:46 +01:00

problem_check_tracker_spec.rb

FIX: Make problem check tracker unique constraint work on PG13 (#29272)

2024-10-21 10:45:09 +08:00

published_page_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

quoted_post_spec.rb

DEV: Fix a flaky quote post spec (#22891)

2023-08-01 00:48:40 +02:00

remote_theme_spec.rb

FEATURE: Allow themes to define screenshots (#29079)

2024-10-28 10:10:20 +10:00

report_spec.rb

FIX: Add Type column to Flag Status CSV export (#30756)

2025-01-14 13:31:55 +10:00

reviewable_claimed_topic_spec.rb

…

reviewable_flagged_post_spec.rb

DEV: Add "delete user" options to illegal flag review (#29956)

2024-11-27 17:23:57 +08:00

reviewable_history_spec.rb

DEV: Convert min_trust_to_flag_posts setting to groups (#24864)

2023-12-13 17:18:42 +08:00

reviewable_post_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

reviewable_queued_post_spec.rb

FIX: Process tag synonyms when approving reviewable queued post (#30810)

2025-01-16 11:01:45 +10:00

reviewable_score_spec.rb

DEV: Automatically update groups for test users with explicit TL (#25415)

2024-01-29 17:52:02 +08:00

reviewable_spec.rb

FIX: Discard empty bundles for reviewables (#30121)

2024-12-05 15:41:13 +10:00

reviewable_user_spec.rb

DEV: reviewable_user spec should assert on delete_user_block instead of delete_user (#24692)

2023-12-04 12:44:32 -03:00

s3_region_site_setting_spec.rb

…

screened_email_spec.rb

DEV: Update the rubocop-discourse gem

2023-06-26 11:41:52 +02:00

screened_ip_address_spec.rb

DEV: find_each in CSV exports (#22573)

2023-08-17 12:33:52 +10:00

screened_url_spec.rb

DEV: Update the rubocop-discourse gem

2023-06-26 11:41:52 +02:00

search_log_spec.rb

DEV: Add search_log modifier to prevent search log logging (#28279)

2024-08-08 12:41:10 -05:00

sidebar_section_link_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

sidebar_section_spec.rb

FEATURE: add drafts dropdown menu (#30277)

2025-01-13 13:33:57 +04:00

sidebar_url_spec.rb

FIX: increase sidebar URL limit to 1000 (#23120)

2023-08-17 14:46:24 +10:00

site_setting_spec.rb

FIX: Admin backups erroring because of S3 dualstack (#29775)

2024-11-15 12:05:59 +10:00

site_spec.rb

FIX: Preload all ancestors of sidebar categories (#26715)

2024-05-06 11:55:20 -05:00

sitemap_spec.rb

DEV: Remove unnecessary rails_helper requiring (#26364)

2024-03-26 11:32:01 +01:00

skipped_email_log_spec.rb

…

stylesheet_cache_spec.rb

…

tag_group_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

tag_spec.rb

FEATURE: Add invite link to the sidebar (#29448)

2024-10-30 05:31:14 +03:00

tag_user_spec.rb

DEV: Convert min_trust_level_to_tag_topics to groups (#25273)

2024-01-26 13:25:03 +08:00

theme_field_spec.rb

DEV: Compile theme raw-hbr to modules (#30299)

2024-12-16 17:31:49 +00:00

theme_modifier_set_spec.rb

…

theme_setting_spec.rb

FIX: Use the proper i18n argument name

2024-06-12 11:11:02 +02:00

theme_settings_migration_spec.rb

FEATURE: Theme settings migrations (#24071)

2023-11-02 08:10:15 +03:00

theme_spec.rb

DEV: Introduce run_theme_migration spec helper in test environment (#26845)

2024-05-03 06:29:18 +08:00

theme_svg_sprite_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

top_menu_item_spec.rb

…

top_topic_spec.rb

FIX: Don't error out on nested top topic period param (#29275)

2024-10-21 10:44:43 +08:00

topic_allowed_user_spec.rb

…

topic_converter_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

topic_embed_spec.rb

FIX: topic embed blank tags or passed with nil do not blank out existing topic tags (#27699)

2024-07-03 14:50:59 -07:00

topic_featured_users_spec.rb

…

topic_group_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

topic_hot_scores_spec.rb

DEV: Trigger an event after updating topic hot scores (#29261)

2024-10-18 11:08:48 -03:00

topic_invite_spec.rb

…

topic_link_click_spec.rb

DEV: Convert min_trust_to_post_links to groups (#25298)

2024-01-18 14:08:40 +08:00

topic_link_spec.rb

FEATURE: support silent internal links (#25472)

2024-01-30 17:03:58 +11:00

topic_list_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

topic_participant_groups_summary_spec.rb

FEATURE: display PM participant group names in the topics list. (#21677)

2023-05-31 19:32:06 +05:30

topic_participants_summary_spec.rb

…

topic_posters_summary_spec.rb

…

topic_spec.rb

FEATURE: Add skip notification option to group invite to topic (#29741)

2024-11-14 13:00:15 -03:00

topic_tag_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

topic_thumbnail_spec.rb

DEV: Fix random typos (#22078)

2023-06-13 22:02:21 +02:00

topic_timer_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

topic_tracking_state_spec.rb

DEV: Dedicated route for current user notification counts (#26106)

2024-03-15 12:08:37 -04:00

topic_user_spec.rb

DEV: Remove extraneous spec code (#29386)

2024-10-24 14:15:32 +02:00

topic_view_item_spec.rb

FEATURE: topic_view_stats table with daily fidelity (#27197)

2024-05-27 15:25:32 +10:00

translation_override_spec.rb

FIX: Allow target attribute in translation overrides (#29503)

2024-11-01 09:48:07 +10:00

trust_level3_requirements_spec.rb

DEV: move post flags into database (#27125)

2024-05-23 12:19:07 +10:00

trust_level_and_staff_setting_spec.rb

…

trust_level_setting_spec.rb

DEV: Fix flaky deprecated setting specs (#30550)

2025-01-04 12:55:22 +01:00

unsubscribe_key_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

upload_reference_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

upload_spec.rb

FIX: Don't error out when loading a badge with a deleted image (#27688)

2024-07-04 10:03:09 +08:00

user_action_spec.rb

PERF: avoid publishing user actions to the user who did the action (#26225)

2024-03-18 18:05:46 +01:00

user_api_key_spec.rb

…

user_archived_message_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_associated_group_spec.rb

…

user_auth_token_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_avatar_spec.rb

DEV: ensure rebaking works even when some users have inconsistent data (#30261)

2024-12-16 19:48:25 +08:00

user_badge_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_bookmark_list_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_custom_field_spec.rb

FIX: Searchable user fields do not always have an integer name (#30223)

2024-12-17 11:06:19 +11:00

user_email_spec.rb

DEV: ensure rebaking works even when some users have inconsistent data (#30261)

2024-12-16 19:48:25 +08:00

user_export_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_field_spec.rb

FEATURE: Implement new required options in admin user fields UI (#27079)

2024-05-23 19:18:25 +08:00

user_history_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_notification_schedule_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_option_spec.rb

UX: Split hide_profile_and_presence user option (#29632)

2024-11-12 22:22:58 -03:00

user_password_spec.rb

FIX: setting new password should reset password_expired_at (#29296)

2024-10-21 07:24:43 +08:00

user_profile_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_profile_view_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_search_spec.rb

PERF: Drop user_search_similar_results site setting (#28874)

2024-09-13 09:04:02 +08:00

user_second_factor_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_security_key_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_spec.rb

UX: Split hide_profile_and_presence user option (#29632)

2024-11-12 22:22:58 -03:00

user_stat_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_status_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_summary_spec.rb

PERF: Improve performance of most_replied_to_users (#26373)

2024-04-03 14:20:54 -06:00

user_visit_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

username_validator_spec.rb

DEV: Correctly pluralize error messages (#26469)

2024-04-04 15:02:09 +02:00

watched_word_group_spec.rb

SECURITY: limit the number of characters in watched word replacements.

2024-07-15 19:25:17 +08:00

watched_word_spec.rb

SECURITY: limit the number of characters in watched word replacements.

2024-07-15 19:25:17 +08:00

web_crawler_request_spec.rb

…

web_hook_event_spec.rb

…

web_hook_event_type_spec.rb

DEV: Delete plugin specific webhook event types (#29374)

2024-10-24 11:02:58 -05:00

web_hook_events_daily_aggregate_spec.rb

FIX: Division by zero error on WebHookEventsDailyAggregate (#27667)

2024-07-01 15:40:52 -03:00

web_hook_spec.rb

FIX: topic post counts for webhook post_destroyed event (#29853)

2024-11-27 11:36:51 -08:00