discourse/app/controllers/onebox_controller.rb
Martin Brennan 901054fd75
FIX: Cache failed onebox URL request server-side (#8421)
We already cache failed onebox URL requests client-side, we now want to cache this on the server-side for extra protection. failed onebox previews will be cached for 1 hour, and any more requests for that URL will fail with a 404 status. Forcing a rebake via the Rebake HTML action will delete the failed URL cache (like how the oneboxer preview cache is deleted).
2019-11-28 07:48:29 +10:00

48 lines
1.2 KiB
Ruby

# frozen_string_literal: true
class OneboxController < ApplicationController
requires_login
def show
unless params[:refresh] == 'true'
preview = Oneboxer.cached_preview(params[:url])
preview = preview.strip if preview.present?
return render(plain: preview) if preview.present?
end
# only 1 outgoing preview per user
return render(body: nil, status: 429) if Oneboxer.is_previewing?(current_user.id)
user_id = current_user.id
category_id = params[:category_id].to_i
topic_id = params[:topic_id].to_i
invalidate = params[:refresh] == 'true'
url = params[:url]
return render(body: nil, status: 404) if Oneboxer.recently_failed?(url)
hijack do
Oneboxer.preview_onebox!(user_id)
preview = Oneboxer.preview(url,
invalidate_oneboxes: invalidate,
user_id: user_id,
category_id: category_id,
topic_id: topic_id
)
preview = preview.strip if preview.present?
Oneboxer.onebox_previewed!(user_id)
if preview.blank?
Oneboxer.cache_failed!(url)
render body: nil, status: 404
else
render plain: preview
end
end
end
end