mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 07:33:43 +08:00
ca4af53be8
* DEV: Upgrade Rails to 7.1
* FIX: Remove references to `Rails.logger.chained`
`Rails.logger.chained` was provided by Logster before Rails 7.1
introduced their broadcast logger. Now all the loggers are added to
`Rails.logger.broadcasts`.
Some code in our initializers was still using `chained` instead of
`broadcasts`.
* DEV: Make parameters optional to all FakeLogger methods
* FIX: Set `override_level` on Logster loggers (#27519)
A followup to f595d599dd
* FIX: Don’t duplicate Rack response
---------
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
40 lines
1.2 KiB
Ruby
40 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "invalid requests", type: :request do
|
|
let(:fake_logger) { FakeLogger.new }
|
|
|
|
before { Rails.logger.broadcast_to(fake_logger) }
|
|
|
|
after { Rails.logger.stop_broadcasting_to(fake_logger) }
|
|
|
|
it "handles NotFound with invalid json body" do
|
|
post "/latest.json",
|
|
params: "{some: malformed: json",
|
|
headers: {
|
|
"content-type" => "application/json",
|
|
}
|
|
expect(response.status).to eq(404)
|
|
expect(fake_logger.warnings.length).to eq(0)
|
|
expect(fake_logger.errors.length).to eq(0)
|
|
end
|
|
|
|
it "handles EOFError when multipart request is malformed" do
|
|
post "/latest.json",
|
|
params: "somecontent",
|
|
headers: {
|
|
"content-type" => "multipart/form-data; boundary=abcde",
|
|
"content-length" => "1",
|
|
}
|
|
expect(response.status).to eq(400)
|
|
expect(fake_logger.warnings.length).to eq(0)
|
|
expect(fake_logger.errors.length).to eq(0)
|
|
end
|
|
|
|
it "handles invalid parameters" do
|
|
post "/latest.json", params: { "foo" => "\255bar" }
|
|
expect(response.status).to eq(404)
|
|
expect(fake_logger.warnings.length).to eq(0)
|
|
expect(fake_logger.errors.length).to eq(0)
|
|
end
|
|
end
|