discourse/spec/requests/admin/emojis_controller_spec.rb
锦心 199f980e6a
FEATURE: Add creator and logging for CustomEmoji (#28004)
* FEATURE: Add logging for CustomEmoji

We didn't provide any logs for CustomEmoji before, nor did we record the
person who added any emoji in the database. As a result, the staff had
no way to trace back who added a certain emoji.

This commit adds a new column `user_id` to `custom_emojis` to record the
creator of an emoji. At the same time, a log is added for staff logs to
record who added or deleted a custom emoji.
2024-07-22 14:44:49 +08:00

256 lines
7.7 KiB
Ruby

# frozen_string_literal: true
RSpec.describe Admin::EmojisController do
fab!(:admin)
fab!(:moderator)
fab!(:user)
fab!(:upload)
describe "#index" do
context "when logged in as an admin" do
before { sign_in(admin) }
it "returns a list of custom emojis" do
CustomEmoji.create!(name: "osama-test-emoji", upload: upload)
Emoji.clear_cache
get "/admin/customize/emojis.json"
expect(response.status).to eq(200)
json = response.parsed_body
expect(json[0]["name"]).to eq("osama-test-emoji")
expect(json[0]["url"]).to eq(upload.url)
end
end
shared_examples "custom emojis inaccessible" do
it "denies access with a 404 response" do
get "/admin/customize/emojis.json"
expect(response.status).to eq(404)
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
end
end
context "when logged in as a moderator" do
before { sign_in(moderator) }
include_examples "custom emojis inaccessible"
end
context "when logged in as a non-staff user" do
before { sign_in(user) }
include_examples "custom emojis inaccessible"
end
end
describe "#create" do
context "when logged in as an admin" do
before { sign_in(admin) }
context "when upload is invalid" do
it "should publish the right error" do
post "/admin/customize/emojis.json",
params: {
name: "test",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/fake.jpg"),
}
expect(response.status).to eq(422)
parsed = response.parsed_body
expect(parsed["errors"]).to eq([I18n.t("upload.images.size_not_found")])
end
end
context "when emoji name already exists" do
it "should publish the right error" do
CustomEmoji.create!(name: "test", upload: upload)
post "/admin/customize/emojis.json",
params: {
name: "test",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
expect(response.status).to eq(422)
parsed = response.parsed_body
expect(parsed["errors"]).to eq(
["Name #{I18n.t("activerecord.errors.models.custom_emoji.attributes.name.taken")}"],
)
end
end
it "should allow an admin to add a custom emoji" do
Emoji.expects(:clear_cache)
post "/admin/customize/emojis.json",
params: {
name: "test",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
custom_emoji = CustomEmoji.last
upload = custom_emoji.upload
expect(upload.original_filename).to eq("logo.png")
data = response.parsed_body
expect(response.status).to eq(200)
expect(data["errors"]).to eq(nil)
expect(data["name"]).to eq(custom_emoji.name)
expect(data["url"]).to eq(upload.url)
expect(custom_emoji.group).to eq(nil)
expect(custom_emoji.user_id).to eq(admin.id)
end
it "should log the action" do
Emoji.expects(:clear_cache)
post "/admin/customize/emojis.json",
params: {
name: "test",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
last_log = UserHistory.last
expect(last_log.action).to eq(UserHistory.actions[:custom_emoji_create])
expect(last_log.acting_user_id).to eq(admin.id)
expect(last_log.new_value).to eq("test")
end
it "should allow an admin to add a custom emoji with a custom group" do
Emoji.expects(:clear_cache)
post "/admin/customize/emojis.json",
params: {
name: "test",
group: "Foo",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
custom_emoji = CustomEmoji.last
data = response.parsed_body
expect(response.status).to eq(200)
expect(custom_emoji.group).to eq("foo")
end
it "should fix up the emoji name" do
Emoji.expects(:clear_cache).times(3)
post "/admin/customize/emojis.json",
params: {
name: "test.png",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
custom_emoji = CustomEmoji.last
upload = custom_emoji.upload
expect(upload.original_filename).to eq("logo.png")
expect(custom_emoji.name).to eq("test")
expect(response.status).to eq(200)
post "/admin/customize/emojis.json",
params: {
name: "st&#* onk$",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
custom_emoji = CustomEmoji.last
expect(custom_emoji.name).to eq("st_onk_")
expect(response.status).to eq(200)
post "/admin/customize/emojis.json",
params: {
name: "PaRTYpaRrot",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
custom_emoji = CustomEmoji.last
expect(custom_emoji.name).to eq("partyparrot")
expect(response.status).to eq(200)
end
end
shared_examples "custom emoji creation not allowed" do
it "prevents creation with a 404 response" do
post "/admin/customize/emojis.json",
params: {
name: "test",
file: fixture_file_upload("#{Rails.root}/spec/fixtures/images/logo.png"),
}
expect(response.status).to eq(404)
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
end
end
context "when logged in as a moderator" do
before { sign_in(moderator) }
include_examples "custom emoji creation not allowed"
end
context "when logged in as a non-staff user" do
before { sign_in(user) }
include_examples "custom emoji creation not allowed"
end
end
describe "#destroy" do
context "when logged in as an admin" do
before { sign_in(admin) }
it "should allow an admin to delete a custom emoji" do
custom_emoji = CustomEmoji.create!(name: "test", upload: upload)
Emoji.clear_cache
expect do
delete "/admin/customize/emojis/#{custom_emoji.name}.json", params: { name: "test" }
end.to change { CustomEmoji.count }.by(-1)
end
it "should log the action" do
custom_emoji = CustomEmoji.create!(name: "test", upload: upload)
Emoji.clear_cache
delete "/admin/customize/emojis/#{custom_emoji.name}.json", params: { name: "test" }
last_log = UserHistory.last
expect(last_log.action).to eq(UserHistory.actions[:custom_emoji_destroy])
expect(last_log.acting_user_id).to eq(admin.id)
expect(last_log.previous_value).to eq("test")
end
end
shared_examples "custom emoji deletion not allowed" do
it "prevents deletion with a 404 response" do
custom_emoji = CustomEmoji.create!(name: "test", upload: upload)
Emoji.clear_cache
delete "/admin/customize/emojis/#{custom_emoji.name}.json", params: { name: "test" }
expect(response.status).to eq(404)
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
end
end
context "when logged in as a moderator" do
before { sign_in(moderator) }
include_examples "custom emoji deletion not allowed"
end
context "when logged in as a non-staff user" do
before { sign_in(user) }
include_examples "custom emoji deletion not allowed"
end
end
end