mirror of
https://github.com/discourse/discourse.git
synced 2024-12-02 12:23:37 +08:00
ac7bf98ad1
Our method of loading a subset of client settings into tests via tests/helpers/site-settings.js can be improved upon. Currently we have a hardcoded subset of the client settings, which may get out of date and not have the correct defaults. As well as this plugins do not get their settings into the tests, so whenever you need a setting from a plugin, even if it has a default, you have to do needs.setting({ ... }) which is inconvenient. This commit introduces an ember CLI build step to take the site_settings.yml and all the plugin settings.yml files, pull out the client settings, and dump them into a variable in a single JS file we can load in our tests, so we have the correct selection of settings and default values in our JS tests. It also fixes many, many tests that were operating under incorrect assumptions or old settings. Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
231 lines
6.7 KiB
JavaScript
231 lines
6.7 KiB
JavaScript
import {
|
|
acceptance,
|
|
count,
|
|
exists,
|
|
query,
|
|
} from "discourse/tests/helpers/qunit-helpers";
|
|
import { click, currentURL, fillIn, visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import {
|
|
joinChannel,
|
|
leaveChannel,
|
|
presentUserIds,
|
|
} from "discourse/tests/helpers/presence-pretender";
|
|
import User from "discourse/models/user";
|
|
import selectKit from "discourse/tests/helpers/select-kit-helper";
|
|
|
|
acceptance("Discourse Presence Plugin", function (needs) {
|
|
needs.user({ whisperer: true });
|
|
needs.settings({ enable_whispers: true });
|
|
|
|
test("Doesn't break topic creation", async function (assert) {
|
|
await visit("/");
|
|
await click("#create-topic");
|
|
const categoryChooser = selectKit(".category-chooser");
|
|
await categoryChooser.expand();
|
|
await categoryChooser.selectRowByValue(2);
|
|
await fillIn("#reply-title", "Internationalization Localization");
|
|
await fillIn(
|
|
".d-editor-input",
|
|
"this is the *content* of a new topic post"
|
|
);
|
|
await click("#reply-control button.create");
|
|
|
|
assert.strictEqual(
|
|
currentURL(),
|
|
"/t/internationalization-localization/280",
|
|
"it transitions to the newly created topic URL"
|
|
);
|
|
});
|
|
|
|
test("Publishes own reply presence", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
|
|
await click("#topic-footer-buttons .btn.create");
|
|
assert.ok(exists(".d-editor-input"), "the composer input is visible");
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/reply/280"),
|
|
[],
|
|
"does not publish presence for open composer"
|
|
);
|
|
|
|
await fillIn(".d-editor-input", "this is the content of my reply");
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/reply/280"),
|
|
[User.current().id],
|
|
"publishes presence when typing"
|
|
);
|
|
|
|
await click("#reply-control button.create");
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/reply/280"),
|
|
[],
|
|
"leaves channel when composer closes"
|
|
);
|
|
});
|
|
|
|
test("Uses whisper channel for whispers", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
|
|
await click("#topic-footer-buttons .btn.create");
|
|
assert.ok(exists(".d-editor-input"), "the composer input is visible");
|
|
|
|
await fillIn(".d-editor-input", "this is the content of my reply");
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/reply/280"),
|
|
[User.current().id],
|
|
"publishes reply presence when typing"
|
|
);
|
|
|
|
const menu = selectKit(".toolbar-popup-menu-options");
|
|
await menu.expand();
|
|
await menu.selectRowByValue("toggleWhisper");
|
|
|
|
assert.strictEqual(
|
|
count(".composer-actions svg.d-icon-far-eye-slash"),
|
|
1,
|
|
"it sets the post type to whisper"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/reply/280"),
|
|
[],
|
|
"removes reply presence"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/whisper/280"),
|
|
[User.current().id],
|
|
"adds whisper presence"
|
|
);
|
|
|
|
await click("#reply-control button.create");
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/whisper/280"),
|
|
[],
|
|
"leaves whisper channel when composer closes"
|
|
);
|
|
});
|
|
|
|
test("Uses the edit channel for editing", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
|
|
await click(".topic-post:nth-of-type(1) button.show-more-actions");
|
|
await click(".topic-post:nth-of-type(1) button.edit");
|
|
|
|
assert.strictEqual(
|
|
query(".d-editor-input").value,
|
|
query(".topic-post:nth-of-type(1) .cooked > p").innerText,
|
|
"composer has contents of post to be edited"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/edit/398"),
|
|
[],
|
|
"is not present when composer first opened"
|
|
);
|
|
|
|
await fillIn(".d-editor-input", "some edited content");
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/edit/398"),
|
|
[User.current().id],
|
|
"becomes present in the edit channel"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/reply/280"),
|
|
[],
|
|
"is not made present in the reply channel"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
presentUserIds("/discourse-presence/whisper/280"),
|
|
[],
|
|
"is not made present in the whisper channel"
|
|
);
|
|
});
|
|
|
|
test("Displays replying and whispering presence at bottom of topic", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
|
|
const avatarSelector =
|
|
".topic-above-footer-buttons-outlet.presence .presence-avatars .avatar";
|
|
assert.ok(
|
|
exists(".topic-above-footer-buttons-outlet.presence"),
|
|
"includes the presence component"
|
|
);
|
|
assert.strictEqual(count(avatarSelector), 0, "no avatars displayed");
|
|
|
|
await joinChannel("/discourse-presence/reply/280", {
|
|
id: 123,
|
|
avatar_template: "/images/avatar.png",
|
|
username: "my-username",
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 1, "avatar displayed");
|
|
|
|
await joinChannel("/discourse-presence/whisper/280", {
|
|
id: 124,
|
|
avatar_template: "/images/avatar.png",
|
|
username: "my-username2",
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 2, "whisper avatar displayed");
|
|
|
|
await leaveChannel("/discourse-presence/reply/280", {
|
|
id: 123,
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 1, "reply avatar removed");
|
|
|
|
await leaveChannel("/discourse-presence/whisper/280", {
|
|
id: 124,
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 0, "whisper avatar removed");
|
|
});
|
|
|
|
test("Displays replying and whispering presence in composer", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
await click("#topic-footer-buttons .btn.create");
|
|
assert.ok(exists(".d-editor-input"), "the composer input is visible");
|
|
|
|
const avatarSelector = ".reply-to .presence-avatars .avatar";
|
|
assert.strictEqual(count(avatarSelector), 0, "no avatars displayed");
|
|
|
|
await joinChannel("/discourse-presence/reply/280", {
|
|
id: 123,
|
|
avatar_template: "/images/avatar.png",
|
|
username: "my-username",
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 1, "avatar displayed");
|
|
|
|
await joinChannel("/discourse-presence/whisper/280", {
|
|
id: 124,
|
|
avatar_template: "/images/avatar.png",
|
|
username: "my-username2",
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 2, "whisper avatar displayed");
|
|
|
|
await leaveChannel("/discourse-presence/reply/280", {
|
|
id: 123,
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 1, "reply avatar removed");
|
|
|
|
await leaveChannel("/discourse-presence/whisper/280", {
|
|
id: 124,
|
|
});
|
|
|
|
assert.strictEqual(count(avatarSelector), 0, "whisper avatar removed");
|
|
});
|
|
});
|