mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 07:51:36 +08:00
d2e24f9569
Note this is a very large PR, and some of it could have been splited, but keeping it one chunk made it to merge conflicts and to revert if necessary. Actual new code logic is also not that much, as most of the changes are removing js tests, adding system specs or moving things around. To make it possible this commit is doing the following changes: - converting (and adding new) existing js acceptances tests into system tests. This change was necessary to ensure as little regressions as possible while changing paradigm - moving away from store. Using glimmer and tracked properties requires to have class objects everywhere and as a result works well with models. However store/adapters are suffering from many bugs and limitations. As a workaround the `chat-api` and `chat-channels-manager` are an answer to this problem by encapsulating backend calls and frontend storage logic; while still using js models. - dropping `appEvents` as much as possible. Using tracked properties and a better local storage of channel models, allows to be much more reactive and doesn’t require arbitrary manual updates everywhere in the app. - while working on replacing store, the existing work of a chat api (backend) has been continued to support more cases. - removing code from the `chat` service to separate concerns, `chat-subscriptions-manager` and `chat-channels-manager`, being the largest examples of where the code has been rewritten/moved. Future wok: - improve behavior when closing/deleting a channel, it's already slightly buggy on live, it's rare enough that it's not a big issue, but should be improved - improve page objects used in chat - move more endpoints to the API - finish temporarily skipped tests - extract more code from the `chat` service - use glimmer for `chat-messages` - separate concerns in `chat-live-pane` - eventually add js tests for `chat-api`, `chat-channels-manager` and `chat-subscriptions-manager`, they are indirectly heavy tested through system tests but it would be nice to at least test the public API <!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. --> |
||
|---|---|---|
| .. | ||
| chat-browse.scss | ||
| chat-channel-card.scss | ||
| chat-channel-info.scss | ||
| chat-channel-preview-card.scss | ||
| chat-channel-selector-modal.scss | ||
| chat-channel-settings-saved-indicator.scss | ||
| chat-channel-title.scss | ||
| chat-composer-dropdown.scss | ||
| chat-composer-inline-button.scss | ||
| chat-composer-upload.scss | ||
| chat-composer-uploads.scss | ||
| chat-composer.scss | ||
| chat-draft-channel.scss | ||
| chat-drawer.scss | ||
| chat-emoji-picker.scss | ||
| chat-form.scss | ||
| chat-index.scss | ||
| chat-mention-warnings.scss | ||
| chat-message-actions.scss | ||
| chat-message-collapser.scss | ||
| chat-message-images.scss | ||
| chat-message-info.scss | ||
| chat-message-left-gutter.scss | ||
| chat-message-separator.scss | ||
| chat-message.scss | ||
| chat-onebox.scss | ||
| chat-reply.scss | ||
| chat-replying-indicator.scss | ||
| chat-retention-reminder.scss | ||
| chat-selection-manager.scss | ||
| chat-skeleton.scss | ||
| chat-tabs.scss | ||
| chat-transcript.scss | ||
| common.scss | ||
| core-extensions.scss | ||
| d-progress-bar.scss | ||
| dc-filter-input.scss | ||
| direct-message-creator.scss | ||
| full-page-chat-header.scss | ||
| incoming-chat-webhooks.scss | ||
| reviewable-chat-message.scss | ||