mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 07:34:18 +08:00
d3f02a1270
This commit fleshes out and adds functionality for the new `#hashtag` search and lookup system, still hidden behind the `enable_experimental_hashtag_autocomplete` feature flag. **Serverside** We have two plugin API registration methods that are used to define data sources (`register_hashtag_data_source`) and hashtag result type priorities depending on the context (`register_hashtag_type_in_context`). Reading the comments in plugin.rb should make it clear what these are doing. Reading the `HashtagAutocompleteService` in full will likely help a lot as well. Each data source is responsible for providing its own **lookup** and **search** method that returns hashtag results based on the arguments provided. For example, the category hashtag data source has to take into account parent categories and how they relate, and each data source has to define their own icon to use for the hashtag, and so on. The `Site` serializer has two new attributes that source data from `HashtagAutocompleteService`. There is `hashtag_icons` that is just a simple array of all the different icons that can be used for allowlisting in our markdown pipeline, and there is `hashtag_context_configurations` that is used to store the type priority orders for each registered context. When sending emails, we cannot render the SVG icons for hashtags, so we need to change the HTML hashtags to the normal `#hashtag` text. **Markdown** The `hashtag-autocomplete.js` file is where I have added the new `hashtag-autocomplete` markdown rule, and like all of our rules this is used to cook the raw text on both the clientside and on the serverside using MiniRacer. Only on the server side do we actually reach out to the database with the `hashtagLookup` function, on the clientside we just render a plainer version of the hashtag HTML. Only in the composer preview do we do further lookups based on this. This rule is the first one (that I can find) that uses the `currentUser` based on a passed in `user_id` for guardian checks in markdown rendering code. This is the `last_editor_id` for both the post and chat message. In some cases we need to cook without a user present, so the `Discourse.system_user` is used in this case. **Chat Channels** This also contains the changes required for chat so that chat channels can be used as a data source for hashtag searches and lookups. This data source will only be used when `enable_experimental_hashtag_autocomplete` is `true`, so we don't have to worry about channel results suddenly turning up. ------ **Known Rough Edges** - Onebox excerpts will not render the icon svg/use tags, I plan to address that in a follow up PR - Selecting a hashtag + pressing the Quote button will result in weird behaviour, I plan to address that in a follow up PR - Mixed hashtag contexts for hashtags without a type suffix will not work correctly, e.g. #ux which is both a category and a channel slug will resolve to a category when used inside a post or within a [chat] transcript in that post. Users can get around this manually by adding the correct suffix, for example ::channel. We may get to this at some point in future - Icons will not show for the hashtags in emails since SVG support is so terrible in email (this is not likely to be resolved, but still noting for posterity) - Additional refinements and review fixes wil
286 lines
8.9 KiB
Ruby
286 lines
8.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Navigation", type: :system, js: true do
|
|
fab!(:category) { Fabricate(:category) }
|
|
fab!(:topic) { Fabricate(:topic) }
|
|
fab!(:post) { Fabricate(:post, topic: topic) }
|
|
fab!(:user) { Fabricate(:admin) }
|
|
fab!(:category_channel) { Fabricate(:category_channel) }
|
|
fab!(:category_channel_2) { Fabricate(:category_channel) }
|
|
fab!(:message) { Fabricate(:chat_message, chat_channel: category_channel) }
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:sidebar_page) { PageObjects::Pages::Sidebar.new }
|
|
let(:chat_drawer_page) { PageObjects::Pages::ChatDrawer.new }
|
|
|
|
before do
|
|
chat_system_bootstrap(user, [category_channel, category_channel_2])
|
|
sign_in(user)
|
|
end
|
|
|
|
context "when visiting /chat" do
|
|
it "opens full page" do
|
|
chat_page.open
|
|
|
|
expect(page).to have_current_path(
|
|
chat.channel_path(category_channel.id, category_channel.slug),
|
|
)
|
|
expect(page).to have_css("html.has-full-page-chat")
|
|
expect(page).to have_css(".chat-message-container[data-id='#{message.id}']")
|
|
end
|
|
end
|
|
|
|
context "when opening chat" do
|
|
it "opens the drawer by default" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
|
|
expect(page).to have_css(".topic-chat-container.expanded.visible")
|
|
end
|
|
end
|
|
|
|
context "when opening chat with full page as preferred mode" do
|
|
it "opens the full page" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.maximize
|
|
|
|
expect(page).to have_current_path(
|
|
chat.channel_path(category_channel.id, category_channel.slug),
|
|
)
|
|
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
|
|
expect(page).to have_current_path(
|
|
chat.channel_path(category_channel.id, category_channel.slug),
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when opening chat with drawer as preferred mode" do
|
|
it "opens the full page" do
|
|
chat_page.open
|
|
chat_page.minimize_full_page
|
|
|
|
expect(page).to have_css(".topic-chat-container.expanded.visible")
|
|
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
|
|
expect(page).to have_css(".topic-chat-container.expanded.visible")
|
|
end
|
|
end
|
|
|
|
context "when collapsing full page with no previous state" do
|
|
it "redirects to home page" do
|
|
chat_page.open
|
|
chat_page.minimize_full_page
|
|
|
|
expect(page).to have_current_path(latest_path)
|
|
end
|
|
end
|
|
|
|
context "when collapsing full page with previous state" do
|
|
it "redirects to previous state" do
|
|
visit("/t/-/#{topic.id}")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.maximize
|
|
chat_page.minimize_full_page
|
|
|
|
expect(page).to have_current_path("/t/#{topic.slug}/#{topic.id}")
|
|
expect(page).to have_css(".chat-message-container[data-id='#{message.id}']")
|
|
end
|
|
end
|
|
|
|
context "when opening full page with a link containing a message id" do
|
|
it "highlights correct message" do
|
|
visit("/chat/channel/#{category_channel.id}/#{category_channel.slug}?messageId=#{message.id}")
|
|
|
|
expect(page).to have_css(
|
|
".full-page-chat .chat-message-container.highlighted[data-id='#{message.id}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when opening drawer with a link containing a message id" do
|
|
it "highlights correct message" do
|
|
Fabricate(
|
|
:post,
|
|
topic: topic,
|
|
raw:
|
|
"<a href=\"/chat/channel/#{category_channel.id}/#{category_channel.slug}?messageId=#{message.id}\">foo</a>",
|
|
)
|
|
visit("/t/-/#{topic.id}")
|
|
find("a", text: "foo").click
|
|
|
|
expect(page).to have_css(
|
|
".topic-chat-container.expanded.visible .chat-message-container.highlighted[data-id='#{message.id}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when sidebar is enabled" do
|
|
before do
|
|
SiteSetting.enable_experimental_sidebar_hamburger = true
|
|
SiteSetting.enable_sidebar = true
|
|
end
|
|
|
|
context "when opening channel from sidebar with drawer preferred" do
|
|
it "opens channel in drawer" do
|
|
visit("/t/-/#{topic.id}")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.close
|
|
find("a[title='#{category_channel.title}']").click
|
|
|
|
expect(page).to have_css(".chat-message-container[data-id='#{message.id}']")
|
|
end
|
|
end
|
|
|
|
context "when opening channel from sidebar with full page preferred" do
|
|
it "opens channel in full page" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.maximize
|
|
visit("/")
|
|
find("a[title='#{category_channel.title}']").click
|
|
|
|
expect(page).to have_current_path(
|
|
chat.channel_path(category_channel.id, category_channel.slug),
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when starting draft from sidebar with drawer preferred" do
|
|
it "opens draft in drawer" do
|
|
visit("/")
|
|
sidebar_page.open_draft_channel
|
|
|
|
expect(page).to have_current_path("/")
|
|
expect(page).to have_css(".topic-chat-container.expanded.visible .direct-message-creator")
|
|
end
|
|
end
|
|
|
|
context "when starting draft from drawer with drawer preferred" do
|
|
it "opens draft in drawer" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_draft_channel
|
|
|
|
expect(page).to have_current_path("/")
|
|
expect(page).to have_css(".topic-chat-container.expanded.visible .direct-message-creator")
|
|
end
|
|
end
|
|
|
|
context "when starting draft from sidebar with full page preferred" do
|
|
it "opens draft in full page" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.maximize
|
|
visit("/")
|
|
sidebar_page.open_draft_channel
|
|
|
|
expect(page).to have_current_path("/chat/draft-channel")
|
|
expect(page).not_to have_css(".topic-chat-container.expanded.visible")
|
|
end
|
|
end
|
|
|
|
context "when opening browse page from drawer in drawer mode" do
|
|
it "opens browser page in full page" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_browse
|
|
|
|
expect(page).to have_current_path("/chat/browse/open")
|
|
expect(page).not_to have_css(".topic-chat-container.expanded.visible")
|
|
end
|
|
end
|
|
|
|
context "when opening browse page from sidebar in drawer mode" do
|
|
it "opens browser page in full page" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
sidebar_page.open_browse
|
|
|
|
expect(page).to have_current_path("/chat/browse/open")
|
|
expect(page).not_to have_css(".topic-chat-container.expanded.visible")
|
|
end
|
|
end
|
|
|
|
context "when re-opening drawer after navigating to a channel" do
|
|
it "opens drawer on correct channel" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_channel(category_channel_2)
|
|
chat_drawer_page.open_index
|
|
chat_drawer_page.close
|
|
chat_page.open_from_header
|
|
|
|
expect(page).to have_current_path("/")
|
|
expect(page).to have_css(".topic-chat-container.expanded.visible")
|
|
expect(page).to have_content(category_channel_2.title)
|
|
end
|
|
end
|
|
|
|
context "when re-opening full page chat after navigating to a channel" do
|
|
it "opens full page chat on correct channel" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.maximize
|
|
sidebar_page.open_channel(category_channel_2)
|
|
find("#site-logo").click
|
|
chat_page.open_from_header
|
|
|
|
expect(page).to have_current_path(
|
|
chat.channel_path(category_channel_2.id, category_channel_2.slug),
|
|
)
|
|
expect(page).to have_content(category_channel_2.title)
|
|
end
|
|
end
|
|
|
|
context "when opening a channel in full page" do
|
|
it "activates the channel in the sidebar" do
|
|
visit("/chat/channel/#{category_channel.id}/#{category_channel.slug}")
|
|
expect(page).to have_css(
|
|
".sidebar-section-link-#{category_channel.slug}.sidebar-section-link--active",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when clicking logo from a channel in full page" do
|
|
it "deactivates the channel in the sidebar" do
|
|
visit("/chat/channel/#{category_channel.id}/#{category_channel.slug}")
|
|
find("#site-logo").click
|
|
|
|
expect(page).not_to have_css(
|
|
".sidebar-section-link-#{category_channel.slug}.sidebar-section-link--active",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when opening a channel in drawer" do
|
|
it "activates the channel in the sidebar" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
find("a[title='#{category_channel.title}']").click
|
|
|
|
expect(page).to have_css(
|
|
".sidebar-section-link-#{category_channel.slug}.sidebar-section-link--active",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when closing drawer in a channel" do
|
|
it "deactivates the channel in the sidebar" do
|
|
visit("/")
|
|
chat_page.open_from_header
|
|
find("a[title='#{category_channel.title}']").click
|
|
chat_drawer_page.close
|
|
|
|
expect(page).not_to have_css(
|
|
".sidebar-section-link-#{category_channel.slug}.sidebar-section-link--active",
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|