mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 19:43:45 +08:00
35b748e7f4
This commit fixes a bug where the silence button is incorrectly displayed on the admin page of a staff user. It's not actually possible to silence a staff user because the backend correctly prevents it, but the frontend isn't checking if the button should be displayed. Another small bug that this commit fixes is the similar users list not showing up inside the silence/suspend modals due to also a bug in the frontend. I've also changed the way similar users are loaded so that they're not returned by the `admin/users#show` endpoint anymore and moved them into a new endpoint that the penalize modals (suspend and silence) can call directly to retrieve the list of users. This is done because the similar users list is never shown on the admin user page (`/admin/users/:user_id/:username`); they're only needed when the suspend or silence modals are opened. Internal topic: t/130014.
49 lines
1.1 KiB
JavaScript
49 lines
1.1 KiB
JavaScript
import Component from "@glimmer/component";
|
|
import { tracked } from "@glimmer/tracking";
|
|
import { action } from "@ember/object";
|
|
import { ajax } from "discourse/lib/ajax";
|
|
|
|
export default class AdminPenaltySimilarUsers extends Component {
|
|
@tracked isLoading;
|
|
@tracked similarUsers = [];
|
|
selectedUserIds = [];
|
|
|
|
constructor() {
|
|
super(...arguments);
|
|
|
|
this.loadSimilarUsers();
|
|
}
|
|
|
|
get penaltyField() {
|
|
const penaltyType = this.args.penaltyType;
|
|
if (penaltyType === "suspend") {
|
|
return "can_be_suspended";
|
|
} else if (penaltyType === "silence") {
|
|
return "can_be_silenced";
|
|
}
|
|
}
|
|
|
|
async loadSimilarUsers() {
|
|
this.isLoading = true;
|
|
try {
|
|
const data = await ajax(
|
|
`/admin/users/${this.args.user.id}/similar-users.json`
|
|
);
|
|
this.similarUsers = data.users;
|
|
} finally {
|
|
this.isLoading = false;
|
|
}
|
|
}
|
|
|
|
@action
|
|
selectUserId(userId, event) {
|
|
if (event.target.checked) {
|
|
this.selectedUserIds.push(userId);
|
|
} else {
|
|
this.selectedUserIds = this.selectedUserIds.filter((id) => id !== userId);
|
|
}
|
|
|
|
this.args.onUsersChanged(this.selectedUserIds);
|
|
}
|
|
}
|