discourse/app
Osama Sayegh d745568633
DEV: Stop polluting Class with deprecated settings methods (#10736)
`self.class` here evaluates to `Class` and then we're calling `define_method` on it which means all classes will have those methods defined in them. For example:

```
~/discourse(master*) » rails c
Loading development environment (Rails 6.0.3.3)
[1] pry(main)> Integer.methods
=> [:sqrt,
 :yaml_tag,
 :email_domains_blacklist=,
 :email_domains_whitelist=,
 :unicode_username_character_whitelist=,
 :user_website_domains_whitelist=,
 :whitelisted_link_domains=,
 :email_domains_blacklist,
 :email_domains_whitelist,
 :unicode_username_character_whitelist,
...
...
```

Fix here is to use `self.define_singleton_method`.
2020-09-24 01:58:53 +03:00
..
assets FIX: mouseEnter is deprecated in newer Ember releases 2020-09-23 15:29:41 -04:00
controllers Add extra locales to bootstrap.json 2020-09-23 14:48:52 -04:00
helpers DEV: make it possible to enable cdn in development environment. 2020-09-23 11:52:16 +05:30
jobs FIX: email always settings were not being respected 2020-09-23 22:00:15 +05:30
mailers FEATURE: Allow email image embed with secure media (#10563) 2020-09-10 09:50:16 +10:00
models DEV: Stop polluting Class with deprecated settings methods (#10736) 2020-09-24 01:58:53 +03:00
serializers FIX: Do not downcase group name in current user serializer 2020-09-17 13:03:42 -04:00
services FIX: Do not downcase group name in notification payload 2020-09-21 13:33:29 -04:00
views FIX: use normal logo in published pages if small not available. 2020-09-21 09:20:39 +05:30