mirror of
https://github.com/discourse/discourse.git
synced 2024-11-27 22:23:44 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
50 lines
1.5 KiB
Ruby
50 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe UsernameCheckerService do
|
|
|
|
describe 'check_username' do
|
|
|
|
before do
|
|
@service = UsernameCheckerService.new
|
|
@nil_email = nil
|
|
@email = 'vincentvega@example.com'
|
|
end
|
|
|
|
context 'Username invalid' do
|
|
it 'rejects too short usernames' do
|
|
result = @service.check_username('a', @nil_email)
|
|
expect(result).to have_key(:errors)
|
|
end
|
|
it 'rejects too long usernames' do
|
|
result = @service.check_username('a123456789b123456789c123456789', @nil_email)
|
|
expect(result).to have_key(:errors)
|
|
end
|
|
|
|
it 'rejects usernames with invalid characters' do
|
|
result = @service.check_username('vincent-', @nil_email)
|
|
expect(result).to have_key(:errors)
|
|
end
|
|
|
|
it 'rejects usernames that do not start with an alphanumeric character' do
|
|
result = @service.check_username('.vincent', @nil_email)
|
|
expect(result).to have_key(:errors)
|
|
end
|
|
end
|
|
|
|
it 'username not available locally' do
|
|
User.stubs(:username_available?).returns(false)
|
|
UserNameSuggester.stubs(:suggest).returns('einar-j')
|
|
result = @service.check_username('vincent', @nil_email)
|
|
expect(result[:available]).to eq(false)
|
|
expect(result[:suggestion]).to eq('einar-j')
|
|
end
|
|
|
|
it 'username available locally' do
|
|
User.stubs(:username_available?).returns(true)
|
|
result = @service.check_username('vincent', @nil_email)
|
|
expect(result[:available]).to eq(true)
|
|
end
|
|
end
|
|
|
|
end
|