mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 03:33:39 +08:00
cd2c9edb46
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
159 lines
5.3 KiB
Ruby
159 lines
5.3 KiB
Ruby
require 'spec_helper'
|
|
require 'digest/sha1'
|
|
|
|
describe Upload do
|
|
it { is_expected.to belong_to :user }
|
|
|
|
it { is_expected.to have_many :post_uploads }
|
|
it { is_expected.to have_many :posts }
|
|
|
|
it { is_expected.to have_many :optimized_images }
|
|
|
|
let(:upload) { build(:upload) }
|
|
let(:thumbnail) { build(:optimized_image, upload: upload) }
|
|
|
|
let(:user_id) { 1 }
|
|
let(:url) { "http://domain.com" }
|
|
|
|
let(:image_filename) { "logo.png" }
|
|
let(:image) { file_from_fixtures(image_filename) }
|
|
let(:image_filesize) { File.size(image) }
|
|
let(:image_sha1) { Digest::SHA1.file(image).hexdigest }
|
|
|
|
let(:image_svg_filename) { "image.svg" }
|
|
let(:image_svg) { file_from_fixtures(image_svg_filename) }
|
|
let(:image_svg_filesize) { File.size(image_svg) }
|
|
|
|
let(:attachment_path) { __FILE__ }
|
|
let(:attachment) { File.new(attachment_path) }
|
|
let(:attachment_filename) { File.basename(attachment_path) }
|
|
let(:attachment_filesize) { File.size(attachment_path) }
|
|
|
|
context ".create_thumbnail!" do
|
|
|
|
it "does not create a thumbnail when disabled" do
|
|
SiteSetting.stubs(:create_thumbnails?).returns(false)
|
|
OptimizedImage.expects(:create_for).never
|
|
upload.create_thumbnail!(100, 100)
|
|
end
|
|
|
|
it "creates a thumbnail" do
|
|
upload = Fabricate(:upload)
|
|
thumbnail = Fabricate(:optimized_image, upload: upload)
|
|
SiteSetting.expects(:create_thumbnails?).returns(true)
|
|
OptimizedImage.expects(:create_for).returns(thumbnail)
|
|
upload.create_thumbnail!(100, 100)
|
|
upload.reload
|
|
expect(upload.optimized_images.count).to eq(1)
|
|
end
|
|
|
|
end
|
|
|
|
context "#create_for" do
|
|
|
|
before { Upload.stubs(:fix_image_orientation) }
|
|
|
|
it "does not create another upload if it already exists" do
|
|
Upload.expects(:find_by).with(sha1: image_sha1).returns(upload)
|
|
Upload.expects(:save).never
|
|
expect(Upload.create_for(user_id, image, image_filename, image_filesize)).to eq(upload)
|
|
end
|
|
|
|
it "fix image orientation" do
|
|
Upload.expects(:fix_image_orientation).with(image.path)
|
|
Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
end
|
|
|
|
it "computes width & height for images" do
|
|
FastImage.any_instance.expects(:size).returns([100, 200])
|
|
ImageSizer.expects(:resize)
|
|
image.expects(:rewind).twice
|
|
Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
end
|
|
|
|
it "does not create an upload when there is an error with FastImage" do
|
|
FileHelper.expects(:is_image?).returns(true)
|
|
Upload.expects(:save).never
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "does not compute width & height for non-image" do
|
|
FastImage.any_instance.expects(:size).never
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "generates an error when the image is too large" do
|
|
SiteSetting.stubs(:max_image_size_kb).returns(1)
|
|
upload = Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "generates an error when the attachment is too large" do
|
|
SiteSetting.stubs(:max_attachment_size_kb).returns(1)
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "saves proper information" do
|
|
store = {}
|
|
Discourse.expects(:store).returns(store)
|
|
store.expects(:store_upload).returns(url)
|
|
|
|
upload = Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
|
|
expect(upload.user_id).to eq(user_id)
|
|
expect(upload.original_filename).to eq(image_filename)
|
|
expect(upload.filesize).to eq(image_filesize)
|
|
expect(upload.sha1).to eq(image_sha1)
|
|
expect(upload.width).to eq(244)
|
|
expect(upload.height).to eq(66)
|
|
expect(upload.url).to eq(url)
|
|
end
|
|
|
|
context "when svg is authorized" do
|
|
|
|
before { SiteSetting.stubs(:authorized_extensions).returns("svg") }
|
|
|
|
it "consider SVG as an image" do
|
|
store = {}
|
|
Discourse.expects(:store).returns(store)
|
|
store.expects(:store_upload).returns(url)
|
|
|
|
upload = Upload.create_for(user_id, image_svg, image_svg_filename, image_svg_filesize)
|
|
|
|
expect(upload.user_id).to eq(user_id)
|
|
expect(upload.original_filename).to eq(image_svg_filename)
|
|
expect(upload.filesize).to eq(image_svg_filesize)
|
|
expect(upload.width).to eq(100)
|
|
expect(upload.height).to eq(50)
|
|
expect(upload.url).to eq(url)
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
context ".get_from_url" do
|
|
|
|
it "works when the file has been uploaded" do
|
|
Upload.expects(:find_by).returns(nil).once
|
|
Upload.get_from_url("/uploads/default/1/10387531.jpg")
|
|
end
|
|
|
|
it "works when using a cdn" do
|
|
Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
|
|
Upload.expects(:find_by).with(url: "/uploads/default/1/02395732905.jpg").returns(nil).once
|
|
Upload.get_from_url("http://my.cdn.com/uploads/default/1/02395732905.jpg")
|
|
end
|
|
|
|
it "works only when the file has been uploaded" do
|
|
Upload.expects(:find_by).never
|
|
Upload.get_from_url("http://domain.com/my/file.txt")
|
|
end
|
|
|
|
end
|
|
|
|
end
|