mirror of
https://github.com/discourse/discourse.git
synced 2024-12-19 14:24:05 +08:00
56d3e29a69
* Fix user title logic when badge name customized * Fix an issue where a user's title was not considered a badge granted title when the user used a badge for their title and the badge name was customized. this affected the effectiveness of revoke_ungranted_titles! which only operates on badge_granted_titles. * When a user's title is set now it is considered a badge_granted_title if the badge name OR the badge custom name from TranslationOverride is the same as the title * When a user's badge is revoked we now also revoke their title if the user's title matches the badge name OR the badge custom name from TranslationOverride * Add a user history log when the title is revoked to remove confusion about why titles are revoked * Add granted_title_badge_id to user_profile, now when we set badge_granted_title on a user profile when updating a user's title based on a badge, we also remember which badge matched the title * When badge name (or custom text) changes update titles of users in a background job * When the name of a badge changes, or in the case of system badges when their custom translation text changes, then we need to update the title of all corresponding users who have a badge_granted_title and matching granted_title_badge_id. In the case of system badges we need to first get the proper badge ID based on the translation key e.g. badges.regular.name * Add migration to backfill all granted_title_badge_ids for both normal badge name titles and titles using custom badge text.
143 lines
3.8 KiB
Ruby
143 lines
3.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Admin::BadgesController < Admin::AdminController
|
|
|
|
def index
|
|
data = {
|
|
badge_types: BadgeType.all.order(:id).to_a,
|
|
badge_groupings: BadgeGrouping.all.order(:position).to_a,
|
|
badges: Badge.includes(:badge_grouping)
|
|
.includes(:badge_type)
|
|
.references(:badge_grouping)
|
|
.order('badge_groupings.position, badge_type_id, badges.name').to_a,
|
|
protected_system_fields: Badge.protected_system_fields,
|
|
triggers: Badge.trigger_hash
|
|
}
|
|
render_serialized(OpenStruct.new(data), AdminBadgesSerializer)
|
|
end
|
|
|
|
def preview
|
|
unless SiteSetting.enable_badge_sql
|
|
return render json: "preview not allowed", status: 403
|
|
end
|
|
|
|
render json: BadgeGranter.preview(params[:sql],
|
|
target_posts: params[:target_posts] == "true",
|
|
explain: params[:explain] == "true",
|
|
trigger: params[:trigger].to_i)
|
|
end
|
|
|
|
def new
|
|
end
|
|
|
|
def show
|
|
end
|
|
|
|
def badge_types
|
|
badge_types = BadgeType.all.to_a
|
|
render_serialized(badge_types, BadgeTypeSerializer, root: "badge_types")
|
|
end
|
|
|
|
def save_badge_groupings
|
|
badge_groupings = BadgeGrouping.all.order(:position).to_a
|
|
ids = params[:ids].map(&:to_i)
|
|
|
|
params[:names].each_with_index do |name, index|
|
|
id = ids[index].to_i
|
|
group = badge_groupings.find { |b| b.id == id } || BadgeGrouping.new
|
|
group.name = name
|
|
group.position = index
|
|
group.save
|
|
end
|
|
|
|
badge_groupings.each do |g|
|
|
g.destroy unless g.system? || ids.include?(g.id)
|
|
end
|
|
|
|
badge_groupings = BadgeGrouping.all.order(:position).to_a
|
|
render_serialized(badge_groupings, BadgeGroupingSerializer, root: "badge_groupings")
|
|
end
|
|
|
|
def create
|
|
badge = Badge.new
|
|
errors = update_badge_from_params(badge, new: true)
|
|
|
|
if errors.present?
|
|
render_json_error errors
|
|
else
|
|
StaffActionLogger.new(current_user).log_badge_creation(badge)
|
|
render_serialized(badge, AdminBadgeSerializer, root: "badge")
|
|
end
|
|
end
|
|
|
|
def update
|
|
badge = find_badge
|
|
errors = update_badge_from_params(badge)
|
|
|
|
if errors.present?
|
|
render_json_error errors
|
|
else
|
|
StaffActionLogger.new(current_user).log_badge_change(badge)
|
|
render_serialized(badge, AdminBadgeSerializer, root: "badge")
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
badge = find_badge
|
|
StaffActionLogger.new(current_user).log_badge_deletion(badge)
|
|
badge.destroy
|
|
render body: nil
|
|
end
|
|
|
|
private
|
|
def find_badge
|
|
params.require(:id)
|
|
Badge.find(params[:id])
|
|
end
|
|
|
|
# Options:
|
|
# :new - reset the badge id to nil before saving
|
|
def update_badge_from_params(badge, opts = {})
|
|
errors = []
|
|
Badge.transaction do
|
|
allowed = Badge.column_names.map(&:to_sym)
|
|
allowed -= [:id, :created_at, :updated_at, :grant_count]
|
|
allowed -= Badge.protected_system_fields if badge.system?
|
|
allowed -= [:query] unless SiteSetting.enable_badge_sql
|
|
|
|
params.permit(*allowed)
|
|
|
|
allowed.each do |key|
|
|
badge.public_send("#{key}=" , params[key]) if params[key]
|
|
end
|
|
|
|
# Badge query contract checks
|
|
begin
|
|
if SiteSetting.enable_badge_sql
|
|
BadgeGranter.contract_checks!(badge.query, target_posts: badge.target_posts, trigger: badge.trigger)
|
|
end
|
|
rescue => e
|
|
errors << e.message
|
|
raise ActiveRecord::Rollback
|
|
end
|
|
|
|
badge.id = nil if opts[:new]
|
|
badge.save!
|
|
end
|
|
|
|
if opts[:new].blank?
|
|
Jobs.enqueue(
|
|
:bulk_user_title_update,
|
|
new_title: badge.name,
|
|
granted_badge_id: badge.id,
|
|
action: Jobs::BulkUserTitleUpdate::UPDATE_ACTION
|
|
)
|
|
end
|
|
|
|
errors
|
|
rescue ActiveRecord::RecordInvalid
|
|
errors.push(*badge.errors.full_messages)
|
|
errors
|
|
end
|
|
end
|