github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 21:57:36 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
dcb0e5f1e5
discourse/app/models
History
Julien Ma dcb0e5f1e5 Fix "Host is invalid" error when TLD >10 chars (#7948) 
Related to https://meta.discourse.org/t/host-is-invalid-error-when-tld-is-longer-than-7-characters/46081.

Using Discourse `v2.4.0.beta2 +119`, I can't add an host (when embedding, cf. `/admin/customize/embedding`) ending with `.engineering`.
Turns out current regex limits to 10 characters.

Fix is dumb: it only allows for up to 24 chars, which is the **current** max TLD length, see https://stackoverflow.com/a/22038535/1907212.

---

Maybe a better (and longer-term) fix would be to allow for up to 64 chars, which I understand comes from the RFC.
I'm not at ease with regexes, so can't be sure about it, but [this suggestion](https://meta.discourse.org/t/host-is-invalid-error-when-tld-is-longer-than-7-characters/46081/8?u=julienma) seems pretty good:

> rules of DNS labels are:
>
> - All labels are 1 to 63 characters, case insensitive A to Z, 0 to 9 and - (hyphen), all from ASCII.
> - No labels may start with a hyphen.
> - No top level domain label may start with a number.
>
>That means a regexp for a valid domain name would look like:
>
>`/^([a-z0-9][a-z0-9-]{0,62}\.)+[a-z][a-z0-9-]{0,62}\.?$/`
>
>Domains that are just a TLD are sufficiently bizarre as to be worth ignoring.
2019-07-26 16:29:48 -04:00
..
concerns FIX: Use correct timezone for manual SQL 2019-07-06 15:14:07 -04:00
reports DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
about.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
admin_dashboard_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
admin_dashboard_general_data.rb FEATURE: Display 'last updated' on dashboard, improve release notes link (#7560) 2019-05-17 15:42:45 +10:00
admin_dashboard_index_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
anonymous_user.rb FEATURE: introduce dedicated storage and DB constraints for anon users 2019-05-29 14:26:24 +10:00
api_key.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
application_request.rb FEATURE: control which web crawlers can access using a whitelist or blacklist 2018-03-22 15:41:02 -04:00
auto_track_duration_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
backup_file.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
backup_location_site_setting.rb DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop (#6717) 2018-12-04 11:48:13 +08:00
backup_metadata.rb FEATURE: Remap uploads during restore when S3 or CDN changes 2019-07-09 14:04:16 +02:00
badge_grouping.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
badge_type.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
badge.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_and_topic_lists.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_custom_field.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_featured_topic.rb FIX: Ensure suppressed categories do not produce any featured topics. (#7863) 2019-07-15 17:32:03 +03:00
category_group.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_list.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_page_style.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_search_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_tag_group.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_tag_stat.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_tag.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
category_user.rb DEV: Correct batch setting of categories 2019-06-25 13:05:43 +10:00
category.rb FIX: Ensure suppressed categories do not produce any featured topics. (#7863) 2019-07-15 17:32:03 +03:00
child_theme.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
color_scheme_color.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
color_scheme.rb FIX: Remove default val for colors step if a default theme has been set. 2019-05-09 17:25:09 +08:00
custom_emoji.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
developer.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
digest_email_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
directory_item.rb FIX user directory time period count (#6586) 2018-11-12 15:30:05 +01:00
discourse_single_sign_on.rb FEATURE: ban any SSO attempts with invalid external id 2019-06-11 10:04:26 +10:00
discourse_version_check.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
draft_sequence.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
draft.rb FIX: Previous annotations were broken 2019-01-11 14:30:19 -05:00
email_change_request.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
email_level_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
email_log.rb DEV: Update annotations 2019-05-13 15:24:24 +01:00
email_token.rb FIX: reload the user record instead of fetching via email 2019-05-13 15:16:53 +05:30
embeddable_host.rb Fix "Host is invalid" error when TLD >10 chars (#7948) 2019-07-26 16:29:48 -04:00
embedding.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
emoji_set_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
emoji.rb FIX: ensures emoji helper is working with custom emojis (#7843) 2019-07-03 09:23:40 +02:00
github_user_info.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
given_daily_like.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
global_setting.rb FEATURE: SKIP_DB_AND_REDIS env var (#7756) 2019-06-13 12:58:27 +10:00
group_archived_message.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group_custom_field.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group_history.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group_manager.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group_mention.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group_request.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group_user.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
group.rb FEATURE: Add "Group owners" to posting options for groups 2019-07-08 17:14:11 -04:00
ignored_user.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
incoming_domain.rb FIX: make frozen string mutable in incoming_domain 2019-05-14 17:44:53 +02:00
incoming_email.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
incoming_link.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
incoming_links_report.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
incoming_referer.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
instagram_user_info.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
invite_redeemer.rb FEATURE: send max 200 emails every minute for bulk invites (#7875) 2019-07-19 11:29:12 +05:30
invite.rb FEATURE: send max 200 emails every minute for bulk invites (#7875) 2019-07-19 11:29:12 +05:30
invited_group.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
javascript_cache.rb FEATURE: Multi-file javascript support for themes (#7526) 2019-06-03 10:41:00 +01:00
like_notification_frequency_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
locale_site_setting.rb FEATURE: English locale with international date formats 2019-05-20 13:47:20 +02:00
mailing_list_mode_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
muted_user.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
new_topic_duration_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
notification_level_when_replying_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
notification.rb DEV: Added commit approved notification type for discourse-code-review 2019-06-11 11:17:23 +10:00
oauth2_user_info.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
onceoff_log.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
optimized_image.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
permalink.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
plugin_store_row.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
plugin_store.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_action_type.rb annotate models 2019-05-29 14:26:24 +10:00
post_action.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_analyzer.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_custom_field.rb DEV: Update annotations 2019-05-13 15:24:24 +01:00
post_detail.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_mover.rb FIX: Update reply count when moving posts 2019-07-22 21:42:24 +02:00
post_reply_key.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_reply.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_revision.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_search_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_stat.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_timing.rb FIX: Use PostgreSQL 'ON CONFLICT' to deal with race condition 2019-04-29 16:34:42 -03:00
post_upload.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post.rb FIX: remove post upload record creation inside 'find_missing_uploads' method. 2019-07-19 01:44:08 +05:30
previous_replies_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
push_subscription.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
quoted_post.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
remote_theme.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
remove_muted_tags_from_latest_site_setting.rb UX: Merge settings related to muted tags. (#7656) 2019-06-03 12:23:23 +10:00
report.rb FIX: include default label when exporting reports 2019-07-26 12:57:13 +05:30
reviewable_claimed_topic.rb DEV: Update annotations 2019-05-13 15:24:24 +01:00
reviewable_flagged_post.rb Move "Hide Post" option up to the top on the review interface 2019-06-26 11:35:59 -04:00
reviewable_history.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
reviewable_priority_setting.rb Use an Enum class for the Reviewable Priority Site Setting 2019-05-24 15:44:24 -04:00
reviewable_queued_post.rb UX: Require a confirmation if approving a post in a closed topic 2019-06-26 12:21:49 -04:00
reviewable_score.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
reviewable_sensitivity_setting.rb make 🤖 happy 2019-05-25 00:32:29 +02:00
reviewable_user.rb Update annotation. 2019-05-24 12:58:26 +08:00
reviewable.rb FIX: Only include pending/agreed scores in the total score 2019-06-26 11:21:35 -04:00
s3_region_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
screened_email.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
screened_ip_address.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
screened_url.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
search_log.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
shared_draft.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
single_sign_on_record.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
site_setting.rb Revert "FEATURE: Use configured quotation marks in fancy topic title" 2019-07-18 11:55:49 +02:00
site.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
skipped_email_log.rb FIX: Don't send notification email when user isn't allowed to see topic 2019-07-01 14:03:03 +02:00
slug_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
stylesheet_cache.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
tag_group_membership.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
tag_group_permission.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
tag_group.rb FEATURE: add support for tag group search 2019-06-27 17:53:26 +10:00
tag_search_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
tag_user.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
tag.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
theme_field.rb DEV: Upgrades to Ember 3.10 (#7871) 2019-07-16 12:45:15 +02:00
theme_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
theme_translation_override.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
theme.rb FIX: Recompile extra_js theme assets when COMPILER_VERSION changes (#7897) 2019-07-16 16:34:33 +02:00
top_lists.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
top_menu_item.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
top_topic.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_allowed_group.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_allowed_user.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_converter.rb FIX: Delete notifications users can't see after moving posts 2019-07-22 19:02:21 +02:00
topic_custom_field.rb annotate models 2019-05-29 14:26:24 +10:00
topic_embed.rb FIX: Frozen string error in TopicEmbed.import (#7938) 2019-07-25 09:21:01 -04:00
topic_featured_users.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_invite.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_link_click.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_link.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_list.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_notifier.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_participants_summary.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_poster.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_posters_summary.rb PERF: speed up topic poster lookups 2019-06-05 18:28:36 +10:00
topic_search_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_tag.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_timer.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_tracking_state.rb Fix modifying frozen strings errors take 3. 2019-05-13 16:45:23 +08:00
topic_user.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic_view_item.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
topic.rb FEATURE: Allow choice of category when making a PM public (#7907) 2019-07-19 11:52:50 -04:00
translation_override.rb FEATURE: English locale with international date formats 2019-05-20 13:47:20 +02:00
trust_level_and_staff_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
trust_level_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
trust_level3_requirements.rb FEATURE: Permit users who had no penalties in last 6 months to be TL3. (#7892) 2019-07-19 12:46:10 +03:00
unsubscribe_key.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
upload.rb FIX: Upload#short_url generates incorrect URL when extension is nil. 2019-06-19 09:10:50 +08:00
user_action.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_api_key.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_archived_message.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_associated_account.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_auth_token_log.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_auth_token.rb PERF: add index on user auth tokens (for user lookups) 2019-04-26 22:38:54 +10:00
user_avatar.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_badge.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_badges.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_custom_field.rb REFACTOR: Replace score bonuses with low/med/high priorities 2019-05-23 11:54:45 -04:00
user_email.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_export.rb REVERT: DEV: should ignore missing post uploads when a user export destroyed 2019-07-25 19:41:25 +05:30
user_field_option.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_field.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_history.rb FIX: logs for enabling/disabling components should show up in the staff actions logs 2019-07-03 12:33:25 +00:00
user_open_id.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_option.rb FEATURE: add support for defer topic functionality 2019-05-31 15:44:35 +10:00
user_profile_view.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_profile.rb FEATURE: Implement Onebox for posts including polls. (#7539) 2019-05-29 17:05:52 +02:00
user_search_data.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_search.rb New: can_see_groups? method for better perf 2019-05-30 08:45:20 +08:00
user_second_factor.rb FEATURE: send max 200 emails every minute for bulk invites (#7875) 2019-07-19 11:29:12 +05:30
user_stat.rb make rubocop happy 2019-04-08 17:03:26 +05:30
user_summary.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_upload.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_visit.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user_warning.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
user.rb FIX: Use default locale for flag reasons 2019-07-12 12:04:23 +02:00
username_validator.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
watched_word.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
web_crawler_request.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
web_hook_event_type.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
web_hook_event.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
web_hook.rb Only show deprecation warning if the webhook is active 2019-06-10 16:23:12 -04:00