mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 13:53:44 +08:00
ddf4ecba04
What is the problem? We were calling out to methods that calls `has_css?` or `has_selector?` which returns a boolean. Since we are not using the return value, it means the methods can be deemed unnecessary. However, we do want those checks and this commit adds the necessarily assertions to make use of the return values.
49 lines
1.4 KiB
Ruby
49 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Chat message onebox", type: :system, js: true do
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:category_channel) }
|
|
|
|
before do
|
|
chat_system_bootstrap
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when sending a message with a link" do
|
|
before do
|
|
SiteSetting.enable_inline_onebox_on_all_domains = true
|
|
|
|
full_onebox_html = <<~HTML.chomp
|
|
<aside class="onebox wikipedia" data-onebox-src="https://en.wikipedia.org/wiki/Hyperlink">
|
|
<article class="onebox-body">
|
|
<p>This is a test</p>
|
|
</article>
|
|
</aside>
|
|
HTML
|
|
Oneboxer
|
|
.stubs(:cached_onebox)
|
|
.with("https://en.wikipedia.org/wiki/Hyperlink")
|
|
.returns(full_onebox_html)
|
|
|
|
stub_request(:get, "https://en.wikipedia.org/wiki/Hyperlink").to_return(
|
|
status: 200,
|
|
body: "<html><head><title>a</title></head></html>",
|
|
)
|
|
end
|
|
|
|
it "is oneboxed" do
|
|
chat_page.visit_channel(channel_1)
|
|
channel_page.send_message(
|
|
"https://en.wikipedia.org/wiki/Hyperlink",
|
|
check_message_presence: false,
|
|
)
|
|
|
|
expect(page).to have_content("This is a test", wait: 20)
|
|
end
|
|
end
|
|
end
|