mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 00:33:44 +08:00
6e161d3e75
The most common thing that we do with fab! is:
fab!(:thing) { Fabricate(:thing) }
This commit adds a shorthand for this which is just simply:
fab!(:thing)
i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
81 lines
2.5 KiB
Ruby
81 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe UserHistory do
|
|
describe "#actions" do
|
|
context "when verifying enum sequence" do
|
|
before { @actions = UserHistory.actions }
|
|
|
|
it "'delete_user' should be at 1st position" do
|
|
expect(@actions[:delete_user]).to eq(1)
|
|
end
|
|
|
|
it "'change_site_text' should be at 29th position" do
|
|
expect(@actions[:change_site_text]).to eq(29)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#staff_action_records" do
|
|
context "with some records" do
|
|
fab!(:admin)
|
|
let(:custom_type) { "confirmed_ham" }
|
|
|
|
before do
|
|
@change_site_setting =
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:change_site_setting],
|
|
subject: "title",
|
|
previous_value: "Old",
|
|
new_value: "New",
|
|
)
|
|
@change_trust_level =
|
|
UserHistory.create!(
|
|
action: UserHistory.actions[:change_trust_level],
|
|
target_user_id: Fabricate(:user).id,
|
|
details: "stuff happened",
|
|
)
|
|
@custom_history = StaffActionLogger.new(admin).log_custom("confirmed_ham", admin_only: true)
|
|
end
|
|
|
|
it "returns all records for admins" do
|
|
records = described_class.staff_action_records(admin).to_a
|
|
expect(records.size).to eq(3)
|
|
end
|
|
|
|
it "doesn't return records to moderators that only admins should see" do
|
|
records = described_class.staff_action_records(Fabricate(:moderator)).to_a
|
|
expect(records).not_to include([@change_site_setting])
|
|
end
|
|
|
|
it "filters by action" do
|
|
records =
|
|
described_class.staff_action_records(
|
|
admin,
|
|
action_id: @change_site_setting.action_before_type_cast,
|
|
).to_a
|
|
expect(records.size).to eq(1)
|
|
expect(records.first).to eq(@change_site_setting)
|
|
end
|
|
|
|
it "filters by action_name" do
|
|
records =
|
|
described_class.staff_action_records(admin, action_name: "change_site_setting").to_a
|
|
expect(records.size).to eq(1)
|
|
expect(records.first).to eq(@change_site_setting)
|
|
end
|
|
|
|
it "Uses action_name as custom_type when searching for custom_staff logs" do
|
|
records =
|
|
described_class.staff_action_records(
|
|
admin,
|
|
action_name: custom_type,
|
|
action_id: described_class.actions[:custom_staff],
|
|
).to_a
|
|
|
|
expect(records.size).to eq(1)
|
|
expect(records.first).to eq(@custom_history)
|
|
end
|
|
end
|
|
end
|
|
end
|