mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 18:46:50 +08:00
9656a21fdb
This feature adds the ability to customize the HTML part of all emails using a custom HTML template and optionally some CSS to style it. The CSS will be parsed and converted into inline styles because CSS is poorly supported by email clients. When writing the custom HTML and CSS, be aware of what email clients support. Keep customizations very simple. Customizations can be added and edited in Admin > Customize > Email Style. Since the summary email is already heavily styled, there is a setting to disable custom styles for summary emails called "apply custom styles to digest" found in Admin > Settings > Email. As part of this work, RTL locales are now rendered correctly for all emails.
123 lines
4.4 KiB
Ruby
123 lines
4.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "rails_helper"
|
|
|
|
describe EmailStyle do
|
|
before do
|
|
SiteSetting.email_custom_template = "<body><h1>FOR YOU</h1><div>%{email_content}</div></body>"
|
|
SiteSetting.email_custom_css = 'h1 { color: red; } div.body { color: #FAB; }'
|
|
end
|
|
|
|
after do
|
|
SiteSetting.remove_override!(:email_custom_template)
|
|
SiteSetting.remove_override!(:email_custom_css)
|
|
end
|
|
|
|
context 'invite' do
|
|
fab!(:invite) { Fabricate(:invite) }
|
|
let(:invite_mail) { InviteMailer.send_invite(invite) }
|
|
|
|
subject(:mail_html) { Email::Renderer.new(invite_mail).html }
|
|
|
|
it 'applies customizations' do
|
|
expect(mail_html.scan('<h1 style="color: red;">FOR YOU</h1>').count).to eq(1)
|
|
expect(mail_html).to match("#{Discourse.base_url}/invites/#{invite.invite_key}")
|
|
end
|
|
|
|
it 'can apply RTL attrs' do
|
|
SiteSetting.default_locale = 'he'
|
|
body_attrs = mail_html.match(/<body ([^>])+/)
|
|
expect(body_attrs[0]&.downcase).to match(/text-align:\s*right/)
|
|
expect(body_attrs[0]&.downcase).to include('dir="rtl"')
|
|
end
|
|
end
|
|
|
|
context 'user_replied' do
|
|
let(:response_by_user) { Fabricate(:user, name: "John Doe") }
|
|
let(:category) { Fabricate(:category, name: 'India') }
|
|
let(:topic) { Fabricate(:topic, category: category, title: "Super cool topic") }
|
|
let(:post) { Fabricate(:post, topic: topic, raw: 'This is My super duper cool topic') }
|
|
let(:response) { Fabricate(:basic_reply, topic: post.topic, user: response_by_user) }
|
|
let(:user) { Fabricate(:user) }
|
|
let(:notification) { Fabricate(:replied_notification, user: user, post: response) }
|
|
|
|
let(:mail) do
|
|
UserNotifications.user_replied(
|
|
user,
|
|
post: response,
|
|
notification_type: notification.notification_type,
|
|
notification_data_hash: notification.data_hash
|
|
)
|
|
end
|
|
|
|
subject(:mail_html) { Email::Renderer.new(mail).html }
|
|
|
|
it "customizations are applied to html part of emails" do
|
|
expect(mail_html.scan('<h1 style="color: red;">FOR YOU</h1>').count).to eq(1)
|
|
matches = mail_html.match(/<div style="([^"]+)">#{post.raw}/)
|
|
expect(matches[1]).to include('color: #FAB;') # custom
|
|
expect(matches[1]).to include('padding-top:5px;') # div.body
|
|
end
|
|
|
|
# TODO: translation override
|
|
end
|
|
|
|
context 'signup' do
|
|
let(:signup_mail) { UserNotifications.signup(Fabricate(:user)) }
|
|
subject(:mail_html) { Email::Renderer.new(signup_mail).html }
|
|
|
|
it "customizations are applied to html part of emails" do
|
|
expect(mail_html.scan('<h1 style="color: red;">FOR YOU</h1>').count).to eq(1)
|
|
expect(mail_html).to include('activate-account')
|
|
end
|
|
|
|
context 'translation override' do
|
|
before do
|
|
TranslationOverride.upsert!(
|
|
'en',
|
|
'user_notifications.signup.text_body_template',
|
|
"CLICK THAT LINK: %{base_url}/u/activate-account/%{email_token}"
|
|
)
|
|
end
|
|
|
|
after do
|
|
TranslationOverride.revert!('en', ['user_notifications.signup.text_body_template'])
|
|
end
|
|
|
|
it "applies customizations when translation override exists" do
|
|
expect(mail_html.scan('<h1 style="color: red;">FOR YOU</h1>').count).to eq(1)
|
|
expect(mail_html.scan('CLICK THAT LINK').count).to eq(1)
|
|
end
|
|
end
|
|
|
|
context 'with some bad css' do
|
|
before do
|
|
SiteSetting.email_custom_css = '@import "nope.css"; h1 {{{ size: really big; '
|
|
end
|
|
|
|
it "can render the html" do
|
|
expect(mail_html.scan(/<h1\s*(?:style=""){0,1}>FOR YOU<\/h1>/).count).to eq(1)
|
|
expect(mail_html).to include('activate-account')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'digest' do
|
|
fab!(:popular_topic) { Fabricate(:topic, user: Fabricate(:coding_horror), created_at: 1.hour.ago) }
|
|
let(:summary_email) { UserNotifications.digest(Fabricate(:user)) }
|
|
subject(:mail_html) { Email::Renderer.new(summary_email).html }
|
|
|
|
it "customizations are applied to html part of emails" do
|
|
expect(mail_html.scan('<h1 style="color: red;">FOR YOU</h1>').count).to eq(1)
|
|
expect(mail_html).to include(popular_topic.title)
|
|
end
|
|
|
|
it "doesn't apply customizations if apply_custom_styles_to_digest is disabled" do
|
|
SiteSetting.apply_custom_styles_to_digest = false
|
|
expect(mail_html).to_not include('<h1 style="color: red;">FOR YOU</h1>')
|
|
expect(mail_html).to_not include('FOR YOU')
|
|
expect(mail_html).to include(popular_topic.title)
|
|
end
|
|
end
|
|
end
|