mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 11:46:18 +08:00
57ea56ee05
We have all these calls to Group.refresh_automatic_groups! littered throughout the tests. Including tests that are seemingly unrelated to groups. This is because automatic group memberships aren't fabricated when making a vanilla user. There are two places where you'd want to use this: You have fabricated a user that needs a certain trust level (which is now based on group membership.) You need the system user to have a certain trust level. In the first case, we can pass refresh_auto_groups: true to the fabricator instead. This is a more lightweight operation that only considers a single user, instead of all users in all groups. The second case is no longer a thing after #25400.
94 lines
3.0 KiB
Ruby
94 lines
3.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe SimilarTopicsController do
|
|
describe "similar_to" do
|
|
let(:title) { "this title is long enough to search for" }
|
|
let(:raw) { "this body is long enough to search for" }
|
|
|
|
let(:topic) { Fabricate(:topic, title: title) }
|
|
let(:post) { Fabricate(:post, topic: topic, raw: raw, post_number: 1) }
|
|
|
|
let(:private_post) { Fabricate(:post, raw: raw, topic: private_topic, post_number: 1) }
|
|
let(:private_topic) do
|
|
Fabricate(
|
|
:topic,
|
|
title: "#{title} 02",
|
|
category: Fabricate(:private_category, group: Group[:staff]),
|
|
)
|
|
end
|
|
|
|
def reindex_posts
|
|
with_search_indexer_enabled { Jobs::ReindexSearch.new.rebuild_posts }
|
|
end
|
|
|
|
it "requires a title param" do
|
|
get "/topics/similar_to.json", params: { raw: raw }
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "returns no results if the title length is below the minimum" do
|
|
SiteSetting.minimum_topics_similar = 0
|
|
SiteSetting.min_title_similar_length = 100
|
|
post
|
|
reindex_posts
|
|
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
expect(response.status).to eq(200)
|
|
json = response.parsed_body
|
|
expect(json["similar_topics"].size).to eq(0)
|
|
end
|
|
|
|
describe "minimum_topics_similar" do
|
|
before { SiteSetting.minimum_topics_similar = 30 }
|
|
|
|
context "with enough topics" do
|
|
it "deletes to Topic.similar_to if there are more topics than `minimum_topics_similar`" do
|
|
Topic.stubs(:count).returns(50)
|
|
post
|
|
reindex_posts
|
|
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
|
|
expect(response.status).to eq(200)
|
|
similar_topics = response.parsed_body["similar_topics"]
|
|
expect(similar_topics.size).to eq(1)
|
|
expect(similar_topics.first["topic_id"]).to eq(topic.id)
|
|
end
|
|
|
|
context "with a logged in user" do
|
|
before do
|
|
private_post
|
|
post
|
|
reindex_posts
|
|
Topic.stubs(:count).returns(50)
|
|
sign_in(Fabricate(:moderator))
|
|
end
|
|
|
|
it "passes a user through if logged in" do
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
|
|
expect(response.status).to eq(200)
|
|
similar_topics =
|
|
response.parsed_body["similar_topics"].map { |topic| topic["topic_id"] }
|
|
expect(similar_topics.size).to eq(2)
|
|
expect(similar_topics).to include(topic.id)
|
|
expect(similar_topics).to include(private_topic.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
it "does not call Topic.similar_to if there are fewer topics than `minimum_topics_similar`" do
|
|
Topic.stubs(:count).returns(10)
|
|
post
|
|
reindex_posts
|
|
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
|
|
expect(response.status).to eq(200)
|
|
json = response.parsed_body
|
|
expect(json["similar_topics"].size).to eq(0)
|
|
end
|
|
end
|
|
end
|
|
end
|