Ted Johansson e74560f062 FIX: Don't mix up action labels between different reviewables (#23365) ... Currently, if the review queue has both a flagged post and a flagged chat message, one of the two will have some of the labels of their actions replaced by those of the other. In other words, the labels are getting mixed up. For example, a flagged chat message might show up with an action labelled "Delete post". This is happening because when using bundles, we are sending along the actions in a separate part of the response, so they can be shared by many reviewables. The bundles then index into this bag of actions by their ID, which is something generic describing the server action, e.g. "agree_and_delete". The problem here is the same action can have different labels depending on the type of reviewable. Now that the bag of actions contains multiple actions with the same ID, which one is chosen is arbitrary. I.e. it doesn't distinguish based on the type of the reviewable. This change adds an additional field to the actions, server_action, which now contains what used to be the ID. Meanwhile, the ID has been turned into a concatenation of the reviewable type and the server action, e.g. post-agree_and_delete. This still provides the upside of denormalizing the actions while allowing for different reviewable types to have different labels and descriptions. At first I thought I would prepend the reviewable type to the ID, but this doesn't work well because the ID is used on the server-side to determine which actions are possible, and these need to be shared between different reviewables. Hence the introduction of server_action, which now serves that purpose. I also thought about changing the way that the bundle indexes into the bag of actions, but this is happening through some EmberJS mechanism, so we don't own that code.		2023-09-06 10:57:30 +08:00
..
about_spec.rb	DEV: Move about_stat_groups to DiscoursePluginRegistry (#20496)	2023-03-02 08:10:16 +10:00
admin_dashboard_data_spec.rb	FEATURE: Add admin dashboard warning for legacy navigation menu (#22655)	2023-07-18 09:41:38 +08:00
api_key_scope_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
api_key_spec.rb	DEV: Set a limit for ApiKey#description (#21502)	2023-05-15 14:12:25 +10:00
application_request_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
associated_group_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
badge_grouping_spec.rb	DEV: Set limits for text fields on BadgeGrouping	2023-05-15 09:54:54 +02:00
badge_spec.rb	FEATURE: reduce avatar sizes to 6 from 20 (#21319)	2023-06-01 10:00:01 +10:00
badge_type_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
bookmark_spec.rb	DEV: Change Bookmarkable registration to DiscoursePluginRegistry (#20556)	2023-03-08 10:39:12 +10:00
category_featured_topic_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
category_group_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
category_list_spec.rb	FIX: error when CategoryList tried to find relevant topics (#22339)	2023-06-29 11:25:58 +10:00
category_setting_spec.rb	FEATURE: Configurable auto-bump cooldown (#20507)	2023-03-10 13:45:01 +08:00
category_spec.rb	DEV: Remove enable_experimental_hashtag_autocomplete logic (#22820)	2023-08-08 11:18:55 +10:00
category_tag_stat_spec.rb	FIX: Update category tag stats with new or deleted (#21531)	2023-05-18 12:46:44 +03:00
category_user_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
child_theme_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
color_scheme_color_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
color_scheme_spec.rb	FIX: Ensure ColorScheme#resolve falls back to base for missing color (#20186)	2023-02-06 18:24:12 +00:00
developer_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
digest_email_site_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
directory_item_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
discourse_connect_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
do_not_disturb_timing_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
draft_sequence_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
draft_spec.rb	DEV: Delete upload references upon deleting draft (#22851)	2023-07-31 10:16:23 +08:00
email_change_request_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
email_log_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
email_token_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
embeddable_host_spec.rb	SECURITY: Remove bypass for base_url (#19995)	2023-01-25 13:50:45 +02:00
emoji_spec.rb	FEATURE: Add an emoji deny list site setting (#20929)	2023-04-13 15:38:54 +08:00
form_template_spec.rb	FEATURE: support to initial values for form templates through /new-topic (#23313)	2023-08-29 18:41:33 -03:00
given_daily_like_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
global_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
group_archived_message_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
group_associated_group_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
group_history_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
group_request_spec.rb	DEV: Bump the limits on group request text fields	2023-05-24 09:57:46 +02:00
group_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
group_user_spec.rb	FIX: recalculating trust levels was not working (#20492)	2023-03-01 15:35:21 +11:00
incoming_link_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
incoming_links_report_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
invite_redeemer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
invite_spec.rb	DEV: Remove Discourse.redis.delete_prefixed (#22103)	2023-06-16 12:44:35 +10:00
javascript_cache_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
locale_site_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
mailing_list_mode_site_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
notification_spec.rb	DEV: Remove unread_private_messages and deprecation (#22893)	2023-08-01 14:44:39 +10:00
optimized_image_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
permalink_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
plugin_store_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_action_spec.rb	FEATURE: add group filter for admin reports (#23381)	2023-09-05 11:17:18 +05:30
post_action_type_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_analyzer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_detail_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
post_mover_spec.rb	FIX: keep first post edit history when moving/merging (#22966)	2023-08-03 22:04:35 -03:00
post_reply_key_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_reply_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_revision_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
post_spec.rb	FEATURE: Secure uploads in PMs only (#23398)	2023-09-06 09:39:09 +10:00
post_timing_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
private_message_topic_tracking_state_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
published_page_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
quoted_post_spec.rb	DEV: Fix a flaky quote post spec (#22891)	2023-08-01 00:48:40 +02:00
remote_theme_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
report_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
reviewable_claimed_topic_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
reviewable_flagged_post_spec.rb	UX/DEV: Review queue redesign fixes (#20239)	2023-03-02 16:40:53 +01:00
reviewable_history_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
reviewable_post_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
reviewable_queued_post_spec.rb	FIX: Keep ReviewableQueuedPosts even with user delete reviewable actions (#22501)	2023-07-18 11:50:31 +00:00
reviewable_score_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
reviewable_spec.rb	DEV: Set limits for text fields in reviewables	2023-05-03 09:54:54 +02:00
reviewable_user_spec.rb	FIX: Don't mix up action labels between different reviewables (#23365)	2023-09-06 10:57:30 +08:00
s3_region_site_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
screened_email_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
screened_ip_address_spec.rb	DEV: find_each in CSV exports (#22573)	2023-08-17 12:33:52 +10:00
screened_url_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
search_log_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
sidebar_section_link_spec.rb	FIX: public sidebar sections belong to system user (#20972)	2023-04-05 10:52:18 +10:00
sidebar_section_spec.rb	FIX: rename everything link to topics (#22076)	2023-06-15 11:36:38 +10:00
sidebar_url_spec.rb	FIX: increase sidebar URL limit to 1000 (#23120)	2023-08-17 14:46:24 +10:00
site_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
site_spec.rb	DEV: Added modifier hooks to allow plugins to tweak how categories and groups are fetched (#21837)	2023-05-30 18:41:50 -03:00
sitemap_spec.rb	DEV: Fix random typos (#22078)	2023-06-13 22:02:21 +02:00
skipped_email_log_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
stylesheet_cache_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
tag_group_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
tag_spec.rb	UX: support links in tag descriptions (#22994)	2023-08-16 11:43:54 -04:00
tag_user_spec.rb	FEATURE: new watched_precedence_over_muted setting (#22252)	2023-06-27 14:49:34 +10:00
theme_field_spec.rb	DEV: Enable ember-this-fallback in themes (#23384)	2023-09-05 11:16:12 +02:00
theme_modifier_set_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
theme_spec.rb	Revert "Revert "PERF: Cache each theme field value once (#23192)" (#23354)" (#23356)	2023-08-31 14:12:03 -05:00
theme_svg_sprite_spec.rb	DEV: Store theme sprites in the DB (#20501)	2023-03-14 13:11:45 -05:00
top_menu_item_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
top_topic_spec.rb	DEV: Replace #pluck_first freedom patch with AR #pick in core (#19893)	2023-02-13 12:39:45 +08:00
topic_allowed_user_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
topic_converter_spec.rb	DEV: Fix random typos (#22078)	2023-06-13 22:02:21 +02:00
topic_embed_spec.rb	SECURITY: Use canonical url for topic embeddings (#22085)	2023-06-13 11:08:08 -06:00
topic_featured_users_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_group_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_invite_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_link_click_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_link_spec.rb	DEV: Replace #pluck_first freedom patch with AR #pick in core (#19893)	2023-02-13 12:39:45 +08:00
topic_list_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_participant_groups_summary_spec.rb	FEATURE: display PM participant group names in the topics list. (#21677)	2023-05-31 19:32:06 +05:30
topic_participants_summary_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_posters_summary_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_spec.rb	FEATURE: add group filter for admin reports (#23381)	2023-09-05 11:17:18 +05:30
topic_tag_spec.rb	SECURITY: Default tags to show count of topics in unrestricted categories (#19916)	2023-01-20 09:50:24 +08:00
topic_thumbnail_spec.rb	DEV: Fix random typos (#22078)	2023-06-13 22:02:21 +02:00
topic_timer_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_tracking_state_spec.rb	FIX: Dismissing unread posts did not publish changes to other clients (#22584)	2023-07-13 18:05:56 +08:00
topic_user_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
topic_view_item_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
translation_override_spec.rb	FIX: Don't show admin warnings about deleted translation overrides (#22614)	2023-07-14 16:52:39 +08:00
trust_level_and_staff_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
trust_level_setting_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
trust_level3_requirements_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
unsubscribe_key_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
upload_reference_spec.rb	DEV: Fix random typos (#22078)	2023-06-13 22:02:21 +02:00
upload_spec.rb	FEATURE: Secure uploads in PMs only (#23398)	2023-09-06 09:39:09 +10:00
user_action_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_api_key_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_archived_message_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_associated_group_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
user_auth_token_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_avatar_spec.rb	FEATURE: reduce avatar sizes to 6 from 20 (#21319)	2023-06-01 10:00:01 +10:00
user_badge_spec.rb	FEATURE: Add support for user badge revocation webhook events (#21204)	2023-04-24 20:36:40 +00:00
user_bookmark_list_spec.rb	SECURITY: Impose a upper bound on limit params in various controllers	2023-07-28 12:53:46 +01:00
user_email_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_export_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_field_spec.rb	DEV: Update the rubocop-discourse gem	2023-06-26 11:41:52 +02:00
user_history_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_notification_schedule_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_option_spec.rb	FEATURE: Add default site settings to control the defaults of navigation menu preferences (#22485)	2023-07-07 04:52:10 +03:00
user_profile_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_profile_view_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_search_spec.rb	FIX: only show approved users in search_user results when site setting enabled (#20493)	2023-03-01 12:23:29 +08:00
user_second_factor_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_spec.rb	DEV: Remove unread_private_messages and deprecation (#22893)	2023-08-01 14:44:39 +10:00
user_stat_spec.rb	FIX: Keep ReviewableQueuedPosts even with user delete reviewable actions (#22501)	2023-07-18 11:50:31 +00:00
user_status_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_summary_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
user_visit_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
username_validator_spec.rb	DEV: Make sure max_username_length is within MAX_USERNAME_LENGTH_RANGE (#23104)	2023-08-15 12:12:22 -03:00
watched_word_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
web_crawler_request_spec.rb	DEV: stop leaking data into tables during test (#21403)	2023-05-06 07:15:33 +10:00
web_hook_event_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
web_hook_spec.rb	FEATURE: add topic voting webhook event type (#23072)	2023-08-11 13:42:28 -03:00