mirror of
https://github.com/discourse/discourse.git
synced 2024-12-02 06:54:15 +08:00
71391cd40d
When chat is enabled, there's a scheduled job that runs every 5 minutes to check whether we need to send a "chat summary" email to users with unread chat messages or mentions. On Discourse with a large number of users, the query used wasn't optimal and sometimes taking minutes. Which isn't good when the query is called every 5 minutes 😬 This PR reworks the query in `Chat::Mailer.send_unread_mentions_summary`. Instead of starting from the `users` table, it starts from the `user_chat_channel_memberships` table which is the main piece tying everything together. The new query is mostly similar to the previous one, with some bug fixes (like ensuring the user has `allow_private_messages` enabled for direct messages) and is also slightly simpler since it doesn't keep track of the `memberships_with_unread_messages` anymore. That part has been moved to the `user_notifications.chat_summary` email method. The `UserEmailExtension` has been deleted since that was using to N+1 update the `user_chat_channel_memberships.last_unread_mention_when_emailed_it`(quite a mouthful 😛) but that's now done directly in the `user_notifications.chat_summary` email method. The "plat de résistance" of that PR - the `user_notifications.chat_summary` method has been re-worked for improved performances 🚀 Instead of doing everything in one query, it does 4 tiny ones. - One to retrieve the list of unread mentions (@something) in "category" channels - One to retrieve the list of unread messages in "direct message" channels (aka. 1-1 and group discussions) - One to load all the chat messages for each "category" channels from the last unread mention - One to load all the chat messages for each "direct message" channels from the last unread message All the specs for both `Chat::Mailer` and `UserNotification.chat_summary` have been rewriten for easier comprehension and faster execution (mostly by not using chat services which makes the specs go 10x slower...) Internal ref - t/129848 |
||
|---|---|---|
| .. | ||
| client.ar.yml | ||
| client.be.yml | ||
| client.bg.yml | ||
| client.bs_BA.yml | ||
| client.ca.yml | ||
| client.cs.yml | ||
| client.da.yml | ||
| client.de.yml | ||
| client.el.yml | ||
| client.en_GB.yml | ||
| client.en.yml | ||
| client.es.yml | ||
| client.et.yml | ||
| client.fa_IR.yml | ||
| client.fi.yml | ||
| client.fr.yml | ||
| client.gl.yml | ||
| client.he.yml | ||
| client.hr.yml | ||
| client.hu.yml | ||
| client.hy.yml | ||
| client.id.yml | ||
| client.it.yml | ||
| client.ja.yml | ||
| client.ko.yml | ||
| client.lt.yml | ||
| client.lv.yml | ||
| client.nb_NO.yml | ||
| client.nl.yml | ||
| client.pl_PL.yml | ||
| client.pt_BR.yml | ||
| client.pt.yml | ||
| client.ro.yml | ||
| client.ru.yml | ||
| client.sk.yml | ||
| client.sl.yml | ||
| client.sq.yml | ||
| client.sr.yml | ||
| client.sv.yml | ||
| client.sw.yml | ||
| client.te.yml | ||
| client.th.yml | ||
| client.tr_TR.yml | ||
| client.ug.yml | ||
| client.uk.yml | ||
| client.ur.yml | ||
| client.vi.yml | ||
| client.zh_CN.yml | ||
| client.zh_TW.yml | ||
| server.ar.yml | ||
| server.be.yml | ||
| server.bg.yml | ||
| server.bs_BA.yml | ||
| server.ca.yml | ||
| server.cs.yml | ||
| server.da.yml | ||
| server.de.yml | ||
| server.el.yml | ||
| server.en_GB.yml | ||
| server.en.yml | ||
| server.es.yml | ||
| server.et.yml | ||
| server.fa_IR.yml | ||
| server.fi.yml | ||
| server.fr.yml | ||
| server.gl.yml | ||
| server.he.yml | ||
| server.hr.yml | ||
| server.hu.yml | ||
| server.hy.yml | ||
| server.id.yml | ||
| server.it.yml | ||
| server.ja.yml | ||
| server.ko.yml | ||
| server.lt.yml | ||
| server.lv.yml | ||
| server.nb_NO.yml | ||
| server.nl.yml | ||
| server.pl_PL.yml | ||
| server.pt_BR.yml | ||
| server.pt.yml | ||
| server.ro.yml | ||
| server.ru.yml | ||
| server.sk.yml | ||
| server.sl.yml | ||
| server.sq.yml | ||
| server.sr.yml | ||
| server.sv.yml | ||
| server.sw.yml | ||
| server.te.yml | ||
| server.th.yml | ||
| server.tr_TR.yml | ||
| server.ug.yml | ||
| server.uk.yml | ||
| server.ur.yml | ||
| server.vi.yml | ||
| server.zh_CN.yml | ||
| server.zh_TW.yml | ||