github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 02:50:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
ed0e4582a1
discourse/script/import_scripts
History
Blake Erickson ed0e4582a1
DEV: If disabled do not change setting after import (#12142) 
When running an import script there are many site settings that are
changed but we reset them back to where they were originally before the
import. However, there are two settings that we don't roll back:

```
purge_unactivated_users_grace_period_days
purge_deleted_uploads_grace_period_days
```

which could have some unintended consequences.

My first question is do we *really* have to change these settings? I'm
not a huge fan of changing someones settings without them really knowing
they were changed.

If we really do have to change these settings here is my proposed PR
where we don't alter the `purge_unactivated_users_grace_period_days` if
it has been disabled.

As I'm writing this another change we could make is that we don't change
either of these site settings if we detect that they aren't set to the
default values.

The drive behind this PR is that there is a discourse instance which
relies on staged users as part of their workflow and this setting was
changed by accident via the import script causing users to be deleted
that shouldn't have been.
2021-02-19 09:33:35 -07:00
..
base Improvements to phpBB3 import script (#10999) 2021-01-14 21:44:43 +02:00
mbox DEV: stop freezing frozen strings 2020-04-30 16:48:53 +10:00
nodebb DEV: Make Rubocop happy 2019-08-12 23:10:58 +02:00
phpbb3 Improvements to phpBB3 import script (#10999) 2021-01-14 21:44:43 +02:00
quandora DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
settings FEATURE: Import script for jForum 2020-06-21 12:12:42 +02:00
socialcast DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
support DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
answerbase.rb Make import scripts work with frozen strings 2019-05-30 22:22:24 +02:00
answerhub.rb DEV: Improvements to AnswerHub import script. 2019-06-13 11:46:17 +05:30
askbot.rb Make import scripts work with frozen strings 2019-05-30 22:22:24 +02:00
base.rb DEV: If disabled do not change setting after import (#12142) 2021-02-19 09:33:35 -07:00
bbpress.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
bespoke_1.rb Make import scripts work with frozen strings 2019-05-30 22:22:24 +02:00
discuz_x.rb DEV: update rubocop to version 0.77 2019-12-10 11:48:39 +11:00
disqus.rb DEV: Apply Rubocop redundant return style 2019-11-14 15:10:51 -05:00
drupal_json.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
drupal_qa.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
drupal-6.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
drupal.rb DEV: Improvements to Drupal script (#10016) 2020-06-10 10:59:17 -05:00
fluxbb.rb Fix syntax error in fluxbb.rb (#9727) 2020-05-11 11:07:57 -04:00
friendsmegplus.rb FIX: use allowlist and blocklist terminology (#10209) 2020-07-27 10:23:54 +10:00
getsatisfaction.rb DEV: couple bug fixes in getsatisfaction importer 2020-07-06 17:41:28 +02:00
google_groups.rb FIX: Google groups import changed login URL (#9432) 2020-04-15 16:45:14 -04:00
ipboard.rb FIX: Replace deprecated URI.encode, URI.escape, URI.unescape and URI.unencode (#8528) 2019-12-12 12:49:21 +10:00
ipboard3.rb FEATURE: Nokogumbo (#9577) 2020-05-05 13:46:57 +10:00
jforum.rb DEV: Update rubocop-discourse from 2.3.2 to 2.4.0 (#11079) 2020-10-30 15:04:29 +01:00
jive_api.rb FEATURE: Nokogumbo (#9577) 2020-05-05 13:46:57 +10:00
jive.rb FEATURE: Nokogumbo (#9577) 2020-05-05 13:46:57 +10:00
json_generic.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
kunena.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
kunena3.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
lithium.rb FEATURE: Nokogumbo (#9577) 2020-05-05 13:46:57 +10:00
mbox.rb DEV: Improve mbox import script 2020-03-14 00:00:36 +01:00
modx.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
muut.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
mybb.rb DEV: update rubocop to version 0.77 2019-12-10 11:48:39 +11:00
mybbru.rb FEATURE: add mybb.ru import script (#8609) 2019-12-20 11:10:18 -05:00
mylittleforum.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
nabble.rb Make import scripts work with frozen strings 2019-05-30 22:22:24 +02:00
ning.rb DEV: update rubocop to version 0.77 2019-12-10 11:48:39 +11:00
phorum.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
phpbb3.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
punbb.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
question2answer.rb DEV: Improve q2a import script (#10346) 2020-07-31 12:04:03 -05:00
sfn.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
simplepress.rb fix invalid byte sequence in UTF-8 (ArgumentError) (#9077) 2020-02-28 10:26:18 -05:00
smf1.rb FIX: use allowlist and blocklist terminology (#10209) 2020-07-27 10:23:54 +10:00
smf2.rb FIX: Missing constant in SMF2 importer (#9178) 2020-03-11 10:19:59 -05:00
sourceforge.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
stack_overflow.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
telligent.rb Improve Telligent import script 2020-04-03 18:10:52 +02:00
vanilla_body_parser.rb Improve Vanilla import script. (#11701) 2021-01-13 23:10:00 +05:30
vanilla_mysql.rb Improve Vanilla import script. (#11701) 2021-01-13 23:10:00 +05:30
vanilla.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
vbulletin.rb fix vbulletin importer to hide soft-deleted posts (#12057) 2021-02-12 14:29:05 +01:00
vbulletin5.rb fix vbulletin importer to hide soft-deleted posts (#12057) 2021-02-12 14:29:05 +01:00
xenforo.rb Improve XenForo import script. 2019-06-18 15:52:34 +05:30
yahoogroup.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
zendesk_api.rb Import avatars and likes in the Zendesk AP importer 2019-08-14 10:42:52 +02:00
zendesk.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
zoho.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00