mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 15:04:59 +08:00
25a226279a
The #pluck_first freedom patch, first introduced by @danielwaterworth has served us well, and is used widely throughout both core and plugins. It seems to have been a common enough use case that Rails 6 introduced it's own method #pick with the exact same implementation. This allows us to retire the freedom patch and switch over to the built-in ActiveRecord method. There is no replacement for #pluck_first!, but a quick search shows we are using this in a very limited capacity, and in some cases incorrectly (by assuming a nil return rather than an exception), which can quite easily be replaced with #pick plus some extra handling. |
||
|---|---|---|
| .. | ||
| application_helper_spec.rb | ||
| redis_snapshot_helper.rb | ||
| topics_helper_spec.rb | ||
| user_notifications_helper_spec.rb | ||