discourse/lib/scheduler/defer.rb
Sam 2b8d4508e5 PERF: stop running background work between requests
Use a dedicated thread to run Scheduler::Defer

This avoids blocking of a worker during operations that require waiting.

In particular uploads risked blocking a unicorn.

This also add a queue "length" that discourse prometheus consumes.
2017-11-23 15:48:47 +11:00

91 lines
1.8 KiB
Ruby

module Scheduler
module Deferrable
def initialize
@async = !Rails.env.test?
@queue = Queue.new
@mutex = Mutex.new
@paused = false
@thread = nil
end
def length
@queue.length
end
def pause
stop!
@paused = true
end
def resume
@paused = false
end
# for test
def async=(val)
@async = val
end
def later(desc = nil, db = RailsMultisite::ConnectionManagement.current_db, &blk)
if @async
start_thread unless (@thread && @thread.alive?) || @paused
@queue << [db, blk, desc]
else
blk.call
end
end
def stop!
@thread.kill if @thread && @thread.alive?
@thread = nil
end
# test only
def stopped?
!(@thread && @thread.alive?)
end
def do_all_work
while !@queue.empty?
do_work(_non_block = true)
end
end
private
def start_thread
@mutex.synchronize do
return if @thread && @thread.alive?
@thread = Thread.new {
while true
do_work
end
}
end
end
# using non_block to match Ruby #deq
def do_work(non_block = false)
db, job, desc = @queue.deq(non_block)
db ||= RailsMultisite::ConnectionManagement::DEFAULT
RailsMultisite::ConnectionManagement.with_connection(db) do
begin
job.call
rescue => ex
Discourse.handle_job_exception(ex, message: "Running deferred code '#{desc}'")
end
end
rescue => ex
Discourse.handle_job_exception(ex, message: "Processing deferred code queue")
ensure
ActiveRecord::Base.connection_handler.clear_active_connections!
end
end
class Defer
extend Deferrable
initialize
end
end