mirror of
https://github.com/discourse/discourse.git
synced 2024-12-15 20:03:44 +08:00
f0072dd897
Meta report: https://meta.discourse.org/t/excessive-requests-to-uploads-lookup-urls-leading-to-429-response/143119 * The data-orig-src attribute was not being removed from cooked video and audio so the composer was infinitely trying to get the URLs for them, which would never resolve to anything * Also the code that retrieved the short URL was unscoped, and was getting everything on the page. if running from the composer we now scope to the preview window * Also fixed a minor issue where the element href for the video and audio tags was not being set when the short URL was found
144 lines
3.8 KiB
JavaScript
144 lines
3.8 KiB
JavaScript
import { debounce } from "@ember/runloop";
|
|
import { ATTACHMENT_CSS_CLASS } from "./engines/discourse-markdown-it";
|
|
let _cache = {};
|
|
|
|
export function lookupCachedUploadUrl(shortUrl) {
|
|
return _cache[shortUrl] || {};
|
|
}
|
|
|
|
const MISSING = "missing";
|
|
|
|
export function lookupUncachedUploadUrls(urls, ajax) {
|
|
urls = _.compact(urls);
|
|
if (urls.length === 0) {
|
|
return;
|
|
}
|
|
|
|
return ajax("/uploads/lookup-urls", {
|
|
method: "POST",
|
|
data: { short_urls: urls }
|
|
}).then(uploads => {
|
|
uploads.forEach(upload => {
|
|
cacheShortUploadUrl(upload.short_url, {
|
|
url: upload.url,
|
|
short_path: upload.short_path
|
|
});
|
|
});
|
|
|
|
urls.forEach(url =>
|
|
cacheShortUploadUrl(url, {
|
|
url: lookupCachedUploadUrl(url).url || MISSING,
|
|
short_path: lookupCachedUploadUrl(url).short_path || MISSING
|
|
})
|
|
);
|
|
|
|
return uploads;
|
|
});
|
|
}
|
|
|
|
export function cacheShortUploadUrl(shortUrl, value) {
|
|
_cache[shortUrl] = value;
|
|
}
|
|
|
|
export function resetCache() {
|
|
_cache = {};
|
|
}
|
|
|
|
function retrieveCachedUrl($upload, dataAttribute, callback) {
|
|
const cachedUpload = lookupCachedUploadUrl($upload.data(dataAttribute));
|
|
const url =
|
|
dataAttribute === "orig-href" ? cachedUpload.short_path : cachedUpload.url;
|
|
|
|
if (url) {
|
|
$upload.removeAttr(`data-${dataAttribute}`);
|
|
if (url !== MISSING) {
|
|
callback(url);
|
|
}
|
|
}
|
|
}
|
|
|
|
function _loadCachedShortUrls($uploads) {
|
|
$uploads.each((_idx, upload) => {
|
|
const $upload = $(upload);
|
|
switch (upload.tagName) {
|
|
case "A":
|
|
retrieveCachedUrl($upload, "orig-href", url => {
|
|
$upload.attr("href", url);
|
|
|
|
// Replace "|attachment" with class='attachment'
|
|
// TODO: This is a part of the cooking process now and should be
|
|
// removed in the future.
|
|
const content = $upload.text().split("|");
|
|
if (content[1] === ATTACHMENT_CSS_CLASS) {
|
|
$upload.addClass(ATTACHMENT_CSS_CLASS);
|
|
$upload.text(content[0]);
|
|
}
|
|
});
|
|
|
|
break;
|
|
case "IMG":
|
|
retrieveCachedUrl($upload, "orig-src", url => {
|
|
$upload.attr("src", url);
|
|
});
|
|
|
|
break;
|
|
case "SOURCE": // video/audio tag > source tag
|
|
retrieveCachedUrl($upload, "orig-src", url => {
|
|
$upload.attr("src", url);
|
|
|
|
if (url.startsWith(`//${window.location.host}`)) {
|
|
let hostRegex = new RegExp("//" + window.location.host, "g");
|
|
url = url.replace(hostRegex, "");
|
|
}
|
|
let fullUrl = window.location.origin + url;
|
|
$upload.attr("src", fullUrl);
|
|
|
|
// this is necessary, otherwise because of the src change the
|
|
// video/audio just doesn't bother loading!
|
|
let $parent = $upload.parent();
|
|
$parent[0].load();
|
|
|
|
// set the url and text for the <a> tag within the <video/audio> tag
|
|
$parent
|
|
.find("a")
|
|
.attr("href", fullUrl)
|
|
.text(fullUrl);
|
|
});
|
|
|
|
break;
|
|
}
|
|
});
|
|
}
|
|
|
|
function _loadShortUrls($uploads, ajax) {
|
|
let urls = $uploads.toArray().map(upload => {
|
|
const $upload = $(upload);
|
|
return $upload.data("orig-src") || $upload.data("orig-href");
|
|
});
|
|
|
|
return lookupUncachedUploadUrls(urls, ajax).then(() =>
|
|
_loadCachedShortUrls($uploads)
|
|
);
|
|
}
|
|
|
|
export function resolveAllShortUrls(ajax, scope = null) {
|
|
const attributes =
|
|
"img[data-orig-src], a[data-orig-href], source[data-orig-src]";
|
|
let $shortUploadUrls = $(scope || document).find(attributes);
|
|
|
|
if ($shortUploadUrls.length > 0) {
|
|
_loadCachedShortUrls($shortUploadUrls);
|
|
|
|
$shortUploadUrls = $(scope || document).find(attributes);
|
|
if ($shortUploadUrls.length > 0) {
|
|
// this is carefully batched so we can do a leading debounce (trigger right away)
|
|
return debounce(
|
|
null,
|
|
() => _loadShortUrls($shortUploadUrls, ajax),
|
|
450,
|
|
true
|
|
);
|
|
}
|
|
}
|
|
}
|