mirror of
https://github.com/discourse/discourse.git
synced 2024-12-15 10:03:42 +08:00
824c3420e9
Previously we depended on non Sidekiq specific mocking which is not the official way of testing Sidekiq, this made these tests very fragile New testing is more robust and complete
157 lines
4.5 KiB
Ruby
157 lines
4.5 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'jobs/base'
|
|
|
|
describe Jobs do
|
|
|
|
describe 'enqueue' do
|
|
|
|
describe 'when queue_jobs is true' do
|
|
before do
|
|
SiteSetting.expects(:queue_jobs?).at_least_once.returns(true)
|
|
end
|
|
|
|
it 'enqueues a job in sidekiq' do
|
|
Sidekiq::Testing.fake! do
|
|
jobs = Jobs::ProcessPost.jobs
|
|
|
|
jobs.clear
|
|
Jobs.enqueue(:process_post, post_id: 1)
|
|
expect(jobs.length).to eq(1)
|
|
job = jobs.first
|
|
|
|
expected = {
|
|
"class" => "Jobs::ProcessPost",
|
|
"args" => [{ "post_id" => 1, "current_site_id" => "default" }],
|
|
"queue" => "default"
|
|
}
|
|
expect(job.slice("class", "args", "queue")).to eq(expected)
|
|
end
|
|
end
|
|
|
|
it "does not pass current_site_id when 'all_sites' is present" do
|
|
Sidekiq::Testing.fake! do
|
|
jobs = Jobs::ProcessPost.jobs
|
|
|
|
jobs.clear
|
|
Jobs.enqueue(:process_post, post_id: 1, all_sites: true)
|
|
|
|
expect(jobs.length).to eq(1)
|
|
job = jobs.first
|
|
|
|
expected = {
|
|
"class" => "Jobs::ProcessPost",
|
|
"args" => [{ "post_id" => 1 }],
|
|
"queue" => "default"
|
|
}
|
|
expect(job.slice("class", "args", "queue")).to eq(expected)
|
|
end
|
|
end
|
|
|
|
it "doesn't execute the job" do
|
|
Sidekiq::Client.stubs(:enqueue)
|
|
Jobs::ProcessPost.any_instance.expects(:perform).never
|
|
Jobs.enqueue(:process_post, post_id: 1)
|
|
end
|
|
|
|
it "should enqueue with the correct database id when the current_site_id option is given" do
|
|
|
|
Sidekiq::Testing.fake! do
|
|
jobs = Jobs::ProcessPost.jobs
|
|
|
|
jobs.clear
|
|
Jobs.enqueue(:process_post, post_id: 1, current_site_id: 'test_db')
|
|
|
|
expect(jobs.length).to eq(1)
|
|
job = jobs.first
|
|
|
|
expected = {
|
|
"class" => "Jobs::ProcessPost",
|
|
"args" => [{ "post_id" => 1, "current_site_id" => "test_db" }],
|
|
"queue" => "default"
|
|
}
|
|
expect(job.slice("class", "args", "queue")).to eq(expected)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'when queue_jobs is false' do
|
|
before do
|
|
SiteSetting.expects(:queue_jobs?).at_least_once.returns(false)
|
|
end
|
|
|
|
it "doesn't enqueue in sidekiq" do
|
|
Sidekiq::Client.expects(:enqueue).with(Jobs::ProcessPost, {}).never
|
|
Jobs.enqueue(:process_post, post_id: 1)
|
|
end
|
|
|
|
it "executes the job right away" do
|
|
Jobs::ProcessPost.any_instance.expects(:perform).with(post_id: 1, sync_exec: true, current_site_id: "default")
|
|
Jobs.enqueue(:process_post, post_id: 1)
|
|
end
|
|
|
|
context 'and current_site_id option is given and does not match the current connection' do
|
|
before do
|
|
Sidekiq::Client.stubs(:enqueue)
|
|
Jobs::ProcessPost.any_instance.stubs(:execute).returns(true)
|
|
end
|
|
|
|
it 'should raise an exception' do
|
|
Jobs::ProcessPost.any_instance.expects(:execute).never
|
|
RailsMultisite::ConnectionManagement.expects(:establish_connection).never
|
|
|
|
expect {
|
|
Jobs.enqueue(:process_post, post_id: 1, current_site_id: 'test_db')
|
|
}.to raise_error(ArgumentError)
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
describe 'cancel_scheduled_job' do
|
|
let(:scheduled_jobs) { Sidekiq::ScheduledSet.new }
|
|
|
|
after do
|
|
scheduled_jobs.clear
|
|
end
|
|
|
|
it 'deletes the matching job' do
|
|
Sidekiq::Testing.disable! do
|
|
scheduled_jobs.clear
|
|
expect(scheduled_jobs.size).to eq(0)
|
|
|
|
Jobs.enqueue_in(1.year, :run_heartbeat, topic_id: 123)
|
|
Jobs.enqueue_in(2.years, :run_heartbeat, topic_id: 456)
|
|
Jobs.enqueue_in(3.years, :run_heartbeat, topic_id: 123, current_site_id: 'foo')
|
|
Jobs.enqueue_in(4.years, :run_heartbeat, topic_id: 123, current_site_id: 'bar')
|
|
|
|
expect(scheduled_jobs.size).to eq(4)
|
|
|
|
Jobs.cancel_scheduled_job(:run_heartbeat, topic_id: 123)
|
|
|
|
expect(scheduled_jobs.size).to eq(3)
|
|
|
|
Jobs.cancel_scheduled_job(:run_heartbeat, topic_id: 123, all_sites: true)
|
|
|
|
expect(scheduled_jobs.size).to eq(1)
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
describe 'enqueue_at' do
|
|
it 'calls enqueue_in for you' do
|
|
freeze_time
|
|
Jobs.expects(:enqueue_in).with(3 * 60 * 60, :eat_lunch, {}).returns(true)
|
|
Jobs.enqueue_at(3.hours.from_now, :eat_lunch, {})
|
|
end
|
|
|
|
it 'handles datetimes that are in the past' do
|
|
freeze_time
|
|
Jobs.expects(:enqueue_in).with(0, :eat_lunch, {}).returns(true)
|
|
Jobs.enqueue_at(3.hours.ago, :eat_lunch, {})
|
|
end
|
|
end
|
|
|
|
end
|