mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 06:33:38 +08:00
9fea43e46a
`FileUtils.cd` and `Dir.chdir` cause the working directory to change for the entire process. We run sidekiq jobs, hijacked requests and deferred jobs in threads, which can make working directory changes have unintended side-effects. - Add a rubocop rule to warn about usage of Dir.chdir and FileUtils.cd - Added rubocop:disable for scripts used outside the app - Refactored code using cd to use alternative methods - Temporarily skipped the rubocop check for lib/backup_restore. This will require more complex refactoring, so I will create a separate PR for review
82 lines
1.9 KiB
Ruby
82 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "autospec/rspec_runner"
|
|
|
|
module Autospec
|
|
|
|
class SimpleRunner < RspecRunner
|
|
def initialize
|
|
@mutex = Mutex.new
|
|
end
|
|
|
|
def run(specs)
|
|
puts "Running Rspec: #{specs}"
|
|
# kill previous rspec instance
|
|
@mutex.synchronize do
|
|
self.abort
|
|
end
|
|
# we use our custom rspec formatter
|
|
args = [
|
|
"-r", "#{File.dirname(__FILE__)}/formatter.rb",
|
|
"-f", "Autospec::Formatter"
|
|
]
|
|
|
|
command = begin
|
|
if ENV["PARALLEL_SPEC"] == '1' &&
|
|
!specs.split.any? { |s| puts s; s =~ /\:/ } # Parallel spec can't run specific groups
|
|
|
|
"bin/turbo_rspec #{args.join(" ")} #{specs.split.join(" ")}"
|
|
else
|
|
"bin/rspec #{args.join(" ")} #{specs.split.join(" ")}"
|
|
end
|
|
end
|
|
|
|
# launch rspec
|
|
Dir.chdir(Rails.root) do # rubocop:disable DiscourseCops/NoChdir because this is not part of the app
|
|
env = { "RAILS_ENV" => "test" }
|
|
if specs.split(' ').any? { |s| s =~ /^(.\/)?plugins/ }
|
|
env["LOAD_PLUGINS"] = "1"
|
|
puts "Loading plugins while running specs"
|
|
end
|
|
pid =
|
|
@mutex.synchronize do
|
|
@pid = Process.spawn(env, command)
|
|
end
|
|
|
|
_, status = Process.wait2(pid)
|
|
|
|
status.exitstatus
|
|
end
|
|
end
|
|
|
|
def abort
|
|
if pid = @pid
|
|
Process.kill("TERM", pid) rescue nil
|
|
wait_for_done(pid)
|
|
pid = nil
|
|
end
|
|
end
|
|
|
|
def stop
|
|
# assume sigint on child will take care of this?
|
|
if pid = @pid
|
|
wait_for_done(pid)
|
|
end
|
|
end
|
|
|
|
def wait_for_done(pid)
|
|
i = 3000
|
|
while (i > 0 && Process.getpgid(pid) rescue nil)
|
|
sleep 0.001
|
|
i -= 1
|
|
end
|
|
if (Process.getpgid(pid) rescue nil)
|
|
STDERR.puts "Terminating rspec #{pid} by force cause it refused graceful termination"
|
|
Process.kill("KILL", pid)
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
end
|