mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 22:23:44 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
52 lines
1.7 KiB
Ruby
52 lines
1.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Admin::PermalinksController do
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::PermalinksController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
let!(:user) { log_in(:admin) }
|
|
|
|
describe 'index' do
|
|
it 'filters url' do
|
|
Fabricate(:permalink, url: "/forum/23")
|
|
Fabricate(:permalink, url: "/forum/98")
|
|
Fabricate(:permalink, url: "/discuss/topic/45")
|
|
Fabricate(:permalink, url: "/discuss/topic/76")
|
|
|
|
xhr :get, :index, filter: "topic"
|
|
|
|
expect(response).to be_success
|
|
result = JSON.parse(response.body)
|
|
expect(result.length).to eq(2)
|
|
end
|
|
|
|
it 'filters external url' do
|
|
Fabricate(:permalink, external_url: "http://google.com")
|
|
Fabricate(:permalink, external_url: "http://wikipedia.org")
|
|
Fabricate(:permalink, external_url: "http://www.discourse.org")
|
|
Fabricate(:permalink, external_url: "http://try.discourse.org")
|
|
|
|
xhr :get, :index, filter: "discourse"
|
|
|
|
expect(response).to be_success
|
|
result = JSON.parse(response.body)
|
|
expect(result.length).to eq(2)
|
|
end
|
|
|
|
it 'filters url and external url both' do
|
|
Fabricate(:permalink, url: "/forum/23", external_url: "http://google.com")
|
|
Fabricate(:permalink, url: "/discourse/98", external_url: "http://wikipedia.org")
|
|
Fabricate(:permalink, url: "/discuss/topic/45", external_url: "http://discourse.org")
|
|
Fabricate(:permalink, url: "/discuss/topic/76", external_url: "http://try.discourse.org")
|
|
|
|
xhr :get, :index, filter: "discourse"
|
|
|
|
expect(response).to be_success
|
|
result = JSON.parse(response.body)
|
|
expect(result.length).to eq(3)
|
|
end
|
|
end
|
|
end
|