discourse/app
Jarek Radosz f0b2e77abb
FIX: Isolate modal and global key-binds (#12477)
This change makes is so that when a time-picking modal (e.g.  "Add bookmark" modal) is visible, **all** global key bindings are paused.

1. Fixes an issue where opening and closing a time-picking modal would break global single-key keybinds, so for example, <kbd>L</kbd> would no longer like posts, but <kbd>L</kbd> <kbd>L</kbd> would
2. Fixes a related issue, where doing the above would also override custom keybinds provided by plugins (e.g. <kbd>L</kbd> shortcut that discourse-reactions uses)

Included:

* DEV: Reset Mousetraps instead of unbinding
* FIX: Make unbind use unbind
* DEV: Don't check for keyTrapper twice
* DEV: Use an instance of Mousetrap
* DEV: Remove an invalid `for` attribute (`set_reminder` doesn't exist)
* DEV: Add ability to pause all KeyboardShortcuts
* FIX: Pause all keybinds when in a time-picking modal
* DEV: Move bookmark keybind resets to willDestroyElement
* DEV: Fix shortcuts-related tests
2021-03-29 13:58:03 +02:00
..
assets FIX: Isolate modal and global key-binds (#12477) 2021-03-29 13:58:03 +02:00
controllers FEATURE: Allow admins to pre-populate user fields (#12361) 2021-03-29 14:03:19 +03:00
helpers FEATURE: Implement nonces for Google Tag Manager integration (#12531) 2021-03-26 11:19:31 -04:00
jobs FEATURE: Allow admins to pre-populate user fields (#12361) 2021-03-29 14:03:19 +03:00
mailers FIX: Correctly use invite to topic email templates (#12411) 2021-03-16 17:08:54 +02:00
models FEATURE: Allow admins to pre-populate user fields (#12361) 2021-03-29 14:03:19 +03:00
serializers DEV: Deprecate message parameter in auth provider plugin API (#12523) 2021-03-25 13:23:48 +00:00
services FIX: Delete invalid web push subscriptions (#12447) 2021-03-19 14:24:03 +01:00
views FEATURE: Implement nonces for Google Tag Manager integration (#12531) 2021-03-26 11:19:31 -04:00