mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 00:44:12 +08:00
187b59d376
This commit implements all the necessary logic to create thread seamlessly. For this it relies on the same logic used for messages and generates a `staged-id`(using the format: `staged-thread-CHANNEL_ID-MESSAGE_ID` which is used to re-conciliate state client sides once the thread has been persisted on the backend. Part of this change the client side is now always using real thread and channel objects instead of sometimes relying on a flat `threadId` or `channelId`. This PR also brings three UX changes: - thread starts from top - number of buttons on message actions is dependent of the width of the enclosing container - <kbd>shift + ArrowUp</kbd> will reply to the last message
138 lines
4.3 KiB
Ruby
138 lines
4.3 KiB
Ruby
# frozen_string_literal: true
|
||
|
||
RSpec.describe "Archive channel", type: :system, js: true do
|
||
fab!(:channel_1) { Fabricate(:chat_channel) }
|
||
|
||
let(:chat) { PageObjects::Pages::Chat.new }
|
||
let(:channel) { PageObjects::Pages::ChatChannel.new }
|
||
|
||
before do
|
||
SiteSetting.navigation_menu = "sidebar"
|
||
chat_system_bootstrap
|
||
sign_in(current_user)
|
||
end
|
||
|
||
context "when archiving is disabled" do
|
||
context "when admin user" do
|
||
fab!(:current_user) { Fabricate(:admin) }
|
||
|
||
before { sign_in(current_user) }
|
||
|
||
it "doesn’t allow to archive a channel" do
|
||
chat.visit_channel_settings(channel_1)
|
||
|
||
expect(page).to have_no_content(I18n.t("js.chat.channel_settings.archive_channel"))
|
||
end
|
||
end
|
||
end
|
||
|
||
context "when archiving is enabled" do
|
||
before { SiteSetting.chat_allow_archiving_channels = true }
|
||
|
||
context "when regular user" do
|
||
fab!(:current_user) { Fabricate(:user) }
|
||
|
||
before { sign_in(current_user) }
|
||
|
||
it "doesn’t allow to archive a channel" do
|
||
chat.visit_channel_settings(channel_1)
|
||
|
||
expect(page).to have_no_content(I18n.t("js.chat.channel_settings.archive_channel"))
|
||
end
|
||
end
|
||
|
||
context "when admin user" do
|
||
fab!(:current_user) { Fabricate(:admin) }
|
||
|
||
before { sign_in(current_user) }
|
||
|
||
it "allows to archive a channel" do
|
||
chat.visit_channel_settings(channel_1)
|
||
|
||
expect(page).to have_content(I18n.t("js.chat.channel_settings.archive_channel"))
|
||
end
|
||
|
||
context "when archiving" do
|
||
it "works" do
|
||
Jobs.run_immediately!
|
||
|
||
chat.visit_channel_settings(channel_1)
|
||
click_button(I18n.t("js.chat.channel_settings.archive_channel"))
|
||
find("#split-topic-name").fill_in(with: "An interesting topic for cats")
|
||
click_button(I18n.t("js.chat.channel_archive.title"))
|
||
|
||
expect(page).to have_css(".chat-channel-archive-status", wait: 15)
|
||
end
|
||
|
||
it "shows an error when the topic is invalid" do
|
||
Jobs.run_immediately!
|
||
|
||
chat.visit_channel_settings(channel_1)
|
||
click_button(I18n.t("js.chat.channel_settings.archive_channel"))
|
||
find("#split-topic-name").fill_in(
|
||
with: "An interesting topic for cats :cat: :cat2: :smile_cat:",
|
||
)
|
||
click_button(I18n.t("js.chat.channel_archive.title"))
|
||
|
||
expect(page).to have_no_content(I18n.t("js.chat.channel_archive.process_started"))
|
||
expect(page).to have_content("Title can't have more than 1 emoji")
|
||
end
|
||
|
||
context "when archived channels had unreads" do
|
||
before { channel_1.add(current_user) }
|
||
|
||
it "clears unread indicators" do
|
||
Jobs.run_immediately!
|
||
|
||
other_user = Fabricate(:user)
|
||
channel_1.add(other_user)
|
||
Chat::MessageCreator.create(
|
||
chat_channel: channel_1,
|
||
user: other_user,
|
||
content: "this is fine @#{current_user.username}",
|
||
)
|
||
|
||
visit("/")
|
||
expect(page.find(".chat-channel-unread-indicator")).to have_content(1)
|
||
|
||
chat.visit_channel_settings(channel_1)
|
||
click_button(I18n.t("js.chat.channel_settings.archive_channel"))
|
||
find("#split-topic-name").fill_in(with: "An interesting topic for cats")
|
||
click_button(I18n.t("js.chat.channel_archive.title"))
|
||
|
||
expect(page).to have_no_css(".chat-channel-unread-indicator")
|
||
end
|
||
end
|
||
end
|
||
|
||
context "when archiving failed" do
|
||
before { channel_1.update!(status: :read_only) }
|
||
|
||
fab!(:archive) do
|
||
Chat::ChannelArchive.create!(
|
||
chat_channel: channel_1,
|
||
archived_by: current_user,
|
||
destination_topic_title: "This will be the archive topic",
|
||
total_messages: 2,
|
||
archived_messages: 1,
|
||
archive_error: "Something went wrong",
|
||
)
|
||
end
|
||
|
||
xit "can be retried" do
|
||
Jobs.run_immediately!
|
||
|
||
chat.visit_channel(channel_1)
|
||
click_button(I18n.t("js.chat.channel_archive.retry"))
|
||
expect(page).to have_css(".chat-channel-archive-status a")
|
||
|
||
new_window = window_opened_by { find(".chat-channel-archive-status a").click }
|
||
within_window(new_window) do
|
||
expect(page).to have_content(archive.destination_topic_title)
|
||
end
|
||
end
|
||
end
|
||
end
|
||
end
|
||
end
|