mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 09:42:07 +08:00
821bb1e8cb
The 'Discourse SSO' protocol is being rebranded to DiscourseConnect. This should help to reduce confusion when 'SSO' is used in the generic sense. This commit aims to: - Rename `sso_` site settings. DiscourseConnect specific ones are prefixed `discourse_connect_`. Generic settings are prefixed `auth_` - Add (server-side-only) backwards compatibility for the old setting names, with deprecation notices - Copy `site_settings` database records to the new names - Rename relevant translation keys - Update relevant translations This commit does **not** aim to: - Rename any Ruby classes or methods. This might be done in a future commit - Change any URLs. This would break existing integrations - Make any changes to the protocol. This would break existing integrations - Change any functionality. Further normalization across DiscourseConnect and other auth methods will be done separately The risks are: - There is no backwards compatibility for site settings on the client-side. Accessing auth-related site settings in Javascript is fairly rare, and an error on the client side would not be security-critical. - If a plugin is monkey-patching parts of the auth process, changes to locale keys could cause broken error messages. This should also be unlikely. The old site setting names remain functional, so security-related overrides will remain working. A follow-up commit will be made with a post-deploy migration to delete the old `site_settings` rows. |
||
---|---|---|
.. | ||
allowed_ip_address_validator_spec.rb | ||
category_search_priority_weights_validator_spec.rb | ||
email_setting_validator_spec.rb | ||
email_validator_spec.rb | ||
enable_invite_only_validator_spec.rb | ||
enable_local_logins_via_email_validator_spec.rb | ||
enable_sso_validator_spec.rb | ||
external_system_avatars_validator_spec.rb | ||
group_setting_validator_spec.rb | ||
integer_setting_validator_spec.rb | ||
ip_address_format_validator_spec.rb | ||
max_emojis_validator_spec.rb | ||
max_username_length_validator_spec.rb | ||
min_username_length_validator_spec.rb | ||
password_validator_spec.rb | ||
post_validator_spec.rb | ||
quality_title_validator_spec.rb | ||
regex_presence_validator_spec.rb | ||
regex_setting_validator_spec.rb | ||
reply_by_email_address_validator_spec.rb | ||
reply_by_email_enabled_validator_spec.rb | ||
selectable_avatars_enabled_validator_spec.rb | ||
sso_overrides_email_validator_spec.rb | ||
string_setting_validator_spec.rb | ||
topic_title_length_validator_spec.rb | ||
unicode_username_allowlist_validator_spec.rb | ||
unicode_username_validator_spec.rb | ||
upload_validator_spec.rb | ||
url_validator_spec.rb | ||
user_full_name_validator_spec.rb | ||
username_setting_validator_spec.rb |