mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 21:57:36 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
39 lines
1.4 KiB
Ruby
39 lines
1.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Jobs::PendingQueuedPostReminder do
|
|
context "notify_about_queued_posts_after is 0" do
|
|
before { SiteSetting.stubs(:notify_about_queued_posts_after).returns(0) }
|
|
|
|
it "never emails" do
|
|
described_class.any_instance.expects(:should_notify_ids).never
|
|
Email::Sender.any_instance.expects(:send).never
|
|
described_class.new.execute({})
|
|
end
|
|
end
|
|
|
|
context "notify_about_queued_posts_after is 24" do
|
|
before { SiteSetting.stubs(:notify_about_queued_posts_after).returns(24) }
|
|
|
|
it "doesn't email if there are no queued posts" do
|
|
described_class.any_instance.stubs(:should_notify_ids).returns([])
|
|
described_class.any_instance.stubs(:last_notified_id).returns(nil)
|
|
Email::Sender.any_instance.expects(:send).never
|
|
described_class.new.execute({})
|
|
end
|
|
|
|
it "emails if there are new queued posts" do
|
|
described_class.any_instance.stubs(:should_notify_ids).returns([1,2])
|
|
described_class.any_instance.stubs(:last_notified_id).returns(nil)
|
|
Email::Sender.any_instance.expects(:send).once
|
|
described_class.new.execute({})
|
|
end
|
|
|
|
it "doesn't email again about the same posts" do
|
|
described_class.any_instance.stubs(:should_notify_ids).returns([2])
|
|
described_class.any_instance.stubs(:last_notified_id).returns(2)
|
|
Email::Sender.any_instance.expects(:send).never
|
|
described_class.new.execute({})
|
|
end
|
|
end
|
|
end
|